docs(graphiti): protocol reference, agent registry, integration guide - #876
Conversation
…on guide AGNOTE4482 — standalone Graphiti trail protocol documentation: - GRAPHITI_PROTOCOL_REFERENCE.md: full spec (HMAC signing, NATS emission, validation) - GRAPHITI_AGENT_REGISTRY.md: 9-agent identity catalog with visual rendering - GRAPHITI_INTEGRATION_GUIDE.md: Python + TypeScript integration patterns Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5af407421
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ### Adding a New Agent | ||
|
|
||
| ```yaml | ||
| agents: |
There was a problem hiding this comment.
Use
signatures: in the agent_signatures YAML example
This snippet tells contributors to add new entries under agents:, but sign_trail.py reads data.get("signatures", {}) when resolving agent identities, so agents added exactly as documented here will be ignored and the tool will fall back to default glyph/color/voice attribution. Please change the example root key to signatures: to match the runtime loader.
Useful? React with 👍 / 👎.
|
|
||
| | Source | Trigger | Payload | | ||
| |--------|---------|---------| | ||
| | `sign_trail.py` CLI | Manual invocation | Signed/unsigned payload | |
There was a problem hiding this comment.
Stop documenting
sign_trail.py as a NATS emission source
In this emission-points table, sign_trail.py is described as publishing trail events, but the current CLI implementation only builds/signs/logs payloads and prints JSON; it has no NATS publish call. Users following this reference and running make -C pmoves sign-trail will not produce agent.graphiti.signed.v1 messages for downstream consumers.
Useful? React with 👍 / 👎.
|
|
||
| ### Disabling Auto-Signing | ||
|
|
||
| Set `GRAPHITI_AUTO_SIGN=false` in your environment to disable hook-based signing. |
There was a problem hiding this comment.
Remove unsupported
GRAPHITI_AUTO_SIGN disable instruction
This guide says setting GRAPHITI_AUTO_SIGN=false disables auto-signing, but the hook script does not read that variable, so auto-signing still runs when path/tool conditions match. Operators relying on this documented toggle can unintentionally keep emitting trail entries despite believing it is disabled.
Useful? React with 👍 / 👎.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- GRAPHITI_AGENT_REGISTRY: change `agents:` → `signatures:` in YAML example to match agent_signatures.yaml root key and sign_trail.py - GRAPHITI_PROTOCOL_REFERENCE: clarify sign_trail.py produces payloads locally and does not publish to NATS directly - GRAPHITI_INTEGRATION_GUIDE: replace nonexistent GRAPHITI_AUTO_SIGN env var with accurate hook-based configuration info Addresses 3 Codex review comments on PR #876. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
#7DD3FC matches pmoves/config/agent_signatures.yaml:114 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
agent.graphiti.signed.v1), validation, 9-agent registry (AGNOTE4482)Test plan
pmoves/config/agent_signatures.yamlpmoves/tools/chit_security.pybehavior🤖 Generated with Claude Code