feat(compose): expand healthcheck coverage across core services - #798
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded healthcheck configurations to multiple services in docker-compose.yml. Each healthcheck specifies a test command (HTTP endpoints or process checks), interval, timeout, retries, and start_period. No changes to core service definitions or dependencies; Docker now monitors container health status. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pmoves/docker-compose.yml (1)
830-835: Promote dependency conditions fromservice_startedtoservice_healthyfor services that now define healthchecks.Healthchecks are defined for qdrant, meilisearch, and minio, but multiple downstream services still depend on them using
service_started. This leaves startup race windows where containers start but may not be ready. Update the following dependencies to useservice_healthy:
- qdrant: hi-rag-gateway, extract-worker, hi-rag-gateway-v2, hi-rag-gateway-gpu, hi-rag-gateway-v2-gpu
- meilisearch: extract-worker
- minio: presign, extract-worker, pdf-ingest, transcribe-backend, pmoves-yt, comfy-watcher
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pmoves/docker-compose.yml` around lines 830 - 835, Update the docker-compose service dependency conditions so services that rely on qdrant, meilisearch, or minio wait for health checks instead of just container start: replace any depends_on entries using condition: service_started for qdrant in services hi-rag-gateway, extract-worker, hi-rag-gateway-v2, hi-rag-gateway-gpu, hi-rag-gateway-v2-gpu to condition: service_healthy; for meilisearch update extract-worker to use service_healthy; and for minio update presign, extract-worker, pdf-ingest, transcribe-backend, pmoves-yt, comfy-watcher to use service_healthy. Ensure the referenced service names (qdrant, meilisearch, minio) match the healthcheck definitions and remove/adjust any duplicate depends_on keys accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pmoves/docker-compose.yml`:
- Around line 1512-1517: The healthcheck is probing the old /healthz path;
update the healthcheck test command in the docker-compose healthcheck blocks
(the healthcheck -> test entries that call python3
urllib.request.urlopen('http://localhost:8086/healthz', ...)) to use the Hi-RAG
v2 admin stats path /hirag/admin/stats and ensure the correct port for the
service (CPU :8086, GPU :8087) is used where applicable so the test URL becomes
http://localhost:8086/hirag/admin/stats (or :8087 for GPU services).
---
Nitpick comments:
In `@pmoves/docker-compose.yml`:
- Around line 830-835: Update the docker-compose service dependency conditions
so services that rely on qdrant, meilisearch, or minio wait for health checks
instead of just container start: replace any depends_on entries using condition:
service_started for qdrant in services hi-rag-gateway, extract-worker,
hi-rag-gateway-v2, hi-rag-gateway-gpu, hi-rag-gateway-v2-gpu to condition:
service_healthy; for meilisearch update extract-worker to use service_healthy;
and for minio update presign, extract-worker, pdf-ingest, transcribe-backend,
pmoves-yt, comfy-watcher to use service_healthy. Ensure the referenced service
names (qdrant, meilisearch, minio) match the healthcheck definitions and
remove/adjust any duplicate depends_on keys accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3679ce0e-7c7d-47d1-9e8a-6098f5acc8f7
📒 Files selected for processing (1)
pmoves/docker-compose.yml
|
Addressed CodeRabbit actionable items in commit
|
Summary
pmoves/docker-compose.ymlScope
pmoves/docker-compose.ymlonlyValidation
make -C pmoves compose ARGS="config -q"(pass)Notes
Summary by CodeRabbit