Skip to content

feat(compose): expand healthcheck coverage across core services - #798

Merged
POWERFULMOVES merged 2 commits into
mainfrom
feat/healthcheck-coverage
Mar 6, 2026
Merged

POWERFULMOVES merged 2 commits into
mainfrom
feat/healthcheck-coverage

Conversation

@POWERFULMOVES

@POWERFULMOVES POWERFULMOVES commented Mar 5, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • add healthchecks across core, worker, media, agent, and integration services in pmoves/docker-compose.yml
  • standardize intervals/timeouts/retries/start periods by service class
  • improve container-level readiness visibility for production bring-up and monitoring

Scope

  • file changed: pmoves/docker-compose.yml only
  • net change: +234 lines (healthcheck blocks)

Validation

  • make -C pmoves compose ARGS="config -q" (pass)

Notes

  • this PR intentionally excludes other local audit/tooling changes and only carries the compose healthcheck expansion lane.

Summary by CodeRabbit

  • Chores
    • Enhanced infrastructure health monitoring across services to improve system reliability and availability detection.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Mar 5, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@POWERFULMOVES has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 16 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 01a71144-0475-4a70-b3f1-851241d604a7

📥 Commits

Reviewing files that changed from the base of the PR and between e49b978 and 4571a8e.

📒 Files selected for processing (1)
  • pmoves/docker-compose.yml
📝 Walkthrough

Walkthrough

Added healthcheck configurations to multiple services in docker-compose.yml. Each healthcheck specifies a test command (HTTP endpoints or process checks), interval, timeout, retries, and start_period. No changes to core service definitions or dependencies; Docker now monitors container health status.

Changes

Cohort / File(s) Summary
Docker Healthcheck Configuration
pmoves/docker-compose.yml
Added healthcheck blocks to services including qdrant, meilisearch, minio, hi-rag gateways, retrieval-eval, presign, language extraction, transcribe-backend, QA/LLM services, gateway, and auxiliary components. Consistent configuration pattern with 30s intervals, 10s timeouts, and service-specific test commands (HTTP endpoints or process checks).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 With whiskers twitching, checks now in place,
Each service hops with healthful grace,
Thirty-second pulses, hearts that beat,
Container wellness, steady and sweet!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes a summary and validation sections, but lacks the Testing section with test commands/output and Required Checks confirmation as specified in the repository template. Add a Testing section documenting test commands and their outputs, and confirm or address all Required Checks items (CHIT Contract Check, contracts/schemas updates, documentation updates).
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat(compose): expand healthcheck coverage across core services' accurately and concisely describes the main change in the PR, which adds healthcheck configurations to multiple services.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/healthcheck-coverage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
pmoves/docker-compose.yml (1)

830-835: Promote dependency conditions from service_started to service_healthy for services that now define healthchecks.

Healthchecks are defined for qdrant, meilisearch, and minio, but multiple downstream services still depend on them using service_started. This leaves startup race windows where containers start but may not be ready. Update the following dependencies to use service_healthy:

  • qdrant: hi-rag-gateway, extract-worker, hi-rag-gateway-v2, hi-rag-gateway-gpu, hi-rag-gateway-v2-gpu
  • meilisearch: extract-worker
  • minio: presign, extract-worker, pdf-ingest, transcribe-backend, pmoves-yt, comfy-watcher
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@pmoves/docker-compose.yml` around lines 830 - 835, Update the docker-compose
service dependency conditions so services that rely on qdrant, meilisearch, or
minio wait for health checks instead of just container start: replace any
depends_on entries using condition: service_started for qdrant in services
hi-rag-gateway, extract-worker, hi-rag-gateway-v2, hi-rag-gateway-gpu,
hi-rag-gateway-v2-gpu to condition: service_healthy; for meilisearch update
extract-worker to use service_healthy; and for minio update presign,
extract-worker, pdf-ingest, transcribe-backend, pmoves-yt, comfy-watcher to use
service_healthy. Ensure the referenced service names (qdrant, meilisearch,
minio) match the healthcheck definitions and remove/adjust any duplicate
depends_on keys accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pmoves/docker-compose.yml`:
- Around line 1512-1517: The healthcheck is probing the old /healthz path;
update the healthcheck test command in the docker-compose healthcheck blocks
(the healthcheck -> test entries that call python3
urllib.request.urlopen('http://localhost:8086/healthz', ...)) to use the Hi-RAG
v2 admin stats path /hirag/admin/stats and ensure the correct port for the
service (CPU :8086, GPU :8087) is used where applicable so the test URL becomes
http://localhost:8086/hirag/admin/stats (or :8087 for GPU services).

---

Nitpick comments:
In `@pmoves/docker-compose.yml`:
- Around line 830-835: Update the docker-compose service dependency conditions
so services that rely on qdrant, meilisearch, or minio wait for health checks
instead of just container start: replace any depends_on entries using condition:
service_started for qdrant in services hi-rag-gateway, extract-worker,
hi-rag-gateway-v2, hi-rag-gateway-gpu, hi-rag-gateway-v2-gpu to condition:
service_healthy; for meilisearch update extract-worker to use service_healthy;
and for minio update presign, extract-worker, pdf-ingest, transcribe-backend,
pmoves-yt, comfy-watcher to use service_healthy. Ensure the referenced service
names (qdrant, meilisearch, minio) match the healthcheck definitions and
remove/adjust any duplicate depends_on keys accordingly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3679ce0e-7c7d-47d1-9e8a-6098f5acc8f7

📥 Commits

Reviewing files that changed from the base of the PR and between b8c339e and e49b978.

📒 Files selected for processing (1)
  • pmoves/docker-compose.yml

Comment thread pmoves/docker-compose.yml
@POWERFULMOVES

Copy link
Copy Markdown
Owner Author

Addressed CodeRabbit actionable items in commit 4571a8e7:

  • switched targeted depends_on entries from service_started to service_healthy for qdrant/meilisearch/minio dependencies (hi-rag gateways, extract-worker, presign, pdf-ingest, transcribe-backend, pmoves-yt, comfy-watcher)
  • updated Hi-RAG healthchecks to /hirag/admin/stats on port 8086 for CPU/GPU variants
  • validated compose syntax with make -C pmoves compose ARGS="config -q"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants