-
Notifications
You must be signed in to change notification settings - Fork 2
chore(submodules): bump 4 gitlinks and refresh deterministic evidence #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule PMOVES-DoX
updated
2 files
| +1 −1 | backend/app/services/agent_dispatcher.py | |
| +1 −2 | backend/tests/test_advanced_processors.py |
Submodule PMOVES-Open-Notebook
updated
2 files
| +3 −4 | tests/conftest.py | |
| +4 −1 | tests/test_models_api.py |
Submodule PMOVES-transcribe-and-fetch
updated
2 files
| +13 −0 | .gitmodules | |
| +51 −0 | PMOVES.AI_INTEGRATION.md |
Submodule Pmoves-cipher
updated
3 files
| +92 −30 | PMOVES.AI_INTEGRATION.md | |
| +10 −4 | src/core/brain/memAgent/__test__/loader.test.ts | |
| +3 −1 | src/core/brain/tools/definitions/system/__test__/bash.test.ts |
72 changes: 72 additions & 0 deletions
72
pmoves/docs/AGENTS/SUBMODULE_ATOMIC_PR_STRATEGY_2026-03-03.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| # Submodule Atomic PR Strategy (2026-03-03) | ||
|
|
||
| ## Scope | ||
|
|
||
| Production-lane closeout for currently dirty submodules and parent evidence refresh, with atomic commits and deterministic local validation. | ||
|
|
||
| ## Required Context | ||
|
|
||
| - Branch posture: `PMOVES.AI-Edition-Hardened` remains production release lane. | ||
| - Sprint posture: keep M2 creator/publishing active while closing production audit gates. | ||
| - Operator sequence remains fixed: `env-setup -> env-check -> supa-start -> supabase-bootstrap -> up -> smoke -> smoke-gpu`. | ||
|
|
||
| ## Lane Ownership (KRISS KROSS) | ||
|
|
||
| - `Codex`: implement code/doc fixes, run local validation, produce atomic commits, open/update PRs. | ||
| - `Claude`: parallel PR review lane, comment triage, merge execution once checks and review gates are satisfied. | ||
| - Collision rule: no shared-file edits in parallel; if overlap appears, pause and rebase before further edits. | ||
|
|
||
| ## Atomic Commit Plan | ||
|
|
||
| 1. `PMOVES-transcribe-and-fetch` | ||
| - Add nested submodule mapping (`.gitmodules`) for recursive integrity. | ||
| - Add `PMOVES.AI_INTEGRATION.md` dossier for PMOVES integration contract and validation path. | ||
|
|
||
| 2. `PMOVES-Open-Notebook` | ||
| - Keep auth fail-closed in tests and inject bearer header in API client tests. | ||
|
|
||
| 3. `Pmoves-cipher` | ||
| - Make memAgent env-var tests deterministic across platforms. | ||
| - Skip bash tool test suite on Windows where `/bin/bash` is unavailable. | ||
|
|
||
| 4. `PMOVES-DoX` | ||
| - Sync chart processor test with current sync API (`process_charts` no longer async). | ||
| - Fix cache expiry boundary in dispatcher (`>=` at expiration edge). | ||
|
|
||
| 5. Parent repo (`PMOVES.AI`) | ||
| - Update submodule gitlinks after submodule commits. | ||
| - Commit deterministic evidence refresh: | ||
| - `pmoves/docs/SUBMODULE_LAYER_VALIDATION.md` | ||
| - `pmoves/docs/SUBMODULE_LAYER_RUNALL.md` | ||
| - `pmoves/docs/evidence/submodule_layer/*` | ||
| - `pmoves/docs/evidence/submodule_layer_validation.json` | ||
| - `pmoves/docs/evidence/submodule_layer_runall.json` | ||
| - `pmoves/docs/evidence/submodule_test_matrix*.md|json` | ||
|
|
||
| ## Validation Gate Pack | ||
|
|
||
| Submodule-local checks: | ||
|
|
||
| - `PMOVES-Open-Notebook`: `uv run --project . python -m pytest -q tests --maxfail=1` -> expected pass. | ||
| - `Pmoves-cipher`: `npx vitest run src/core/brain/memAgent/__test__/loader.test.ts src/core/brain/tools/definitions/system/__test__/bash.test.ts` -> expected pass with Windows bash suite skipped. | ||
| - `PMOVES-DoX`: targeted tests currently reproduce pre-existing stale expectation in `backend/tests/test_agent_dispatcher.py` (`_pending_tasks` removed in current implementation). | ||
|
|
||
| Parent deterministic checks: | ||
|
|
||
| - `make -C pmoves submodule-layer-validate-all-strict` | ||
| - `make -C pmoves submodule-integrity-strict` | ||
|
|
||
| ## PR Order | ||
|
|
||
| 1. Submodule PR: `PMOVES-transcribe-and-fetch` | ||
| 2. Submodule PR: `PMOVES-Open-Notebook` | ||
| 3. Submodule PR: `Pmoves-cipher` | ||
| 4. Submodule PR: `PMOVES-DoX` | ||
| 5. Parent PR: gitlinks + validation evidence | ||
|
|
||
| If CI queue starvation blocks merge, preserve latest `main` runs and cancel stale queued/pending non-main runs first. | ||
|
|
||
| ## Handoff Notes | ||
|
|
||
| - DoX has a known packaging/test-env friction in `uv run` (editable build discovery on flat-layout). Use targeted venv-backed pytest invocation for local reproduction until packaging metadata is normalized. | ||
| - Keep test-failure triage explicit in PR notes when failure is pre-existing and outside the change set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
pmoves/docs/evidence/submodule_layer/PMOVES-E2B-Danger-Room-Desktop.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit hash mismatch with master validation file.
This file shows commit
035364ce...with status+, butsubmodule_layer_validation.json(line 183) shows a different commit605f2dde...with status. The timestamp difference (03:53 vs 02:38 UTC) suggests these artifacts were generated at different times.Regenerate the master validation file to ensure all evidence artifacts are consistent, or clarify if these files intentionally track different validation runs.
🤖 Prompt for AI Agents