fix(nats): robust stream init + downstream dependency - #648
Merged
POWERFULMOVES merged 2 commits intoFeb 17, 2026
Conversation
…ms.sh The add_stream() helper used `|| echo "already exists"` which defeated `set -e` and masked all errors (auth failures, JetStream disabled, disk full, etc.) as benign "already exists" messages. Now: captures nats CLI output, greps for "already in use"/"already exists" to classify the exit code. Real failures print stderr output, increment FAIL_COUNT, and cause a non-zero exit at script end. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Services that rely on JetStream streams (agent-zero, botz-gateway, a2ui-nats-bridge) now depend on nats-init with service_completed_successfully. This ensures streams exist before consumers start, preventing runtime failures when publishing to geometry.>, tokenism.>, or botz.> subjects. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
POWERFULMOVES
merged commit Feb 17, 2026
57fb9f1
into
PMOVES.AI-Edition-Hardened
6 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_stream()to capture nats CLI output, grep for "already in use"/"already exists" to classify exit codes. Real failures (auth, JetStream disabled, disk full) now print stderr and cause non-zero exit.nats-init: service_completed_successfullydependency to agent-zero, botz-gateway, and a2ui-nats-bridge so they wait for stream creation before starting.Fixes silent failure audit issues #1 (CRITICAL) and #5 (HIGH).
Test plan
docker compose up nats nats-init— verify streams created, exit 0docker compose up --profile agents— verify agent-zero waits for nats-init🤖 Generated with Claude Code