fix(wsl2): Add --project-directory to all docker compose invocations - #590
Closed
POWERFULMOVES wants to merge 1 commit into
Closed
POWERFULMOVES wants to merge 1 commit into
POWERFULMOVES wants to merge 1 commit into
Conversation
WSL2 Docker Desktop requires explicit --project-directory for proper path resolution of relative paths in docker-compose.yml files. Changes: - Add PROJECT_DIR := --project-directory $(CURDIR) to Makefile - Update DC variable to include PROJECT_DIR - Fix 32 Makefile invocations: use $(DC) or add --project-directory - Fix 3 shell scripts: add --project-directory and env sourcing * apply_migrations_docker.sh * smoke-tests.sh * validate-phase1-hardening.sh Resolves CROSS_PLATFORM_TASKS.md - Issue C2. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Superseded by commits All changes from this PR have been incorporated with improvements:
The hardened branch includes the complete fix set, so this PR is being closed. |
POWERFULMOVES
pushed a commit
that referenced
this pull request
Feb 7, 2026
This commit addresses critical issues found during PR review: **PR #592 - TensorZero Port Consistency** - Fix internal container-to-container communication to use port 3000 (not host port 3030) across all services - Files updated: gateway-agent, deepresearch, agent-zero, n8n flows, tokenism-simulator, mcp configs, docker-compose overrides **PR #593 - ClickHouse Configuration** - Fix ClickHouse URL format to include embedded credentials - Remove unused separate USER/PASSWORD/DB environment variables **PR #595 - Documentation Port Fixes** - Correct Grafana port from 3000 to 3002 in documentation **PR #590 - Docker Compose --project-directory** - Add --project-directory to DC variable for WSL2 compatibility - Convert inline docker compose commands to use $(DC) variable - Fix up-supabase, backup, brand-defaults, and neo4j targets **PR #594 - Network Cleanup with Error Handling** - Add clean-networks target with improved error reporting - Provides warnings instead of silent failures - Integrated into 'up' target as pre-flight check **New Automated Tool** - Add port-consistency-check.sh script for validation - Can detect and auto-fix port inconsistencies Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
POWERFULMOVES
pushed a commit
that referenced
this pull request
Feb 7, 2026
This commit incorporates the remaining changes from open PRs that were not included in the initial port consistency fix commit: **From PR #590 (WSL2 --project-directory)** - Add --project-directory to apply_migrations_docker.sh - Add --project-directory to smoke-tests.sh - Add --project-directory to validate-phase1-hardening.sh - Remove unsafe 'cd' pattern, use explicit paths instead **From PR #591 (API Key Validation)** - Add provider API key validation to env_check.sh - Checks for OpenAI, Anthropic, Groq, Gemini, Ollama - Warns about empty/placeholder API keys - Provides helpful configuration tips **From PR #587 (Security Update)** - Update python-multipart to 0.0.22 (CVE-2026-24486 fix) - Applied to agentgym-rl-coordinator and Enhanced Media Stack plans - NOTE: Transformers constraint kept at <4.50.0 for FlagEmbedding All superseded PRs can now be closed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WSL2 Docker Desktop path resolution issues by adding
--project-directoryto all docker compose invocations.Root Cause
WSL2 Docker Desktop requires explicit
--project-directoryfor proper resolution of relative paths in docker-compose.yml files. Without it, bind mounts fail with "not a directory" errors.Changes
Makefile:
PROJECT_DIR := --project-directory $(CURDIR)variableDCvariable to includePROJECT_DIR$(DC)or add--project-directoryShell Scripts:
apply_migrations_docker.sh: Added env sourcing and--project-directorysmoke-tests.sh: Added--project-directoryto 3 invocationsvalidate-phase1-hardening.sh: Added--project-directoryto 3 invocations, removedcdpatternTest Plan
make up-supabaseworks in WSL2make backupworks in WSL2./scripts/smoke-tests.shworks in WSL2Resolves
CROSS_PLATFORM_TASKS.mdIssue C2.🤖 Generated with Claude Code