feat(services): add service discovery infrastructure with NATS + Supabase integration

[POWERFULMOVES]

Summary

This PR introduces a comprehensive service discovery infrastructure for PMOVES.AI, enabling dynamic service URL resolution with a hybrid fallback chain that supports both docked (docker compose) and standalone operation modes.

Features

Core Service Discovery Infrastructure

• service_registry.py: Hybrid service URL resolution with fallback chain (env var → Supabase → NATS → Docker DNS)
• nats_service_listener.py: Automatic NATS service announcements for real-time discovery
• service_catalog: Supabase migration for dynamic service registration

Service Discovery Tooling

• service_health_check.py: CLI tool for resolving service URLs
• common.sh: Bash utilities (service_url, service_healthy, wait_for_service)
• Makefile: SERVICE_URL helper macro for dynamic resolution

Frontend Integration

• serviceDiscovery.ts: TypeScript library with getServiceUrl() for UI components
• Supports environment variable → Supabase catalog → Docker DNS fallback

Additional Improvements

• GPU Orchestrator: Simplified initialization (195 line reduction)
• Hi-RAG v2: Enhanced configuration parsing and startup logging
• Gateway Services: Improved health checks and NATS publishing
• Testing: Removed outdated test components

Commits

1. feat(services): add core service discovery infrastructure with NATS announcements
2. feat(tools): add service discovery CLI tools and bash utilities
3. feat(ui): add TypeScript service discovery library
4. refactor(gpu-orchestrator): simplify initialization and remove validation overhead
5. feat(hirag-v2): enhance configuration parsing and startup logging
6. feat(services): integrate service discovery and enhance documentation
7. feat(gateways): enhance gateway services and remove redundant controller
8. test: remove outdated ingestion test component

Testing

• Service discovery works via environment variables
• Docker DNS fallback works in standalone mode
• All pre-commit security checks pass

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

• New Features

  • Added Model Registry service for dynamic model configuration and routing across providers
  • Introduced PMOVES Service Registry with multi-tier service discovery and NATS-based announcements
  • Added Persona Enhancement system for modular, per-persona configurations
  • Implemented security hooks for command and file operation control

• Infrastructure

  • Integrated service discovery across 15+ services with automatic health checks
  • Added comprehensive SQL migrations for service catalog, personas, and model management
  • Enhanced startup orchestration with lifespan-based service initialization

• Documentation

  • Added Model Registry, Service Startup, and Submodule Workflow guides

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR introduces three major new systems: a service discovery and registry infrastructure for dynamic service URL resolution with NATS-based announcements; a comprehensive security damage-control system for Claude tool usage with configurable blocking patterns; and a persona-based agent orchestration framework with EvoSwarm optimization and modular enhancements, plus a new Model Registry service for dynamic ML model configuration and routing.

Changes

Cohort / File(s)	Summary
Service Discovery & Registry pmoves/services/common/service_registry.py, pmoves/services/common/nats_service_listener.py, pmoves/tools/service_health_check.py, pmoves/scripts/common.sh, pmoves/ui/lib/serviceDiscovery.ts	Introduces multi-layer service URL resolution (environment variables → NATS cache → Supabase catalog → DNS fallback) with async functions, NATS-based service announcements/discovery, shell utilities, TypeScript client-side resolution, and in-memory caching with TTL.
Service Updates: Lifespan Refactoring pmoves/services/gateway-agent/app.py, pmoves/services/messaging-gateway/main.py, pmoves/services/session-context-worker/main.py	Replaced deprecated @app.on_event("startup"/"shutdown") handlers with @asynccontextmanager lifespan context managers for FastAPI lifecycle management; centralizes startup/shutdown sequencing.
Service Updates: NATS Announcements pmoves/services/agent-zero/main.py, pmoves/services/archon/main.py, pmoves/services/ffmpeg-whisper/server.py, pmoves/services/flute-gateway/main.py, pmoves/services/presign/api.py, pmoves/services/evo-controller/app.py	Added conditional NATS service announcement integration to startup, enabling dynamic service discovery registration with metadata (version, health check URL); includes graceful fallback when NATS unavailable.
GitHub Runner Controller: Credential Removal pmoves/services/github-runner-ctl/app.py, pmoves/services/github-runner-ctl/nats_publisher.py, pmoves/services/github-runner-ctl/Dockerfile	Removed NATS user/pass credentials from NATSPublisher initialization; eliminated offline event buffering and related state management; updated Dockerfile port defaults.
Security: Damage Control Hooks .claude/hooks/damage-control/bash-tool-damage-control.py, .claude/hooks/damage-control/edit-tool-damage-control.py, .claude/hooks/damage-control/write-tool-damage-control.py, .claude/hooks/damage-control/patterns.yaml, .claude/hooks/damage-control/test-damage-control.py	New security framework: Python hooks for blocking/asking permission on destructive bash/edit/write operations; YAML configuration for 742 dangerous patterns (rm, chmod, git, cloud ops, SQL, etc.); CLI test runner with interactive mode.
Persona Orchestration System pmoves/db/v5_13_persona_enhancements.sql, pmoves/db/v5_14_seed_standard_personas.sql, pmoves/services/evoswarm/__init__.py, pmoves/services/evoswarm/persona_optimizer.py	New persona management with modular enhancements table (geometry, voice, tool, weight, nats, model, eval types); EvoSwarm-based optimizer for persona parameter tuning; fitness computation and Supabase integration; 8 seeded production personas with thread types and model preferences.
Model Registry Service (New) pmoves/services/model-registry/main.py, pmoves/services/model-registry/migrate_tensorzero.py, pmoves/services/model-registry/Dockerfile, pmoves/services/model-registry/requirements.txt, pmoves/services/model-registry/README.md	New FastAPI service for dynamic ML model configuration: Supabase-backed providers/models/aliases/mappings/deployments, TensorZero TOML generation, service-to-model routing with priority/weight/fallback logic, migration script from TensorZero config, 7 provider types.
Flute Gateway: Pipecat & Service Discovery pmoves/services/flute-gateway/main.py, pmoves/services/flute-gateway/pipecat/config.py, pmoves/services/flute-gateway/pipecat/processors/tensorzero.py	Added optional Pipecat TTS pipeline integration; integrated service discovery for TensorZero gateway and model URL resolution with environment override fallback.
UI Service Discovery Integration pmoves/ui/lib/api/hirag.ts, pmoves/ui/lib/fluteClient.ts, pmoves/ui/lib/presign.ts	Refactored service URL resolution from static defaults to async service discovery calls; FluteClient now supports lazy URL resolution with pitch/emotion synthesis options; Hi-RAG and Presign clients use environment-variable-first resolution with service registry fallback.
Database Schema Additions pmoves/supabase/migrations/20250115000000_service_catalog.sql, pmoves/supabase/migrations/20250115_persona_agent_creation.sql, pmoves/supabase/migrations/20260115_model_registry.sql, pmoves/supabase/initdb/12_model_registry_seed.sql	New service_catalog table for dynamic service discovery; extended personas schema with thread_type, model_preference, temperature, system_prompt, tools_access, behavior_weights, eval_gates; comprehensive model registry schema (model_providers, models, aliases, service_model_mappings, deployments) with views and helper functions; seed data for 7 providers and 30+ models.
Configuration & Build pmoves/docker-compose.yml, pmoves/Makefile, .github/workflows/sql-policy-lint.yml, pmoves/.gitignore, .gitmodules	Added model-registry service to Compose; SERVICE_URL Makefile helper and Archon URL configuration; allowlisted 3 SQL migrations for policy lint; reorganized .gitignore to tier-based env patterns; removed ignore directives from gitmodules submodules.
Documentation .claude/context/mcp-api.md, .claude/context/submodule-workflow.md, pmoves/docs/MODEL_REGISTRY.md, pmoves/docs/PORT_REGISTRY.md, pmoves/docs/SERVICE_STARTUP.md, pmoves/tools/flight_check_retro.py	New MCP API docs for persona creation endpoints; submodule workflow guide; comprehensive Model Registry design doc; service startup ordering and health check guide; updated flight check to use environment-driven endpoint resolution.
Cleanup pmoves/pmoves/data/agent-zero/instruments/.gitkeep, pmoves/pmoves/data/agent-zero/knowledge/.gitkeep, pmoves/pmoves/data/agent-zero/logs/.gitkeep, pmoves/pmoves/data/agent-zero/memory/.gitkeep, pmoves/pmoves/data/agent-zero/runtime/.gitkeep, pmoves/pmoves/data/chit/env.cgp.json, pmoves/pmoves/docs/logs/*.json	Removed empty placeholder .gitkeep files; deleted legacy chit secrets file (1141 lines); deleted 7 archived MCP log files.
Submodule Updates PMOVES-A2UI, PMOVES-Agent-Zero, PMOVES-Archon, PMOVES-transcribe-and-fetch, pmoves/integrations/archon, pmoves/vendor/agentgym	Updated commit pointers for existing submodules; added new submodules for transcribe-and-fetch and agentgym vendor; removed ignore directives.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant UIClient as UI (serviceDiscovery.ts)
    participant EnvVars as Environment
    participant SupabaseAPI as Supabase Catalog
    participant DNSFallback as Docker DNS
    
    Client->>UIClient: Request service URL (slug, port)
    UIClient->>UIClient: Check cache
    alt Cache hit
        UIClient-->>Client: Return cached URL
    else Cache miss
        UIClient->>EnvVars: Resolve SERVICE_<SLUG>_URL
        alt Env override found
            EnvVars-->>UIClient: Return env URL
        else No env override
            UIClient->>SupabaseAPI: Query service_catalog (slug, active)
            alt Catalog entry found
                SupabaseAPI-->>UIClient: Return ServiceInfo
                UIClient->>UIClient: Normalize health_check_url
                UIClient->>UIClient: Cache result (TTL)
            else Catalog not found
                alt Production mode
                    UIClient-->>Client: Error: Service unresolved
                else Development mode
                    UIClient->>DNSFallback: Fallback: http://slug:port
                    DNSFallback-->>UIClient: Return fallback URL
                    UIClient->>UIClient: Cache result (TTL)
                end
            end
        end
        UIClient-->>Client: Return resolved URL
    end

Loading

sequenceDiagram
    participant Service as FastAPI Service
    participant NATS as NATS Broker
    participant ServiceRegistry as Service Registry
    
    Service->>Service: Startup (lifespan context)
    Service->>Service: Load config (port, slug, health_check)
    alt NATS available
        Service->>NATS: Publish service announcement
        Note over NATS: services.announce.v1<br/>slug, name, url, tier, port
        NATS-->>Service: Ack
        Service->>Service: Log success
    else NATS unavailable
        Service->>Service: Log warning, continue
    end
    
    alt Later: Another service needs discovery
        Note over Service: Runtime request
        Service->>ServiceRegistry: get_service_url(slug)
        ServiceRegistry->>ServiceRegistry: Check env override
        ServiceRegistry->>ServiceRegistry: Check NATS cache
        Note over ServiceRegistry: NATS announcements<br/>populate cache
        ServiceRegistry-->>Service: Return URL
    end

Loading

sequenceDiagram
    participant Claude as Claude Tool
    participant DamageControl as Bash Damage Control Hook
    participant PatternsYAML as patterns.yaml
    
    Claude->>DamageControl: JSON input (tool_name, command)
    DamageControl->>PatternsYAML: Load config patterns
    alt Config found
        DamageControl->>DamageControl: Parse bashToolPatterns
        DamageControl->>DamageControl: Check command vs patterns
        alt Pattern matches (ask=true)
            DamageControl-->>Claude: Exit 0, JSON permissionDecision: "ask"
        else Pattern matches (blocked)
            DamageControl-->>Claude: Exit 2, stderr security message
        else No patterns match
            DamageControl-->>Claude: Exit 0 (allowed)
        end
    else Config not found
        DamageControl->>DamageControl: Log warning, default allow
        DamageControl-->>Claude: Exit 0 (allowed)
    end

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Possibly related PRs

• feat(service-discovery): add NATS-based service discovery infrastructure and personas-first architecture #493: Both PRs implement service discovery and persona-related systems (nats_service_listener.py, service_registry.py, persona migrations, evoswarm optimizer, UI serviceDiscovery.ts).
• feat(services): update multiple service integrations #391: Both PRs refactor FastAPI service lifecycle by replacing startup/shutdown event handlers with asynccontextmanager-based lifespan functions across multiple services.
• feat: NATS infrastructure with A2UI bridge and GitHub Runner orchestration #395: Both PRs modify NATSPublisher behavior and NATS authentication/configuration across services (github-runner-ctl, nats_publisher.py).

Suggested labels

codex, architecture, security, database, services

Suggested reviewers

• hunnibear

---

🐰 A Rabbit's Ode to the Grand Refactor
Hop, hop! New discoveries in every hop,
Service registries bloom where paths once flopped,
Damage control shields us from careless paws,
Personas dance with EvoSwarm's gentle laws,
From chaos springs order—what a grand design!

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.