feat(publisher): enrich published events with metadata

[POWERFULMOVES]

Summary

• derive namespace-aware media paths, structured logging, and retry instrumentation in the publisher worker
• merge description/tags/meta and propagate Jellyfin lookup results when emitting content.published.v1
• document the richer contract and cover slug/metadata helpers with unit tests

Testing

• pytest pmoves/services/publisher/tests/test_publisher.py

---

https://chatgpt.com/codex/tasks/task_b_68ce3ff69dac8324a4977213b854d343

Summary by CodeRabbit

• New Features

  • Enhanced Content Publisher: stages approved media to structured paths and emits richer publish events including source description, tags, and merged metadata.
  • Optionally attaches a public URL and media library item ID after a successful library refresh.
  • Configurable public base URL for HTTP paths.

• Improvements

  • More reliable downloads with automatic retries and backoff.

• Documentation

  • Added smoke tests section for the Content Publisher, including setup and configuration notes.

• Tests

  • Added unit tests for slug/path generation and metadata merging in publish payloads.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

An async publisher service was introduced and documented. It listens for content.publish.approved.v1, downloads artifacts from MinIO, stages them under MEDIA_LIBRARY_PATH, optionally derives a public URL, triggers Jellyfin refresh and lookup, merges metadata, and publishes content.published.v1. Tests cover slugging, path derivation, and payload/metadata merging.

Changes

Cohort / File(s)	Summary
Docs: Smoke Tests pmoves/docs/SMOKETESTS.md	Added Content Publisher smoke test section detailing event subscription, media staging path via MEDIA_LIBRARY_PATH, enriched content.published.v1 payload (source description, tags, merged meta), optional public_url/jellyfin_item_id, and MEDIA_LIBRARY_PUBLIC_BASE_URL usage.
Publisher Service (Async rewrite) pmoves/services/publisher/publisher.py	Rewrote to async service with structured logging, metrics (PublisherMetrics), retrying downloads (DownloadError), Jellyfin refresh and item lookup, public URL derivation, slug/path utilities, metadata merge, and richer published payload. Subscribes to content.publish.approved.v1 and emits content.published.v1.
Unit Tests pmoves/services/publisher/tests/*	Added tests validating slugify, derive_output_path, and build_published_payload metadata merging and fields (artifact_uri, published_path, namespace, public_url, jellyfin_item_id).

Sequence Diagram(s)

sequenceDiagram
    participant A as Producer
    participant N as NATS
    participant P as Publisher Service
    participant M as MinIO
    participant F as Filesystem (MEDIA_LIBRARY_PATH)
    participant J as Jellyfin

    A->>N: Publish content.publish.approved.v1
    N->>P: Deliver approved payload
    P->>P: Validate payload, derive slug/output path
    P->>M: Download artifact (with retries)
    M-->>P: Artifact stream/bytes
    P->>F: Write to staged path
    alt Jellyfin configured
        P->>J: Trigger library refresh
        J-->>P: Refresh ack
        P->>J: Lookup item by title
        J-->>P: Item ID, (optional) URL components
        P->>P: Derive public_url (if base configured)
    else No Jellyfin
        P->>P: Optionally derive public_url from path
    end
    P->>P: Merge metadata, build published payload
    P->>N: Publish content.published.v1 (includes public_url/jellyfin_item_id if available)
    Note over P,N: Logs + metrics for downloads/refreshes/outcomes

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Poem

A hop, a bop, I queue and glide,
From NATS I snag the streaming tide—
I stage the bytes, then ping Jellyfin,
“Refreshed?” it nods; I publish with a grin.
Slugs and tags in tidy rows,
My little paws make payloads glow. 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 21f2491 and c1974f8.

📒 Files selected for processing (3)

• pmoves/docs/SMOKETESTS.md (1 hunks)
• pmoves/services/publisher/publisher.py (1 hunks)
• pmoves/services/publisher/tests/test_publisher.py (1 hunks)

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

[chatgpt-codex-connector]

[P1] Guard publisher callback against unexpected exceptions

The new handle callback no longer wraps its work in a top-level try/except block. If the incoming message is malformed (e.g. json.loads fails) or any unexpected error occurs later when building the envelope, the exception will now propagate out of the NATS subscription task and can crash the subscriber or leave the queue unprocessed. The previous version caught all exceptions and simply logged them. Consider restoring a defensive error boundary around the entire handler so a single bad message cannot tear down the worker.

Useful? React with 👍 / 👎.