fix(security): Upgrade PyTorch to 2.6.0 (Dependabot #61) - #344
Conversation
Addresses critical CVE in torch.load with weights_only=True. Changes: - torch: 2.3.1 → 2.6.0 - torchvision: 0.18.1 → 0.21.0 - torchaudio: 2.3.1 → 2.6.0 - CUDA wheels: cu121 → cu124⚠️ Breaking: Requires CUDA 12.4 runtime (was 12.1) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📚 Learning: 2025-12-07T11:03:07.638ZApplied to files:
📚 Learning: 2025-12-15T12:01:31.388ZApplied to files:
🪛 OSV Scanner (2.3.0)pmoves/services/media-video/requirements.txt[HIGH] 1-1: starlette 0.38.6: Starlette has possible denial-of-service vector when parsing large files in multipart forms [HIGH] 1-1: starlette 0.38.6: Starlette Denial of service (DoS) via multipart/form-data [HIGH] 1-1: urllib3 1.26.20: urllib3 streaming API improperly handles highly compressed data [HIGH] 1-1: urllib3 1.26.20: urllib3 allows an unbounded number of links in the decompression chain [HIGH] 1-1: urllib3 1.26.20: urllib3 redirects are not disabled when retries are disabled on PoolManager instantiation 🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pmoves/services/media-video/requirements.txt (1)
12-24: Address transitive dependency vulnerabilities in starlette and urllib3.Static analysis detected vulnerabilities in starlette and urllib3, which are transitive dependencies of FastAPI and requests/boto3:
- GHSA-f96h-pmfr-66vw: HIGH severity (8.7 CVSS) DoS in starlette <0.40.0 via multipart/form-data
- GHSA-2c2j-9gv5-cj73: MEDIUM severity (5.3 CVSS) DoS in starlette <0.47.2 when parsing large multipart files
- GHSA-gm62-xv2j-4w53: HIGH severity (8.9 CVSS) unbounded decompression chain in urllib3 versions prior to 2.6.0
FastAPI 0.114.2 allows starlette <0.42.0 (>=0.40.0), which mitigates GHSA-f96h-pmfr-66vw but leaves the service vulnerable to GHSA-2c2j-9gv5-cj73 and urllib3 compression vulnerabilities. Upgrade FastAPI to a version supporting starlette >=0.47.2, and ensure urllib3 is updated to 2.6.0 or later to address the decompression attack surface in multipart upload and HTTP client functionality.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pmoves/services/media-video/requirements.txt
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-12-07T11:03:07.638Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-07T11:03:07.638Z
Learning: Applies to **/pmoves/**/{media,analysis,pipeline}*.py : Implement `media-video` and `media-audio` analysis pipelines with GPU auto-detect for faster-whisper
Applied to files:
pmoves/services/media-video/requirements.txt
📚 Learning: 2025-12-15T12:01:31.388Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: pmoves/docs/ARTSTUFF/realtime/CLAUDE.md:0-0
Timestamp: 2025-12-15T12:01:31.388Z
Learning: Applies to pmoves/docs/ARTSTUFF/realtime/**/install.js : For AI/ML projects using PyTorch and related libraries, use the built-in torch.js script with parameters (xformers, triton, sageattention) to install cross-platform PyTorch dependencies
Applied to files:
pmoves/services/media-video/requirements.txt
🪛 OSV Scanner (2.3.0)
pmoves/services/media-video/requirements.txt
[HIGH] 1-1: starlette 0.38.6: Starlette has possible denial-of-service vector when parsing large files in multipart forms
[HIGH] 1-1: starlette 0.38.6: Starlette Denial of service (DoS) via multipart/form-data
[HIGH] 1-1: urllib3 1.26.20: urllib3 streaming API improperly handles highly compressed data
[HIGH] 1-1: urllib3 1.26.20: urllib3 allows an unbounded number of links in the decompression chain
[HIGH] 1-1: urllib3 1.26.20: urllib3 redirects are not disabled when retries are disabled on PoolManager instantiation
🔇 Additional comments (1)
pmoves/services/media-video/requirements.txt (1)
1-10: Verify PyTorch 2.6.0 with torchvision 0.21.0 compatibility before merging.PyTorch 2.6.0 addresses critical CVE-2025-32434 in torch.load, making this security update justified. However, a known compatibility issue exists: torchvision 0.21.0's wheel metadata declares torch >=2.8.0 as required, conflicting with torch 2.6.0.
Before merging:
- Verify the torchvision 0.21.0 metadata issue is resolved or use a compatible torchvision version
- Confirm Docker image for media-video service is updated to CUDA 12.4
- Validate YOLO object detection and smoke tests pass post-upgrade
The CUDA 12.4 configuration and platform-specific pins are correctly set.
Addresses critical CVE in torch.load with weights_only=True. Changes: - torch: 2.3.1 → 2.6.0 - torchvision: 0.18.1 → 0.21.0 - torchaudio: 2.3.1 → 2.6.0 - CUDA wheels: cu121 → cu124⚠️ Breaking: Requires CUDA 12.4 runtime (was 12.1) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Codex Agent <codex-agent@example.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Addresses critical CVE in torch.load with weights_only=True. Changes: - torch: 2.3.1 → 2.6.0 - torchvision: 0.18.1 → 0.21.0 - torchaudio: 2.3.1 → 2.6.0 - CUDA wheels: cu121 → cu124⚠️ Breaking: Requires CUDA 12.4 runtime (was 12.1) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Codex Agent <codex-agent@example.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Addresses critical CVE in torch.load with weights_only=True. Changes: - torch: 2.3.1 → 2.6.0 - torchvision: 0.18.1 → 0.21.0 - torchaudio: 2.3.1 → 2.6.0 - CUDA wheels: cu121 → cu124⚠️ Breaking: Requires CUDA 12.4 runtime (was 12.1) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Codex Agent <codex-agent@example.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Summary
Addresses critical CVE in
torch.loadwithweights_only=True(Dependabot alert #61).Changes
media-videoservice Docker imageTesting
make smokeafter rebuildRelated
🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.