chore(pmoves): DRY make targets + Ollama URL - #317
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
WalkthroughUpdates submodule references for PMOVES-Open-Notebook and PMOVES-Wealth. Refactors Makefile to use DC wrapper for Docker Compose operations. Updates Ollama service host references from "pmoves-ollama" to "ollama" across configuration and documentation files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/PMOVES.AI-Edition-Hardened-Full.md (1)
607-625: Consider updating the service name in the documentation example.The Docker Compose example shows the service named
pmoves-ollama, but the TensorZero configurations now reference theollamahostname. Consider either:
- Updating the compose example to rename the service to
ollama, OR- Adding a network alias section showing how
ollamais aliased topmoves-ollama, OR- Adding a note explaining the hostname difference if network aliases are configured elsewhere
Similarly, the service catalog (line 252) and port allocation table (line 306) still reference
pmoves-ollamaand should be updated to match the standardized hostname.Apply this diff to update the service name in the compose example:
- pmoves-ollama: + ollama: image: pmoves/ollama:0.12.6 restart: unless-stopped environment:Also update references in the service catalog and port table for consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
PMOVES-Open-Notebook(1 hunks)PMOVES-Wealth(1 hunks)docs/PMOVES.AI-Edition-Hardened-Full.md(2 hunks)pmoves/Makefile(2 hunks)pmoves/docs/pmoves-model-management-starter/README.md(1 hunks)pmoves/docs/venice-tensorzero-integration/README.md(1 hunks)pmoves/env.shared.example(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pmoves/env.shared.example
📄 CodeRabbit inference engine (AGENTS.md)
Copy env.shared.example → env.shared and fill in secrets; never commit real secrets in env.shared
Files:
pmoves/env.shared.example
🧠 Learnings (8)
📓 Common learnings
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: pmoves/AGENTS.md:0-0
Timestamp: 2025-12-07T11:03:53.415Z
Learning: Applies to pmoves/ui/**/*.{js,jsx,ts,tsx} : UI updates: run `make -C pmoves notebook-workbench-smoke ARGS="--thread=<uuid>"` to lint the Next.js bundle and validate Supabase connectivity; reference `pmoves/docs/UI_NOTEBOOK_WORKBENCH.md`
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-15T12:03:17.265Z
Learning: UI updates: run make -C pmoves notebook-workbench-smoke ARGS='--thread=<uuid>' to lint the Next.js bundle and validate Supabase connectivity; reference pmoves/docs/UI_NOTEBOOK_WORKBENCH.md
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: pmoves/AGENTS.md:0-0
Timestamp: 2025-12-07T11:03:53.415Z
Learning: Read `pmoves/docs/PMOVES.AI PLANS/ROADMAP.md` and `pmoves/docs/NEXT_STEPS.md` before making changes to align with current sprint focus
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: pmoves/AGENTS.md:0-0
Timestamp: 2025-12-07T11:03:53.415Z
Learning: Applies to pmoves/docs/LOCAL_CI_CHECKS.md : Before pushing, mirror the GitHub Actions checks documented in `docs/LOCAL_CI_CHECKS.md` (pytest suites, `make chit-contract-check`, `make jellyfin-verify`, SQL policy lint, env preflight)
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-15T12:03:17.265Z
Learning: Mandatory context before changes: read pmoves/docs/PMOVES.AI PLANS/ROADMAP.md and pmoves/docs/NEXT_STEPS.md to align with current sprint focus
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: pmoves/AGENTS.md:0-0
Timestamp: 2025-12-07T11:03:53.415Z
Learning: Applies to pmoves/services/{agent-zero,archon}/**/*.py : For Agents/Archon full-stack validation, follow the 'All Services Up, Then Tests' section in `pmoves/docs/SMOKETESTS.md` and use `make -C pmoves agents-headless-smoke`, `make -C pmoves smoke-gpu`, and `make -C pmoves verify-all`
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-15T12:03:17.265Z
Learning: Applies to services/**/README.md : Update services/*/README.md and pmoves/docs/PMOVES.AI PLANS/ runbooks when touching service operational code
📚 Learning: 2025-12-15T12:03:17.265Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-15T12:03:17.265Z
Learning: Applies to pmoves/env.shared.example : Copy env.shared.example → env.shared and fill in secrets; never commit real secrets in env.shared
Applied to files:
pmoves/env.shared.example
📚 Learning: 2025-12-07T11:03:53.415Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: pmoves/AGENTS.md:0-0
Timestamp: 2025-12-07T11:03:53.415Z
Learning: To keep embeddings local, launch your provider (e.g., `ollama`) and set `OLLAMA_API_BASE` before running `make notebook-seed-models`
Applied to files:
pmoves/env.shared.examplepmoves/docs/venice-tensorzero-integration/README.mdpmoves/docs/pmoves-model-management-starter/README.mddocs/PMOVES.AI-Edition-Hardened-Full.md
📚 Learning: 2025-12-15T12:03:17.265Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-15T12:03:17.265Z
Learning: Mandatory context before changes: read pmoves/docs/PMOVES.AI PLANS/ROADMAP.md and pmoves/docs/NEXT_STEPS.md to align with current sprint focus
Applied to files:
pmoves/docs/venice-tensorzero-integration/README.mdpmoves/docs/pmoves-model-management-starter/README.mdPMOVES-Wealthdocs/PMOVES.AI-Edition-Hardened-Full.md
📚 Learning: 2025-12-07T11:03:07.638Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-07T11:03:07.638Z
Learning: Applies to **/pmoves/**/*{qwen,gemma,audio,summary}*.py : Integrate Qwen2-Audio provider and add Gemma summaries to PMOVES.YT endpoints
Applied to files:
pmoves/docs/venice-tensorzero-integration/README.mdpmoves/docs/pmoves-model-management-starter/README.mdPMOVES-Wealthdocs/PMOVES.AI-Edition-Hardened-Full.md
📚 Learning: 2025-12-07T11:03:53.415Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: pmoves/AGENTS.md:0-0
Timestamp: 2025-12-07T11:03:53.415Z
Learning: Read `pmoves/docs/PMOVES.AI PLANS/ROADMAP.md` and `pmoves/docs/NEXT_STEPS.md` before making changes to align with current sprint focus
Applied to files:
pmoves/docs/pmoves-model-management-starter/README.mdPMOVES-Wealthdocs/PMOVES.AI-Edition-Hardened-Full.md
📚 Learning: 2025-12-15T12:03:17.265Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-15T12:03:17.265Z
Learning: Hi-RAG gateway: after touching reranker or embedding code, run make -C pmoves smoke-gpu to validate FlagEmbedding/Qwen rerankers
Applied to files:
pmoves/docs/pmoves-model-management-starter/README.md
📚 Learning: 2025-12-07T11:02:53.362Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-07T11:02:53.362Z
Learning: Call out mismatches between code changes and the runbooks (`pmoves/docs/NEXT_STEPS.md`, `pmoves/docs/ROADMAP.md`, `pmoves/docs/SESSION_IMPLEMENTATION_PLAN.md`) and suggest updates if missing
Applied to files:
docs/PMOVES.AI-Edition-Hardened-Full.md
🔇 Additional comments (8)
pmoves/docs/venice-tensorzero-integration/README.md (1)
20-22: OLLAMA_URL host change toollamalooks consistent with in-network aliasingSwitching
OLLAMA_URLtohttp://ollama:11434matches the in-network alias pattern from the PR description and keeps the hi‑rag gateway settings aligned with the rest of the stack. The docker stop example still correctly uses the container name, so no conflict here.PMOVES-Wealth (1)
1-1: Submodule pointer bump is straightforward and safeThis is a simple submodule commit update with no in-repo logic changes. As long as
19602b95805df2f93b764d00f0c9be32ed5a2ffbin PMOVES-Wealth has been vetted, this change looks good.docs/PMOVES.AI-Edition-Hardened-Full.md (1)
1022-1039: LGTM! TensorZero configuration updated consistently.Both model configurations now reference the standardized
ollama:11434hostname, aligning with the environment variable changes. The/v1path suffix is correct for OpenAI-compatible endpoints.pmoves/env.shared.example (1)
110-110: Docker Compose hostname coordination is properly configured.The
ollamahostname inenv.shared.exampleline 110 is correctly defined inpmoves/docker-compose.ymlvia network aliases on both theapp_tierandapi_tiernetworks. Thepmoves-ollamaservice uses these aliases to resolve theollamahostname, making the environment variable change valid and functional.However, note that
pmoves/tensorzero/config/tensorzero.toml(12 references) andpmoves/models/archon.yaml(1 reference) still hardcodepmoves-ollama:11434instead of using theOLLAMA_URLenvironment variable. For consistency, these should be updated to reference the environment variable or use theollamahostname to maintain alignment with the env.shared.example change.PMOVES-Open-Notebook (1)
1-1: Submodule pointer update looks fineThis file only updates the tracked commit for the
PMOVES-Open-Notebooksubmodule; no direct code/config behavior here. As long as this SHA corresponds to the intended version of the submodule (and you’ve rungit submodule update --remoteor equivalent when preparing the PR), this change is good to go.pmoves/docs/pmoves-model-management-starter/README.md (1)
6-6: LGTM! Documentation alignment with Ollama URL migration.The Ollama host reference update from
pmoves-ollamatoollamaaligns with the broader URL migration described in the PR objectives and maintains consistency with the updatedenv.shared.example.pmoves/Makefile (2)
184-185: LGTM! Improved consistency by using the DC wrapper.Using
$(DC)ensures the Archon service is started with the consistentPROJECTname and the fullSTACK_FILESset, which includesdocker-compose.archon.submodule.yml. Since Docker Compose only starts the explicitly named service (archon), loading additional file definitions should not cause issues.
241-243: Composition pattern is correct. Thedocker-compose.gpu.ymlis designed to augment (not replace) the base STACK_FILES with GPU-specific services (media-video,jellyfin-bridge), both profile-gated to avoid orphan container warnings. No changes needed.
- Update status date to 2025-12-18 - Add Prosodic TTS sidecar (PR #328): boundary-aware chunking, TTFS optimization - Add Pipecat multimodal layer Phase 1 (PR #332): STT/LLM/TTS processors - Add Flute Gateway Voice Agent Infrastructure section with API examples - Document UI security hardening (PRs #325-331) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
chore(pmoves): DRY make targets + Ollama URL
- Update status date to 2025-12-18 - Add Prosodic TTS sidecar (PR #328): boundary-aware chunking, TTFS optimization - Add Pipecat multimodal layer Phase 1 (PR #332): STT/LLM/TTS processors - Add Flute Gateway Voice Agent Infrastructure section with API examples - Document UI security hardening (PRs #325-331) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
$(DC)forup-archon-submoduleandup-gpuso STACK_FILES/PROJECT are consistent.pmoves/env.shared.exampleand docs to use the in-networkollamaalias.Testing:
make -C pmoves smokemake -C pmoves discord-smoke-fullmake -C pmoves voice-agent-smokeSummary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.