Skip to content

chore(pmoves): DRY make targets + Ollama URL - #317

Merged
POWERFULMOVES merged 1 commit into
mainfrom
chore/make-docs-ollama-url
Dec 15, 2025
Merged

POWERFULMOVES merged 1 commit into
mainfrom
chore/make-docs-ollama-url

Conversation

@POWERFULMOVES

@POWERFULMOVES POWERFULMOVES commented Dec 15, 2025 •

Copy link
Copy Markdown
Owner
  • Use $(DC) for up-archon-submodule and up-gpu so STACK_FILES/PROJECT are consistent.
  • Align Ollama URL in pmoves/env.shared.example and docs to use the in-network ollama alias.

Testing:

  • Local: make -C pmoves smoke
  • Local: make -C pmoves discord-smoke-full
  • Local: make -C pmoves voice-agent-smoke

Summary by CodeRabbit

  • Chores

    • Updated submodule dependencies.
    • Updated Ollama service connectivity configuration across the system.
    • Updated build and deployment configuration.
  • Documentation

    • Updated guides to reflect current Ollama service endpoint references.

✏️ Tip: You can customize this high-level summary in your review settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Dec 15, 2025 •

Copy link
Copy Markdown
Contributor

Walkthrough

Updates submodule references for PMOVES-Open-Notebook and PMOVES-Wealth. Refactors Makefile to use DC wrapper for Docker Compose operations. Updates Ollama service host references from "pmoves-ollama" to "ollama" across configuration and documentation files.

Changes

Cohort / File(s) Summary
Submodule updates
PMOVES-Open-Notebook, PMOVES-Wealth
Updated tracked commit pointers; no functional changes.
Makefile wrapper refactoring
pmoves/Makefile
Replaced direct docker compose invocations with DC wrapper for up-archon-submodule and up-gpu targets, centralizing compose file and profile handling.
Environment configuration
pmoves/env.shared.example
Updated Ollama host URL from pmoves-ollama:11434 to ollama:11434.
Documentation hostname updates
docs/PMOVES.AI-Edition-Hardened-Full.md, pmoves/docs/pmoves-model-management-starter/README.md, pmoves/docs/venice-tensorzero-integration/README.md
Changed Ollama service references from pmoves-ollama to ollama in integration examples and API base URLs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Makefile changes: Review DC wrapper integration pattern and confirm consistent compose file/profile handling across targets.
  • Hostname consolidation: Verify all references to pmoves-ollama have been updated consistently across config and docs.

Possibly related PRs

Poem

🐰 From pmoves to ollama, the rabbit hops with glee,
Submodules updated, Docker wrapper now leads the spree,
No more scattered references, all in harmony,
The makefile sings a sweeter song, wrapped and free! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is missing critical required sections: Summary section is informal bullet points instead of structured description, Testing section lacks proper documentation format, and Required Checks/Review Coordination sections are completely absent. Restructure the description to follow the template: add a proper Summary section, format Testing with code blocks and links, complete all Required Checks checkboxes, and include Review Coordination section.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the two main changes: refactoring make targets using DRY principles and updating Ollama URLs across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/make-docs-ollama-url

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/PMOVES.AI-Edition-Hardened-Full.md (1)

607-625: Consider updating the service name in the documentation example.

The Docker Compose example shows the service named pmoves-ollama, but the TensorZero configurations now reference the ollama hostname. Consider either:

  1. Updating the compose example to rename the service to ollama, OR
  2. Adding a network alias section showing how ollama is aliased to pmoves-ollama, OR
  3. Adding a note explaining the hostname difference if network aliases are configured elsewhere

Similarly, the service catalog (line 252) and port allocation table (line 306) still reference pmoves-ollama and should be updated to match the standardized hostname.

Apply this diff to update the service name in the compose example:

-  pmoves-ollama:
+  ollama:
     image: pmoves/ollama:0.12.6
     restart: unless-stopped
     environment:

Also update references in the service catalog and port table for consistency.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9eb6ec9 and f956dd5.

📒 Files selected for processing (7)
  • PMOVES-Open-Notebook (1 hunks)
  • PMOVES-Wealth (1 hunks)
  • docs/PMOVES.AI-Edition-Hardened-Full.md (2 hunks)
  • pmoves/Makefile (2 hunks)
  • pmoves/docs/pmoves-model-management-starter/README.md (1 hunks)
  • pmoves/docs/venice-tensorzero-integration/README.md (1 hunks)
  • pmoves/env.shared.example (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pmoves/env.shared.example

📄 CodeRabbit inference engine (AGENTS.md)

Copy env.shared.example → env.shared and fill in secrets; never commit real secrets in env.shared

Files:

  • pmoves/env.shared.example
🧠 Learnings (8)
📓 Common learnings
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: pmoves/AGENTS.md:0-0
Timestamp: 2025-12-07T11:03:53.415Z
Learning: Applies to pmoves/ui/**/*.{js,jsx,ts,tsx} : UI updates: run `make -C pmoves notebook-workbench-smoke ARGS="--thread=<uuid>"` to lint the Next.js bundle and validate Supabase connectivity; reference `pmoves/docs/UI_NOTEBOOK_WORKBENCH.md`
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-15T12:03:17.265Z
Learning: UI updates: run make -C pmoves notebook-workbench-smoke ARGS='--thread=<uuid>' to lint the Next.js bundle and validate Supabase connectivity; reference pmoves/docs/UI_NOTEBOOK_WORKBENCH.md
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: pmoves/AGENTS.md:0-0
Timestamp: 2025-12-07T11:03:53.415Z
Learning: Read `pmoves/docs/PMOVES.AI PLANS/ROADMAP.md` and `pmoves/docs/NEXT_STEPS.md` before making changes to align with current sprint focus
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: pmoves/AGENTS.md:0-0
Timestamp: 2025-12-07T11:03:53.415Z
Learning: Applies to pmoves/docs/LOCAL_CI_CHECKS.md : Before pushing, mirror the GitHub Actions checks documented in `docs/LOCAL_CI_CHECKS.md` (pytest suites, `make chit-contract-check`, `make jellyfin-verify`, SQL policy lint, env preflight)
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-15T12:03:17.265Z
Learning: Mandatory context before changes: read pmoves/docs/PMOVES.AI PLANS/ROADMAP.md and pmoves/docs/NEXT_STEPS.md to align with current sprint focus
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: pmoves/AGENTS.md:0-0
Timestamp: 2025-12-07T11:03:53.415Z
Learning: Applies to pmoves/services/{agent-zero,archon}/**/*.py : For Agents/Archon full-stack validation, follow the 'All Services Up, Then Tests' section in `pmoves/docs/SMOKETESTS.md` and use `make -C pmoves agents-headless-smoke`, `make -C pmoves smoke-gpu`, and `make -C pmoves verify-all`
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-15T12:03:17.265Z
Learning: Applies to services/**/README.md : Update services/*/README.md and pmoves/docs/PMOVES.AI PLANS/ runbooks when touching service operational code
📚 Learning: 2025-12-15T12:03:17.265Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-15T12:03:17.265Z
Learning: Applies to pmoves/env.shared.example : Copy env.shared.example → env.shared and fill in secrets; never commit real secrets in env.shared

Applied to files:

  • pmoves/env.shared.example
📚 Learning: 2025-12-07T11:03:53.415Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: pmoves/AGENTS.md:0-0
Timestamp: 2025-12-07T11:03:53.415Z
Learning: To keep embeddings local, launch your provider (e.g., `ollama`) and set `OLLAMA_API_BASE` before running `make notebook-seed-models`

Applied to files:

  • pmoves/env.shared.example
  • pmoves/docs/venice-tensorzero-integration/README.md
  • pmoves/docs/pmoves-model-management-starter/README.md
  • docs/PMOVES.AI-Edition-Hardened-Full.md
📚 Learning: 2025-12-15T12:03:17.265Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-15T12:03:17.265Z
Learning: Mandatory context before changes: read pmoves/docs/PMOVES.AI PLANS/ROADMAP.md and pmoves/docs/NEXT_STEPS.md to align with current sprint focus

Applied to files:

  • pmoves/docs/venice-tensorzero-integration/README.md
  • pmoves/docs/pmoves-model-management-starter/README.md
  • PMOVES-Wealth
  • docs/PMOVES.AI-Edition-Hardened-Full.md
📚 Learning: 2025-12-07T11:03:07.638Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: GEMINI.md:0-0
Timestamp: 2025-12-07T11:03:07.638Z
Learning: Applies to **/pmoves/**/*{qwen,gemma,audio,summary}*.py : Integrate Qwen2-Audio provider and add Gemma summaries to PMOVES.YT endpoints

Applied to files:

  • pmoves/docs/venice-tensorzero-integration/README.md
  • pmoves/docs/pmoves-model-management-starter/README.md
  • PMOVES-Wealth
  • docs/PMOVES.AI-Edition-Hardened-Full.md
📚 Learning: 2025-12-07T11:03:53.415Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: pmoves/AGENTS.md:0-0
Timestamp: 2025-12-07T11:03:53.415Z
Learning: Read `pmoves/docs/PMOVES.AI PLANS/ROADMAP.md` and `pmoves/docs/NEXT_STEPS.md` before making changes to align with current sprint focus

Applied to files:

  • pmoves/docs/pmoves-model-management-starter/README.md
  • PMOVES-Wealth
  • docs/PMOVES.AI-Edition-Hardened-Full.md
📚 Learning: 2025-12-15T12:03:17.265Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-15T12:03:17.265Z
Learning: Hi-RAG gateway: after touching reranker or embedding code, run make -C pmoves smoke-gpu to validate FlagEmbedding/Qwen rerankers

Applied to files:

  • pmoves/docs/pmoves-model-management-starter/README.md
📚 Learning: 2025-12-07T11:02:53.362Z
Learnt from: CR
Repo: POWERFULMOVES/PMOVES.AI PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-07T11:02:53.362Z
Learning: Call out mismatches between code changes and the runbooks (`pmoves/docs/NEXT_STEPS.md`, `pmoves/docs/ROADMAP.md`, `pmoves/docs/SESSION_IMPLEMENTATION_PLAN.md`) and suggest updates if missing

Applied to files:

  • docs/PMOVES.AI-Edition-Hardened-Full.md
🔇 Additional comments (8)
pmoves/docs/venice-tensorzero-integration/README.md (1)

20-22: OLLAMA_URL host change to ollama looks consistent with in-network aliasing

Switching OLLAMA_URL to http://ollama:11434 matches the in-network alias pattern from the PR description and keeps the hi‑rag gateway settings aligned with the rest of the stack. The docker stop example still correctly uses the container name, so no conflict here.

PMOVES-Wealth (1)

1-1: Submodule pointer bump is straightforward and safe

This is a simple submodule commit update with no in-repo logic changes. As long as 19602b95805df2f93b764d00f0c9be32ed5a2ffb in PMOVES-Wealth has been vetted, this change looks good.

docs/PMOVES.AI-Edition-Hardened-Full.md (1)

1022-1039: LGTM! TensorZero configuration updated consistently.

Both model configurations now reference the standardized ollama:11434 hostname, aligning with the environment variable changes. The /v1 path suffix is correct for OpenAI-compatible endpoints.

pmoves/env.shared.example (1)

110-110: Docker Compose hostname coordination is properly configured.

The ollama hostname in env.shared.example line 110 is correctly defined in pmoves/docker-compose.yml via network aliases on both the app_tier and api_tier networks. The pmoves-ollama service uses these aliases to resolve the ollama hostname, making the environment variable change valid and functional.

However, note that pmoves/tensorzero/config/tensorzero.toml (12 references) and pmoves/models/archon.yaml (1 reference) still hardcode pmoves-ollama:11434 instead of using the OLLAMA_URL environment variable. For consistency, these should be updated to reference the environment variable or use the ollama hostname to maintain alignment with the env.shared.example change.

PMOVES-Open-Notebook (1)

1-1: Submodule pointer update looks fine

This file only updates the tracked commit for the PMOVES-Open-Notebook submodule; no direct code/config behavior here. As long as this SHA corresponds to the intended version of the submodule (and you’ve run git submodule update --remote or equivalent when preparing the PR), this change is good to go.

pmoves/docs/pmoves-model-management-starter/README.md (1)

6-6: LGTM! Documentation alignment with Ollama URL migration.

The Ollama host reference update from pmoves-ollama to ollama aligns with the broader URL migration described in the PR objectives and maintains consistency with the updated env.shared.example.

pmoves/Makefile (2)

184-185: LGTM! Improved consistency by using the DC wrapper.

Using $(DC) ensures the Archon service is started with the consistent PROJECT name and the full STACK_FILES set, which includes docker-compose.archon.submodule.yml. Since Docker Compose only starts the explicitly named service (archon), loading additional file definitions should not cause issues.


241-243: Composition pattern is correct. The docker-compose.gpu.yml is designed to augment (not replace) the base STACK_FILES with GPU-specific services (media-video, jellyfin-bridge), both profile-gated to avoid orphan container warnings. No changes needed.

@POWERFULMOVES
POWERFULMOVES merged commit 656da54 into main Dec 15, 2025
6 checks passed
@POWERFULMOVES
POWERFULMOVES deleted the chore/make-docs-ollama-url branch December 15, 2025 21:22
POWERFULMOVES pushed a commit that referenced this pull request Dec 19, 2025
- Update status date to 2025-12-18
- Add Prosodic TTS sidecar (PR #328): boundary-aware chunking, TTFS optimization
- Add Pipecat multimodal layer Phase 1 (PR #332): STT/LLM/TTS processors
- Add Flute Gateway Voice Agent Infrastructure section with API examples
- Document UI security hardening (PRs #325-331)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
POWERFULMOVES added a commit that referenced this pull request Jan 18, 2026
chore(pmoves): DRY make targets + Ollama URL
POWERFULMOVES pushed a commit that referenced this pull request Jan 18, 2026
- Update status date to 2025-12-18
- Add Prosodic TTS sidecar (PR #328): boundary-aware chunking, TTFS optimization
- Add Pipecat multimodal layer Phase 1 (PR #332): STT/LLM/TTS processors
- Add Flute Gateway Voice Agent Infrastructure section with API examples
- Document UI security hardening (PRs #325-331)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant