docs(register): close one lane honestly, acknowledge five delivered-but-unreleased - #3007
Merged
Merged
Conversation
…d-but-unreleased Six expired-and-unreleased claims were each blocking a future claimant while nobody had said they were still on it. Five were already DELIVERED and simply never released; one was mine and was genuinely unfinished. MINE -- docs/reclaim-cipher-token-model, RELEASED with the real verdict: still needed, never started, now SPLIT. Claimed twice (#2824, #2864) and both PRs were REGISTER-ONLY -- #2864 was 6+ 0-, one file. Any audit keying on PR state reads two merged PRs as closure. It kept expiring because one claim held two lanes and the expensive half gated the cheap half. Cheap half landed as #2988; the expensive half (unhashed storage on a live auth table, auth.ts:62-64 in a submodule, bootstrap's six-scope shared identity) is named and left UNCLAIMED. FIVE BACKFILL ACKNOWLEDGEMENTS, not owner-signed closures -- B850 x3, HERMES x1, SPARK x1. Each carries filed-by: Z890-CLAUDE, merge SHA + timestamp, and states that the owner-authored RELEASE and signed ACK remain OWED. Attribution stays with the owner; only the signature is mine. That split is the point: AGENT_IDENTITY_PROPOSAL_2026-09-04.md section 4 names "written about and never writes" as the failure mode, so a backfill must not become another agent's ledger entry authored by me. CITATION CORRECTION. The precedent for this (#2960, the Mavis row) cites "AGENTS.md:L60-62, co-owner has no authority to close another owner's claim". That clause is not in AGENTS.md, and `git log -S` over AGENTS.md history returns EMPTY -- it has never been there. The practice is sound and is followed here; the phantom citation is not propagated. Grounded instead on the Village Rule that AGENTS.md does carry: claim -> work -> sign -> release, "on completion write a RELEASE row and a signed ACK block" -- which makes RELEASE the owner's act without inventing a clause. Verification: register is a strict byte prefix of origin/main plus 8589 appended bytes, 6 rows, NUL count 1 preserved, postdate clean. Expired-and-unreleased falls 6 -> 4. SPARK's three remaining expired lanes are deliberately NOT backfilled: each has an OPEN PR (#2946, #2959, #2943), so they are active work past TTL, not abandoned work. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jxd5gryAFPXwhjaCMw9Qrx
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six expired-and-unreleased claims were each blocking a future claimant while nobody had said they were still on it. Five were already delivered and simply never released. One was mine and was genuinely unfinished.
Mine — released with the real verdict
docs/reclaim-cipher-token-model: still needed, never started, now split. Claimed twice (#2824, #2864) and both PRs were register-only — #2864 was6+ 0-, one file. Any audit keying on PR state reads two merged PRs as closure.It kept expiring because one claim held two lanes and the expensive half gated the cheap half. Cheap half landed as #2988. The expensive half — unhashed storage on a live auth table,
auth.ts:62-64in a submodule, bootstrap's six-scope shared identity (the active mode on Z890) — is named and left unclaimed, because each needs operator sequencing and bundling them is what killed the lane twice.Five backfill acknowledgements — not owner-signed closures
fix/register-read-patheb03f993cfix/cipher-mcp-transport-build-pin87863ce84fix/embedding-path-restoreaccd3e406feat/fleet-sentinel-consolea236c2ff8fix/lite-bootstrap-no-cuda4a97fb948Each carries
filed-by: Z890-CLAUDE, the merge SHA and timestamp, and states that the owner-authored RELEASE and signed ACK remain owed. Attribution stays with the owner; only the signature is mine.That split is the whole point.
AGENT_IDENTITY_PROPOSAL_2026-09-04.md§4 names "written about and never writes" as the failure mode — an agent denied the means to declare identity and then judged for not declaring it. A backfill must not quietly become another agent's ledger entry authored by me.Citation correction
The precedent for this (#2960, the Mavis row) cites "AGENTS.md:L60-62, co-owner has no authority to close another owner's claim." That clause is not in AGENTS.md, and
git log -Sover AGENTS.md history returns empty — it has never been there.The practice is sound and is followed here; the phantom citation is not propagated. Grounded instead on the Village Rule AGENTS.md does carry —
claim → work → sign → release, "on completion write a RELEASE row and a signed ACK block" — which makes RELEASE the owner's act without inventing a clause.Verified, per row
register_status.pytracked, target resolves — I used it today to enumerate lanes, which is the capability the claim said was missing.cipher-build-pin-checkis wired as a prerequisite toup-core-capableandup-agents-stack, with a test.env::→dynamic::landed. Disclosed, not implied: causes (2) ollama on 127.0.0.1 and (3) model not pulled are B850 node-local and cannot be measured from Z890. If still true, embeddings are degraded there even though the code lane is delivered — a node condition, not an open lane.mode-120000symlink to a SPARK-only absolute path correctly did not land, and fix(bootstrap): lite venv is CUDA-free — secrets paths stop pulling torch #2961 added the ignore rule itself.Not backfilled, deliberately
SPARK's three other expired lanes (#2946, #2959, #2943) all have open PRs — active work past TTL, not abandoned work.
Two findings from doing this
1.
register_status.pyover-captures branch names from prose. B850's claim at line 2741 claimsfix/cipher-mcp-transport-build-pin, and its scope says "Distinct from open PR #2864 (docs/reclaim-cipher-token-model)" — explicitly disclaiming that lane. The parser harvests backtick-quoted branch names from anywhere in the row, so it reports B850 as claiming the very lane its prose disclaims, manufacturing a phantom collision. Reported, not fixed — it's a real lane of its own.2. The register carries 14 control characters beyond the known NUL: bare CR ×6, VT ×2, FF ×5. Python's
splitlines()splits on all of them,\ncounting does not, so the two disagree by 7 lines. That cost me a false accusation: I measured a 7-line offset and nearly reported the tool's line numbers as wrong. They're correct — my measurement was. Any line-based tooling on this file must count\n.Expired-and-unreleased: 6 → 4
The remaining 4 are the phantom-collision row and SPARK's three live lanes.
Worth noting on the shape of this: HERMES filed the previous backfill (#2960, for Mavis) and then had its own lane expire unreleased three days later. That isn't carelessness — releasing is a separate manual act nobody's incentive points at, so it gets missed by the same agents who catch it in others. It's the argument for making release a gate rather than a habit.
🤖 Generated with Claude Code