chore(submodules): promote PMOVES-OpenRoom — build + nginx p7 fixes (fork #5) - #2949
Conversation
…nx p7 fixes)
PMOVES-OpenRoom 81ca6f58f -> 162d573f4 (merge of fix/docker-build-node-env
into PMOVES.AI-Edition-Hardened). Three fixes the room view needs:
- Dockerfile: pnpm i --prod=false — NODE_ENV=production was stripping
devDependencies workspace-wide, so vite was absent and the frozen
install completed green while leaving no build toolchain
- nginx upstream: p7-room-orchestrator:8120 -> :8122 — the session
endpoint (POST /rooms/{id}/session) lives only on the legacy
orchestrator, route-verified against both services' openapi.json
- nginx rooms location: drop try_files under regex+alias ($uri keeps the
original request path, so every manifest 404'd despite files present;
measured: all 13 rooms 404 pre-fix)
Companion parent-side fix (nginx P7 alias) already on main — PR #2922
closed as its diff was empty. Operator: room PRs need to land so the
room is viewable.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Live validation on SPARK (pre-merge): built the
Room is viewable now on SPARK at |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
https://github.com/POWERFULMOVES/PMOVES.AI/blob/f8ab86b59a8b919fc7904ac8db2c3279cc409f64/PMOVES-OpenRoom#L1
When OpenRoom is launched through the documented make -C pmoves up-openroom path, the Make target starts only openroom and the canonical p7 service, which is reachable as p7:8120; the p7-room-orchestrator:8122 service selected by this new pin has neither the ui profile nor a network alias from p7, so it is not started. Consequently nginx cannot resolve its upstream (or returns 502s for /api/p7/*), leaving the standard OpenRoom bring-up unable to open or close room sessions. Keep the proxy on p7:8120, or update the parent startup/profile wiring in the same change.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
What
Promotes the PMOVES-OpenRoom gitlink
81ca6f58f→162d573f4(fork PR #5, merged intoPMOVES.AI-Edition-Hardened). This is the fork-side half of making the room viewable — the parent-side nginx/P7-alias fix is already on main (#2922 was closed as a 0-file duplicate).Three fixes carried:
pnpm i --prod=false—NODE_ENV=productionstripped devDeps workspace-wide; vite missing; frozen install green but no toolchain ("Local package.json exists, but node_modules missing")p7-room-orchestrator:8120→:8122— the session endpoint lives only on the legacy orchestrator (route-verified against openapi.json on both)try_filesunder regex+alias —$urikeeps the original request path so every manifest 404'd (all 13 rooms 404 pre-fix, files present)Testing
PMOVES.AI-Edition-Hardenedtip =162d573f4= this gitlink (compare: identical)pmoves-openroomimage on the node that serves the room view, then verify/api/rooms/<id>.json200sOperator-authorized: "open room prs need to land so I can view room."