chore(submodules): promote PMOVES-Agent-Zero to 5c280a9 (MCP arg filter) - #2852
Conversation
Fork PR #20: filter_declared_args trims tool calls to the declared input schema (drops model-emitted undeclared keys like 'action'/'tags'), with runtime-venv-validated tests. Clean FF from 27957f11.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a06ea29871
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit 27957f1102db8c1d1a191784c214a0b2f79847bd | |||
| Subproject commit 5c280a994794c891b9964ef19e9a64c3d45c03ee | |||
There was a problem hiding this comment.
The promoted filter_declared_args() treats the keys under properties as a complete allowlist, but MCP input schemas use JSON Schema, where undeclared top-level keys remain valid when additionalProperties is true (or omitted), and may also be admitted by patternProperties. A connected tool with fixed fields plus extensible arguments will therefore receive a silently truncated request. Only discard unknown keys for closed schemas such as additionalProperties: false, while preserving keys permitted by the other schema keywords.
Useful? React with 👍 / 👎.
1 participant
Promotes
PMOVES-Agent-Zero27957f11 -> 5c280a99(clean FF). Content = fork PR #20:filter_declared_args()drops schema-undeclared keys before MCP tool calls (the SPARK audit's 'action'/'tags' injection class — model-emitted noise, now filtered at the client boundary with a drop log), 4/4 tests validated in the real runtime venv. Fork CI green (CodeQL/audit/lint/security-scan). Companion to #2851 (gateway-endpoint fix).💘 Generated with Crush