feat(config): deployment-class registry — the axis license answers key on - #2800
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
docs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50887ec2b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
50887ec to
d6b9d1c
Compare
github-actions
Bot
removed
docs
|
P2 addressed: all ten known fleet profiles tagged ( |
github-actions
Bot
added
docs
…y on The fleet can express license class per model (creator_models.yaml: license + requires_ack) and per TTS engine (tts-engine-capabilities § License Policy) but had no way to express it per DEPLOYMENT — profiles are hardware shapes with no tenant_type, so 'which customer type is this node?' was unanswerable. This registry names the four types (private-mesh, community, school, enterprise), fixes each one's hosted_path/requires_ack posture by the same gate creator_models established, and is referenced by an optional top-level deployment_class field on profiles. Fleet nodes declare private-mesh explicitly; unset stays unset — loaders must not guess (declare-never-infer). Six coupling tests hold it: classes resolve, the four exist, posture matches the gate, fleet tagged, no guessing.
laptop-4090, workstation_5090, workstation-9850x3d-dual-r9700 (B850), z890-coordinator, jetson-jons-2/3 join the four already tagged; the fleet test now covers all ten. esp32/orin-*/nano stay UNSET on purpose — unset is honest where fleet membership is not established.
63d9c89 to
577bc53
Compare
github-actions
Bot
removed
docs
#2799's cipher provisioning merge fixed tests.test_mcp_server_chit_signing (geometry_publish_cgp_calls_sign, sign_cgp_if_available_dev_mode, sign_cgp_if_available_with_passphrase); the ratchet correctly refuses to keep baseline lines for passing tests — same breakage could return silently.
1 participant
Second-check verified the findings, then landed suggestion #1 (the piece everything else keys on):
Verified: tts-engine-capabilities.yaml § License Policy exists as quoted; creator_models.yaml (at
pmoves/config/) carriesrequires_ackwith the exact try-locally/BYO framing; profiles/*.yaml contain notenant_type/deployment_class— the gap is real.This PR:
pmoves/config/deployment_classes.yaml— the four customer types (private-mesh,community,school,enterprise) with per-classhosted_path+requires_ack_componentsposture mirroring the creator_models gate one level up. Profiles gain an optional top-leveldeployment_class:; ALL TEN known fleet profiles declareprivate-meshexplicitly; unset stays unset (declare-never-infer; esp32/orin/nano/hermes deliberately untagged). 6 coupling tests. Also drops 3 CHIT-signing ratchet baseline entries that #2799's merge fixed (the ratchet refuses stale lines).Release Note: added the deployment-class registry (private-mesh/community/school/enterprise) with per-class hosted-path and requires_ack posture; profiles gain a
deployment_classfield, ten fleet nodes tagged. Unlocks extending requires_ack beyond models (jcodemunch-class submodule gating).💘 Generated with Crush