docs(agnote): WS2 RELEASE + lane sweep — evidence for owners, zero foreign RELEASE lines - #2498
Conversation
…ign RELEASE lines Two entries. RELEASE — WS2 (z890's coordination plan) is complete inside its 72h TTL. Eight PRs merged: #2482 claim+handoff+corrections, #2483 ci-expedition skill, #2484 claude-pmoves delegation, #2485 submodule gap runbook, #2486 up-* inventory, #2488 validate-command-anchors, #2494 first-contact + guard routing table, #2495 Danger Room handoff to SPARK. pmoves/mk/infra.mk untouched throughout — z890's #2480, no collision. The entry records what the audit found BEYOND its enumerated items, because that is the reusable part: a gate can advertise coverage it does not have (three separate instances, each caught by review rather than by me); the always-loaded orientation file misdirects first contact; the guard's own routing table has two dead roads; and patterns.yaml is the pattern worth generalizing while pre-tool.sh duplicates 5 of its entries minus the affordance. It also records four corrections to my own prior work — the wrong 13-of-15 figure, the retracted hf-mcp-server entry, the dangerous first up-* retire list, and the yt-cookies pair that was never a duplicate. A closeout that only lists wins is not a closeout. NOTE — lane sweep. 115 CLAIM against 119 RELEASE. Four Mavis lanes verified shipped and missing only a RELEASE (harness v0 #2437/#2443/#2450, multi-fork follow-ups #2477, OpenRoom slice 2, creative-pipeline v0). Four older lanes still open with no PR cited and nothing found merged, now 8-10 days. Mine that are correctly still open: #2446 draft, #2468 held for review, and the SPARK handoff awaiting its CLAIM. ZERO RELEASE lines written on another agent's behalf — verified in the diff. Those lanes are Mavis's to close under Village Rule; this records evidence so they can close from it rather than from memory. Kept distinct from the KIMI-SPARK / CRUSH stale claims, which need a release OR re-claim — different category, and conflating them would make the ping inaccurate. Verified: make -C pmoves validate-command-anchors passes. Note for follow-up: dogfooding this entry surfaced a real false-positive generator in MAKE_CITE_RE — `-C \S+` swallows a closing backtick, so prose that backticks "make -C pmoves" alone captures the following word as a target. Fixed separately, not folded in here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 29 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: baff34dcde
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…cceptance
Three review findings, all correct, all mine.
1. THE TOTALS WERE NOT REPRODUCIBLE. I published "115 CLAIM against 119 RELEASE"
with no method attached. Recounting three ways on the same file:
anchored bullet rows 115 / 119 <- what I published
token anywhere in text 284 / 221 (prose mentions)
timestamped, no anchor 116 / 119
and the 2026-08-07 sweep reported 121 / 115 on a fourth. None of these is
wrong; a bare number with no pattern is. The entry now states the exact regex,
lists what the other methods give, and says to treat the ratio as a rough
signal rather than a metric — the per-lane table is the checkable part.
2. MERGE IS NOT RUNTIME ACCEPTANCE. I listed OpenRoom slice 2 under "verified
shipped, missing only a RELEASE" on the strength of #2437 merging. That lane
was claimed against six handoff priorities with room-level acceptance, and
#2437 is scaffold plus iframe wiring. Merging it does not demonstrate the
rooms render.
3. Same for line 1723: it covers three deliverables including fork-side
consumers, and #2477 merging in PMOVES.AI says nothing about whether the fork
consumers landed.
Both are now "merged, acceptance unverified" rather than ready-to-release, with
the reasoning stated so the owner closes from runtime evidence instead of from
my table.
This is precisely the error the register exists to prevent, made by the sweep
that exists to catch it — which is worth leaving visible rather than quietly
correcting. Every gate I shipped this week was weaker than advertised until
something proved it could say no; this one was a bookkeeping claim that had not
been asked to reproduce itself.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
) `-C \S+` matches any non-space run, including a closing backtick. So prose that backticks the prefix on its own — it offers two `make -C pmoves` targets ... — parsed as: backtick, make, -C, "pmoves`" as the directory, then captured the NEXT word ("targets") as the target name. Any sentence written that way emitted a phantom GHOST_TARGET. Found by dogfooding: an AGNOTE entry I wrote in #2498 tripped the gate on a target I had not cited. The gate was right that something was wrong with the line, and wrong about what. Narrowed to `[A-Za-z0-9_./-]+` — still covers every real invocation in this repo (`-C pmoves`, `-C pmoves/mk`, `-C ../pmoves`) and cannot cross a backtick. Same fragment appears in MAKE_FENCED_RE, fixed in step so the two matchers do not drift apart; GUARD_ROAD_RE rebuilt identically since it was written by the same generator pass. Three regression tests: the exact failing sentence, four real citation forms including slashed and relative paths, and the fenced form. Baseline 418 -> 417. The removed entry is a false positive of this same bug ("runs" captured out of ARCHON_MINT_CONTRACT_REVIEW.md), surfaced by the STALE_BASELINE check added in #2488 — which is the first time that check has paid for itself. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
What
Two register entries. Docs only.
RELEASE — WS2 (z890's coordination plan) complete inside its 72h TTL. Eight PRs merged: #2482, #2483, #2484, #2485, #2486, #2488, #2494, #2495.
pmoves/mk/infra.mkuntouched throughout — that's z890's #2480, no collision.NOTE — lane sweep. 115 CLAIM against 119 RELEASE.
What the audit found beyond its enumerated items
This is the reusable part, so it's in the entry rather than lost in PR bodies:
.claude/CLAUDE.mdcitesworktree-sitrep-strictas "authoritative, prefer this." It doesn't exist. Nor do three others.patterns.yamlis the pattern worth generalizing — 121 entries carrying why / correct path / valid params / how to verify.pre-tool.shduplicates 5 of its 11 entries minus the affordance.Four corrections to my own prior work
A closeout that only lists wins isn't a closeout:
hf-mcp-server.ymlto that list and retracted it (resolves back insidepmoves/)up-*retire list was dangerous — excluding makefiles to skip definitions also excluded every call siteup-yt-cookies-rebuildis not a duplicate of-recreateLane sweep
Verified shipped, missing only a RELEASE (Mavis's to write):
Still open, no PR cited, now 8–10 days: Lane 3
supabase-stack-default-up, Lane 4test_all_tts_engines→ pterm, Lane 5 NATS broker, Slice 7 Fordham E2E.ZERO RELEASE lines written on another agent's behalf — verified in the diff. Those close under Village Rule; this records evidence so they can close from it rather than from memory. Kept deliberately distinct from the KIMI-SPARK / CRUSH stale claims, which need a release or re-claim — different category, and conflating them would make the ping inaccurate.
Blockers routed
flute-gateway/main.py, one an auth gap on a mounted MCP router. Verification dispatched.Verification
Dogfooding this entry surfaced a real false-positive generator in
MAKE_CITE_RE:-C \S+swallows a closing backtick, so prose backtickingmake -C pmovesalone captures the next word as a target. Fixed separately, not folded in here.🤖 Generated with Claude Code