Skip to content

fix(compose): env.local stragglers across 3 overlay files #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
POWERFULMOVES merged 1 commit into from
Aug 5, 2026
Merged

fix(compose): env.local stragglers across 3 overlay files #2415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pmoves/docker-compose.agentgym.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ services:
- env.shared.generated
- env.shared
- .env.generated
- .env.local
# .env.local is a per-node opt-in; short-form listing made it REQUIRED
# and hard-failed bring-up on nodes without it.
- path: .env.local
required: false
Comment on lines +37 to +40

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Document the optional .env.local contract across the overlays.

The Compose interface now allows .env.local to be absent for four services. Update the operational documentation with the affected services, the three required shared files, and the override order.

  • pmoves/docker-compose.agentgym.yml#L37-L40: document the contract for agentgym-rl-coordinator.
  • pmoves/docker-compose.agentgym.yml#L170-L173: document the contract for agentgym-env-pmoves.
  • pmoves/docker-compose.gpu-image.yml#L6-L13: document the contract for hi-rag-gateway-v2-gpu.
  • pmoves/docker-compose.n8n.postgres.yml#L6-L13: document the contract for n8n-db.

As per coding guidelines, **/*: Update documentation and schemas when interfaces change.

📍 Affects 3 files
  • pmoves/docker-compose.agentgym.yml#L37-L40 (this comment)
  • pmoves/docker-compose.agentgym.yml#L170-L173
  • pmoves/docker-compose.gpu-image.yml#L6-L13
  • pmoves/docker-compose.n8n.postgres.yml#L6-L13
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pmoves/docker-compose.agentgym.yml` around lines 37 - 40, Update operational
documentation for the optional .env.local contract at
pmoves/docker-compose.agentgym.yml lines 37-40 (agentgym-rl-coordinator) and
170-173 (agentgym-env-pmoves), pmoves/docker-compose.gpu-image.yml lines 6-13
(hi-rag-gateway-v2-gpu), and pmoves/docker-compose.n8n.postgres.yml lines 6-13
(n8n-db). Document that .env.local may be absent, identify the three required
shared files, and specify their override order consistently across all four
service definitions.

Source: Coding guidelines

environment:
# Service config
- LOG_LEVEL=${LOG_LEVEL:-INFO}
Expand Down Expand Up @@ -164,7 +167,10 @@ services:
- env.shared.generated
- env.shared
- .env.generated
- .env.local
# .env.local is a per-node opt-in; short-form listing made it REQUIRED
# and hard-failed bring-up on nodes without it.
- path: .env.local
required: false
environment:
# Environment server config
- LOG_LEVEL=${LOG_LEVEL:-INFO}
Expand Down
9 changes: 8 additions & 1 deletion pmoves/docker-compose.gpu-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,14 @@ services:
image: ${HIRAG_V2_GPU_IMAGE:-ghcr.io/powerfulmoves/hi-rag-gateway-v2-gpu:cu128-py310-stable}
runtime: nvidia
restart: unless-stopped
env_file: [env.shared.generated, env.shared, .env.generated, .env.local]
env_file:
- env.shared.generated
- env.shared
- .env.generated
# .env.local is a per-node opt-in; short-form listing made it REQUIRED
# and hard-failed bring-up on nodes without it.
- path: .env.local
required: false
environment:
- QDRANT_URL=${QDRANT_URL:-http://qdrant:6333}
- QDRANT_COLLECTION=${QDRANT_COLLECTION:-pmoves_chunks_qwen3}
Expand Down
9 changes: 8 additions & 1 deletion pmoves/docker-compose.n8n.postgres.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,14 @@ services:
image: postgres:16-alpine
container_name: pmoves-n8n-db
restart: unless-stopped
env_file: [env.shared.generated, env.shared, .env.generated, .env.local]
env_file:
- env.shared.generated
- env.shared
- .env.generated
# .env.local is a per-node opt-in; short-form listing made it REQUIRED
# and hard-failed bring-up on nodes without it.
- path: .env.local
required: false
environment:
- POSTGRES_DB=${N8N_DB_NAME:?set N8N_DB_NAME}
- POSTGRES_USER=${N8N_DB_USER:?set N8N_DB_USER}
Expand Down
Loading