Skip to content

fix(make): dedupe docs-render-living — legacy dashboard recipe shadowed the Lane 2228 registry iterator - #2381

Merged
POWERFULMOVES merged 1 commit into
mainfrom
fix/dedupe-docs-render-living
Aug 4, 2026
Merged

POWERFULMOVES merged 1 commit into
mainfrom
fix/dedupe-docs-render-living

Conversation

@POWERFULMOVES

@POWERFULMOVES POWERFULMOVES commented Aug 4, 2026

Copy link
Copy Markdown
Owner

make keeps the LAST single-colon recipe, so the older dashboard renderer
(tools/render_living_docs.py) silently won over the Lane 2228 registry
iterator (tools/a2ui_renderer/render_living_doc.py) and every make run
printed override warnings. Same duplicate-target class as the #2339 fix
for juicefs-status / yt-playlist-stats / spark-health; same convention:
the intended winner keeps the name, the shadowed recipe is renamed
(docs-render-living-dashboard).

Verified: zero override warnings; docs-render-living resolves to the
registry iterator.

Co-Authored-By: Claude Fable 5 noreply@anthropic.com

Summary by CodeRabbit

  • Documentation
    • Renamed the documentation dashboard rendering command to docs-render-living-dashboard.
    • Existing dashboard rendering behavior remains unchanged.

…ed the Lane 2228 registry iterator

make keeps the LAST single-colon recipe, so the older dashboard renderer
(tools/render_living_docs.py) silently won over the Lane 2228 registry
iterator (tools/a2ui_renderer/render_living_doc.py) and every make run
printed override warnings. Same duplicate-target class as the #2339 fix
for juicefs-status / yt-playlist-stats / spark-health; same convention:
the intended winner keeps the name, the shadowed recipe is renamed
(docs-render-living-dashboard).

Verified: zero override warnings; docs-render-living resolves to the
registry iterator.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@POWERFULMOVES
POWERFULMOVES enabled auto-merge (squash) August 4, 2026 05:51
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The Makefile renames docs-render-living to docs-render-living-dashboard. The existing renderer command and readiness check remain unchanged.

Changes

Documentation dashboard

Layer / File(s) Summary
Rename dashboard rendering target
pmoves/Makefile
Renames the Make target to docs-render-living-dashboard while preserving its renderer invocation and readiness check.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: hunnibear

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change and verification but omits the required template sections and review checklist. Add the Summary, Testing, Required Checks, Review Coordination, Follow-up Tasks, and Reviewer Notes sections, with completed testing and checklist details.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the duplicate Make target fix and the renamed dashboard recipe.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dedupe-docs-render-living

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pmoves/Makefile`:
- Around line 4344-4348: Update the command example in the a2ui_renderer README
to use docs-render-living-dashboard, while preserving legitimate
registry-iterator references to docs-render-living elsewhere. Verify the renamed
Make target resolves to the dashboard renderer and include both the
documentation change and target-resolution check in PR testing evidence.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7b3b720e-7004-453e-95a2-4f8586d9c5ca

📥 Commits

Reviewing files that changed from the base of the PR and between 62b5ac0 and 0347065.

📒 Files selected for processing (1)
  • pmoves/Makefile

Comment thread pmoves/Makefile

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 03470657cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pmoves/Makefile
@POWERFULMOVES
POWERFULMOVES merged commit 52d918f into main Aug 4, 2026
29 checks passed
@POWERFULMOVES
POWERFULMOVES deleted the fix/dedupe-docs-render-living branch August 4, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant