fix(make): dedupe docs-render-living — legacy dashboard recipe shadowed the Lane 2228 registry iterator - #2381
Conversation
…ed the Lane 2228 registry iterator make keeps the LAST single-colon recipe, so the older dashboard renderer (tools/render_living_docs.py) silently won over the Lane 2228 registry iterator (tools/a2ui_renderer/render_living_doc.py) and every make run printed override warnings. Same duplicate-target class as the #2339 fix for juicefs-status / yt-playlist-stats / spark-health; same convention: the intended winner keeps the name, the shadowed recipe is renamed (docs-render-living-dashboard). Verified: zero override warnings; docs-render-living resolves to the registry iterator. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe Makefile renames ChangesDocumentation dashboard
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pmoves/Makefile`:
- Around line 4344-4348: Update the command example in the a2ui_renderer README
to use docs-render-living-dashboard, while preserving legitimate
registry-iterator references to docs-render-living elsewhere. Verify the renamed
Make target resolves to the dashboard renderer and include both the
documentation change and target-resolution check in PR testing evidence.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 7b3b720e-7004-453e-95a2-4f8586d9c5ca
📒 Files selected for processing (1)
pmoves/Makefile
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03470657cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
make keeps the LAST single-colon recipe, so the older dashboard renderer
(tools/render_living_docs.py) silently won over the Lane 2228 registry
iterator (tools/a2ui_renderer/render_living_doc.py) and every make run
printed override warnings. Same duplicate-target class as the #2339 fix
for juicefs-status / yt-playlist-stats / spark-health; same convention:
the intended winner keeps the name, the shadowed recipe is renamed
(docs-render-living-dashboard).
Verified: zero override warnings; docs-render-living resolves to the
registry iterator.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Summary by CodeRabbit
docs-render-living-dashboard.