fix(rooms): restore unlisted visibility on the z890 infra room (public-stage leak) - #2222
Conversation
…c-stage leak) The z890 node reconcile (#2184) dropped the access block from z890-infra.room.fabric.json. With access unset, is_public_room() defaults to public, so the node-control room leaked onto the public stage catalog — and test_stage_data's curation guard has been FAILING ON MAIN since that merge (every branch rebasing onto main inherits the red python-tests). Restore the pre-#2184 value: visibility unlisted. Verified: test_stage_data 5/5, validate_room_manifests 9/9. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Main has been red on
test_stage_datasince #2184: the z890 reconcile dropped theaccessblock fromz890-infra.room.fabric.json, and with access unsetis_public_room()defaults to public — the node-control room leaked onto the public stage catalog, and the curation guard test fails on main (found while updating #2173, which inherited the red).3-line surgical restore of the pre-#2184 value (
visibility: unlisted). Verified:test_stage_data5/5,validate_room_manifests9/9.Follow-up worth checking separately: how #2184 merged with this test failing — python-tests path filtering may have a selection gap.
🤖 Generated with Claude Code