Skip to content

fix(rooms): restore unlisted visibility on the z890 infra room (public-stage leak) - #2222

Merged
POWERFULMOVES merged 1 commit into
mainfrom
fix/z890-room-visibility
Jul 25, 2026
Merged

fix(rooms): restore unlisted visibility on the z890 infra room (public-stage leak)#2222
POWERFULMOVES merged 1 commit into
mainfrom
fix/z890-room-visibility

Conversation

@POWERFULMOVES

Copy link
Copy Markdown
Owner

Main has been red on test_stage_data since #2184: the z890 reconcile dropped the access block from z890-infra.room.fabric.json, and with access unset is_public_room() defaults to public — the node-control room leaked onto the public stage catalog, and the curation guard test fails on main (found while updating #2173, which inherited the red).

3-line surgical restore of the pre-#2184 value (visibility: unlisted). Verified: test_stage_data 5/5, validate_room_manifests 9/9.

Follow-up worth checking separately: how #2184 merged with this test failing — python-tests path filtering may have a selection gap.

🤖 Generated with Claude Code

…c-stage leak)

The z890 node reconcile (#2184) dropped the access block from
z890-infra.room.fabric.json. With access unset, is_public_room()
defaults to public, so the node-control room leaked onto the public
stage catalog — and test_stage_data's curation guard has been FAILING
ON MAIN since that merge (every branch rebasing onto main inherits the
red python-tests). Restore the pre-#2184 value: visibility unlisted.

Verified: test_stage_data 5/5, validate_room_manifests 9/9.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@POWERFULMOVES, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a6f95b44-eaf8-424b-a232-78d3aa41c2e8

📥 Commits

Reviewing files that changed from the base of the PR and between 8e74fbe and 9889f5e.

📒 Files selected for processing (1)
  • pmoves/config/rooms/z890-infra.room.fabric.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/z890-room-visibility

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the config pmoves/config(s)/ changes label Jul 25, 2026
@POWERFULMOVES
POWERFULMOVES merged commit a4baa99 into main Jul 25, 2026
21 checks passed
@POWERFULMOVES
POWERFULMOVES deleted the fix/z890-room-visibility branch July 25, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config pmoves/config(s)/ changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants