docs(post-merge): A2UI lane closeout - LEARNINGS addendum + SITREP refresh + AGNOTE row - #2165
Conversation
|
Warning Review limit reached
Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe PR adds Mavis-5090 A2UI post-merge closeout records, documents a Fordham fixture provenance deploy gate, refreshes the AGNOTE4482 SITREP, and adds a related PR closeout document. All changes are documentation-only. ChangesMavis-5090 A2UI follow-up
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96a8e9341d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…2165) - v0.1 line: 'Fordham Hill tenant page live' -> 'composed and ready to deploy (CF Pages deploy not yet run - operator call)' (matches the same doc's own 'not yet run' note later; deploy-tenant is manual). - v0.2 line: receipts are unsigned demo (chit-stub: placeholder), nonce- commitment is still TODO per rev-3 §5.4 - not 'CHIT-signed'. - PR pointer repointed from phantom pr_manifest_2026-07-15.json to the file that exists, PR_closeout_a2ui.body.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
142225e to
b5f0880
Compare
…2165) - v0.1 line: 'Fordham Hill tenant page live' -> 'composed and ready to deploy (CF Pages deploy not yet run - operator call)' (matches the same doc's own 'not yet run' note later; deploy-tenant is manual). - v0.2 line: receipts are unsigned demo (chit-stub: placeholder), nonce- commitment is still TODO per rev-3 §5.4 - not 'CHIT-signed'. - PR pointer repointed from phantom pr_manifest_2026-07-15.json to the file that exists, PR_closeout_a2ui.body.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pmoves/docs/AGENTS/AGNOTE4482_SITREP.md`:
- Around line 196-204: Update the “Intended MCP tools” status in
AGNOTE4482_SITREP.md to remove the stale “blocked” designation, reflecting the
resolved issue and available SSE/REST paths. Preserve the documented tool list
and resolution evidence, and ensure the heading no longer signals that agents
should avoid these operational routes.
In `@pmoves/docs/AGENTS/AGNOTE4482PHI.t1.md`:
- Around line 1325-1328: The RELEASE entry incorrectly treats the post-merge
follow-up as the substantive Mavis-5090 lane closeout. Update the AGNOTE
register so this follow-up is moved under or alongside the actual 5090-CLAUDE
lane-reconciled row, keeping the active claim state and lane closeout together
rather than split across unrelated agent rows.
In `@pmoves/docs/logs/pr_open/PR_closeout_a2ui.body.md`:
- Line 7: Reconcile the commit-count scope across
pmoves/docs/logs/pr_open/PR_closeout_a2ui.body.md:7-7 and
pmoves/docs/AGENTS/AGNOTE4482_SITREP.md:67-67 by defining whether
post-merge/documentation commits are included, then update or clarify both
records so they consistently report the same scope and count.
- Line 25: Update the “Added/updated documentation” checklist entry in
PR_closeout_a2ui.body.md to accurately reference all four reviewed files, either
by changing the count to four or by listing the files explicitly.
- Around line 19-25: Update the PR Testing section in PR_closeout_a2ui.body.md
to replace the “N/A” statement with the applicable commands from
docs/LOCAL_CI_CHECKS.md and their results for the pmoves documentation changes.
If any checks are intentionally skipped, document the reason in Reviewer Notes,
while preserving the existing checklist entries.
In `@pmoves/docs/logs/pr_trim_2132_LEARNINGS.md`:
- Around line 76-93: Update the Fordham resident legitimacy entry in the
documented artifact to remove the full quote text and identifying attributions;
replace them with a redacted summary or fixture identifier, and reference
restricted provenance evidence instead. Preserve the operational warning that
deployment remains blocked until consent and provenance are confirmed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d141cccd-5a93-4215-a00d-0edeaf5169bb
📒 Files selected for processing (4)
pmoves/docs/AGENTS/AGNOTE4482PHI.t1.mdpmoves/docs/AGENTS/AGNOTE4482_SITREP.mdpmoves/docs/logs/pr_open/PR_closeout_a2ui.body.mdpmoves/docs/logs/pr_trim_2132_LEARNINGS.md
|
|
||
| - **docs(post-merge): LEARNINGS addendum** to `pr_trim_2132_LEARNINGS.md` — captures the Fordham-resident-legitimacy finding from B850-CLAUDE's 2026-07-16 cross-lane CHIT review. The trim cycle captured code findings; this addendum captures the content/fixture finding (2 attributed quotes in `fordham-hill.json` with no recorded consent or provenance). Deploy-gate, not merge-gate. | ||
| - **docs(post-merge): SITREP refresh** — `pmoves/docs/AGENTS/AGNOTE4482_SITREP.md` updated to reflect the post-merge state (3-PR stack merged 2026-07-18, post-merge commits #2154 #2164, the `pmoves/docs/pilots/fordham-hill/` directory, the `CATACLYSM_CROSSLINKS.md` bridge doc). A fresh local model on Spark / Knuckles can read this and pick up where Mavis-5090 left off. | ||
| - **docs(post-merge): AGNOTE lane closeout row** — explicit Mavis-5090 RELEASE row noting the lane is closed, with reference to 5090-CLAUDE's substantive "A2UI Stack Landed" row. Lists what the lane produced (15 commits, 3 PRs) and what is deferred to the post-merge follow-up cron (Fordham-resident-legitimacy, v0.3 pm-ballot rebuild, HMAC → Ed25519, CF Pages deploy, B-mode watcher). |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Reconcile the lane commit-count scope across the closeout records.
The PR body says 15 commits while the SITREP says 16. Define whether the count includes post-merge/documentation commits, then make both records consistent.
pmoves/docs/logs/pr_open/PR_closeout_a2ui.body.md#L7-L7: update the 15-commit claim or clarify its scope.pmoves/docs/AGENTS/AGNOTE4482_SITREP.md#L67-L67: update the 16-commit claim or clarify its scope.
🧰 Tools
🪛 LanguageTool
[style] ~7-~7: ‘with reference to’ might be wordy. Consider a shorter alternative.
Context: ... RELEASE row noting the lane is closed, with reference to 5090-CLAUDE's substantive "A2UI Stack L...
(EN_WORDINESS_PREMIUM_WITH_REFERENCE_TO)
📍 Affects 2 files
pmoves/docs/logs/pr_open/PR_closeout_a2ui.body.md#L7-L7(this comment)pmoves/docs/AGENTS/AGNOTE4482_SITREP.md#L67-L67
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pmoves/docs/logs/pr_open/PR_closeout_a2ui.body.md` at line 7, Reconcile the
commit-count scope across pmoves/docs/logs/pr_open/PR_closeout_a2ui.body.md:7-7
and pmoves/docs/AGENTS/AGNOTE4482_SITREP.md:67-67 by defining whether
post-merge/documentation commits are included, then update or clarify both
records so they consistently report the same scope and count.
| ## Testing | ||
|
|
||
| N/A — docs only, no code or conformance gate changes. | ||
|
|
||
| - [x] CHIT Contract Check — no contract changes; new doc additions only | ||
| - [ ] Updated contracts, schemas, or topics — N/A | ||
| - [x] Added/updated documentation — see the 3 changed files |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Record applicable documentation checks instead of marking testing N/A.
The repository guidelines require applicable docs/LOCAL_CI_CHECKS.md commands and results in the PR Testing section; intentional skips must be documented in Reviewer Notes. This section currently provides neither.
As per coding guidelines, pmoves/**/* changes must record applicable check commands and output in the PR Testing section.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pmoves/docs/logs/pr_open/PR_closeout_a2ui.body.md` around lines 19 - 25,
Update the PR Testing section in PR_closeout_a2ui.body.md to replace the “N/A”
statement with the applicable commands from docs/LOCAL_CI_CHECKS.md and their
results for the pmoves documentation changes. If any checks are intentionally
skipped, document the reason in Reviewer Notes, while preserving the existing
checklist entries.
Source: Coding guidelines
|
|
||
| - [x] CHIT Contract Check — no contract changes; new doc additions only | ||
| - [ ] Updated contracts, schemas, or topics — N/A | ||
| - [x] Added/updated documentation — see the 3 changed files |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Correct the changed-file count.
The PR contains four reviewed files, but this line says “the 3 changed files.” Update the count or list the files explicitly.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pmoves/docs/logs/pr_open/PR_closeout_a2ui.body.md` at line 25, Update the
“Added/updated documentation” checklist entry in PR_closeout_a2ui.body.md to
accurately reference all four reviewed files, either by changing the count to
four or by listing the files explicitly.
| 10. **Fordham resident legitimacy: 2 attributed quotes in the Fordham Hill | ||
| tenant fixture, no recorded consent or provenance.** The fixture at | ||
| `website/tenant-template/data/fordham-hill.json` contains two quotes: | ||
|
|
||
| | Quote | Attribution | | ||
| |---|---| | ||
| | "When the mesh node goes down, the block fixes it. When the cell tower goes down, we wait." | "Pilot resident, Fordham Hill" / *cooperative member* | | ||
| | "We started with five families and a question. Eight weeks later, 23 households a…" | "Pilot co-organizer" | | ||
|
|
||
| The attributions name a real, identifiable Bronx housing cooperative. | ||
| The fixture contains no `disclaimer` / `illustrative` / `sample` / | ||
| `fictional` / `not affiliated` language — only the word "pilot". It | ||
| is not possible from the tree to determine whether these are real | ||
| residents with consent, or fabricated personas attributed to a real | ||
| community. **For a page slated for public CF Pages deploy, this is a | ||
| deploy gate, not a merge gate — the merge landed, the deploy waits.** | ||
| *Discovered by B850-CLAUDE on 2026-07-16 in the cross-lane CHIT | ||
| review; folded here post-merge by Mavis-5090 on 2026-07-19.* |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Do not duplicate potentially unconsented resident quotes in this artifact.
The addendum correctly flags missing provenance, but it also stores the full quote text and identifying attribution. Until consent is confirmed, use a redacted summary or fixture identifier and link restricted evidence instead.
As per path instructions, pmoves/docs/** content should remain operationally accurate without expanding unresolved privacy exposure.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pmoves/docs/logs/pr_trim_2132_LEARNINGS.md` around lines 76 - 93, Update the
Fordham resident legitimacy entry in the documented artifact to remove the full
quote text and identifying attributions; replace them with a redacted summary or
fixture identifier, and reference restricted provenance evidence instead.
Preserve the operational warning that deployment remains blocked until consent
and provenance are confirmed.
Source: Path instructions
…fresh + AGNOTE row DARKXSIDE approved #1 + #2 + #3 in one push. Adjusted the plan on discovery: the AGNOTE row (#3) was already shipped by 5090-CLAUDE ('A2UI stack landed - merge train + restack record' at commit 5294223), so this PR ships a Mavis-5090 lane closeout row that explicitly references the existing closeout instead of duplicating it. 1. pmoves/docs/logs/pr_trim_2132_LEARNINGS.md - post-merge addendum - Bucket-1 entry #10: Fordham-resident-legitimacy finding from B850-CLAUDE's 2026-07-16 cross-lane CHIT review (2 attributed quotes in fordam-hill.json with no recorded consent or provenance). Captured as 4th-bucket addendum so the trim-cycle LEARNINGS surface the finding, not just the code findings. - Pattern reflection: 'a trim cycle that only reads diffs will miss fixture-provenance questions every time'. Future trim cycles on tenant PRs should run a fixture-content audit. - Resolution pointer: the substantive work is in pmoves/docs/pilots/fordham-hill/ (B850-CLAUDE's cross-lane reconciliation). The answer is an operator decision (DARKXSIDE) that lives in the deploy gate, not the merge gate. - graphiti marker added: Mavis-5090 / phase:post-merge-addendum / ts:2026-07-19T05:55:00Z 2. pmoves/docs/AGENTS/AGNOTE4482_SITREP.md - refresh for post-merge state - Timestamp: 2026-07-17 -> 2026-07-19 - 'Latest Lane' section rewritten to reflect: A2UI v0.1+v0.2 MERGED into main 2026-07-18; what was added post-merge (#2154 ballot + A2UI reconciliation, #2164 Fordham contracts reconciliation, the pilots/fordham-hill/ directory, the CATACLYSM_CROSSLINKS.md bridge doc); what is OPEN (Fordham- resident-legitimacy deploy-gate, CodeQL on pm-ballot, v0.3 spec additions, HMAC -> Ed25519 migration, CF Pages deploy, B-mode watcher); three-body for the lane including 5090-CLAUDE (trim) and B850-CLAUDE (cross-lane review). - Cron reference updated to its repurposed state (every 45 min, watching the post-merge follow-up lane). 3. pmoves/docs/AGENTS/AGNOTE4482PHI.t1.md - Mavis-5090 lane closeout row - 2026-07-19T05:55:00Z RELEASE row noting this PR is the small post-merge follow-up, with 5090-CLAUDE's A2UI Stack Landed row as the substantive closeout. Lists what the lane produced in total (15 commits, 3 PRs) and what is NOT closed (deferred to the post-merge follow-up cron). - graphiti marker: Mavis-5090::WEBSITE-AS-AGENT-CANVAS-LANE-CLOSEOUT Standing: this is the Mavis-5090 closeout. The next-lane CLAIM can land cleanly. The cron watches the post-merge follow-up lane (Fordham-resident-legitimacy + v0.3 pm-ballot rebuild + B-mode when n8n is up). Spark/Knuckles local model reading this fresh gets: the lane is in main, the artifacts are indexed, the open gates are listed. Refs: - pmoves/docs/logs/pr_trim_2132_LEARNINGS.md (the addendum) - pmoves/docs/AGENTS/AGNOTE4482_SITREP.md (the refresh) - pmoves/docs/AGENTS/AGNOTE4482PHI.t1.md (the closeout row) - pmoves/docs/pilots/fordham-hill/07-ballot-prior-art-and-reconciliation.md (B850-CLAUDE's cross-lane work) - 5294223 (5090-CLAUDE's A2UI Stack Landed row, the substantive closeout) - .claude/agents/pr-review-watcher.md (the cron-repurposed agent) - pmoves/tools/pr_review_watcher.py (the A-mode listener, B-mode ready)
…2165) - v0.1 line: 'Fordham Hill tenant page live' -> 'composed and ready to deploy (CF Pages deploy not yet run - operator call)' (matches the same doc's own 'not yet run' note later; deploy-tenant is manual). - v0.2 line: receipts are unsigned demo (chit-stub: placeholder), nonce- commitment is still TODO per rev-3 §5.4 - not 'CHIT-signed'. - PR pointer repointed from phantom pr_manifest_2026-07-15.json to the file that exists, PR_closeout_a2ui.body.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- SITREP: fix stale "blocked" MCP heading (issue resolved 2026-07-13) - PR body: correct file count (3 -> 4), document testing checks per LOCAL_CI_CHECKS guidelines, mark Fordham-resident-legitimacy resolved (PR #2269), update CF Pages deploy follow-up 💘 Generated with Crush
b5f0880 to
5364cda
Compare
Summary
Post-merge closeout for the WEBSITE_AS_AGENT_CANVAS lane. The 3 A2UI PRs (#2132/#2133/#2134) merged 2026-07-18; this PR is the small follow-up that closes the trim-cycle loop.
pr_trim_2132_LEARNINGS.md— captures the Fordham-resident-legitimacy finding from B850-CLAUDE's 2026-07-16 cross-lane CHIT review. The trim cycle captured code findings; this addendum captures the content/fixture finding (2 attributed quotes infordham-hill.jsonwith no recorded consent or provenance). Deploy-gate, not merge-gate.pmoves/docs/AGENTS/AGNOTE4482_SITREP.mdupdated to reflect the post-merge state (3-PR stack merged 2026-07-18, post-merge commits docs(fordham): ballot prior art + A2UI reconciliation — HMAC cannot sign a contested ballot #2154 fix(governance): reconcile Fordham contracts and evidence #2164, thepmoves/docs/pilots/fordham-hill/directory, theCATACLYSM_CROSSLINKS.mdbridge doc). A fresh local model on Spark / Knuckles can read this and pick up where Mavis-5090 left off.Why this is docs-only
The substantive work is already on main:
5294223430)07-ballot-prior-art-and-reconciliation.md)e65e9bb298)This PR is the small follow-up that closes the loop in the artifacts I (Mavis-5090) shipped. The findings it adds to the LEARNINGS were already documented in the cross-lane work; this commit makes them visible to the trim-cycle reader.
Testing
N/A — docs only, no code or conformance gate changes.
Review Coordination
/chit:review-sweepafter PR opensFollow-up Tasks
createTextNode/textContentrebuild so the CodeQLxss-through-domquery passes structurally (post-merge follow-up lane, watched by the Mavis-5090 cron)chit-stub:prefix) — needsCHIT_PASSPHRASEloadedpr_review_watcher.py --mode natsReviewer Notes
The LEARNINGS addendum explicitly states that fixture-provenance questions are a class of finding the trim cycle cannot catch because they live in the governance/content lane, not the code lane. Future trim cycles on tenant PRs should add a fixture-content audit step.
The Mavis-5090 closeout row in the AGNOTE explicitly references the 5090-CLAUDE "A2UI Stack Landed" row as the substantive closeout — this is a Mavis-5090 follow-up, not a duplicate. The two rows are complementary: 5090-CLAUDE's captures the merge + restack + CodeQL triage; Mavis-5090's captures the post-merge follow-up + the deferred work.
The SITREP refresh is meant to be the "second home" entry point for a fresh local model on Spark / Knuckles next session. It indexes every artifact, names every open gate, and lists every agent involved (Mavis-5090 + 5090-CLAUDE + B850-CLAUDE + DARKXSIDE).
See also
pmoves/docs/operations/REVIEW_STYLE_2026-07-15.md— the trim style this PR extendspmoves/docs/templates/PR_LEARNINGS.template.md— the template the LEARNINGS files follow.claude/agents/pr-review-watcher.md— the agent that watches the post-merge follow-up lanepmoves/docs/pilots/fordham-hill/07-ballot-prior-art-and-reconciliation.md— B850-CLAUDE's cross-lane workpmoves/docs/AGENTS/AGNOTE4482PHI.t1.md— the 5090-CLAUDE A2UI Stack Landed row (line 1317+)Summary by CodeRabbit