Skip to content

fix(skills): align skill names with Crush validator requirements - #2103

Merged
POWERFULMOVES merged 2 commits into
mainfrom
fix/skills-crush-validator-compliance
Jul 12, 2026
Merged

fix(skills): align skill names with Crush validator requirements#2103
POWERFULMOVES merged 2 commits into
mainfrom
fix/skills-crush-validator-compliance

Conversation

@POWERFULMOVES

@POWERFULMOVES POWERFULMOVES commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fixes 10 skills whose name: field used colon separators (4090:probe, shift:listen, model:pull, etc.) — Crush's skill validator requires alphanumeric-with-hyphens matching the directory name
  • Adds missing YAML frontmatter to pmoves-cipher-memory/SKILL.md (had none, causing parse failure)
  • Result: 35/35 skills load cleanly (was 24/35 with 11 red on every Crush startup)

Changed Files (11)

Skill Old name New name
node-4090-probe 4090:probe node-4090-probe
node-4090-sitrep 4090:sitrep node-4090-sitrep
node-4090-verify 4090:verify node-4090-verify
field-brief 4090:field-brief field-brief
model-pull model:pull model-pull
agentgym-run agentgym:run agentgym-run
shift-listen shift:listen shift-listen
shift-from-bpm shift:from-bpm shift-from-bpm
persona-bind persona:bind persona-bind
demo-room demo:room demo-room
pmoves-cipher-memory (no frontmatter) pmoves-cipher-memory (+ frontmatter)

Testing

Crush restarted after fix — crush_info confirms 35/35 skills loaded, 0 validation warnings in log.

💘 Generated with Crush

Summary by CodeRabbit

  • New Features
    • Added metadata for the new pmoves-cipher-memory skill.
  • Improvements
    • Standardized skill names using consistent hyphenated identifiers.
    • Updated skill labels to better match their documented topics and invocation names.
    • Improved consistency across available skills without changing their instructions or behavior.

10 skills used colon-separated names (e.g. "4090:probe", "shift:listen")
which Crush's skill validator rejects — names must be alphanumeric with
hyphens, matching their directory. The cipher-memory skill had no YAML
frontmatter at all. All 11 skills now pass validation (35/35 loaded,
0 red) after Crush restart.

💘 Generated with Crush

Assisted-by: Crush:glm-5.2
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@POWERFULMOVES, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6296bdec-f5c0-432d-9fb4-d28e03ca78da

📥 Commits

Reviewing files that changed from the base of the PR and between 4c08dde and 16250a7.

📒 Files selected for processing (11)
  • .claude/skills/agentgym-run/SKILL.md
  • .claude/skills/demo-room/SKILL.md
  • .claude/skills/field-brief/SKILL.md
  • .claude/skills/model-pull/SKILL.md
  • .claude/skills/node-4090-probe/SKILL.md
  • .claude/skills/node-4090-sitrep/SKILL.md
  • .claude/skills/node-4090-verify/SKILL.md
  • .claude/skills/persona-bind/SKILL.md
  • .claude/skills/shift-from-bpm/SKILL.md
  • .claude/skills/shift-listen/SKILL.md
  • pmoves/configs/tac_trees/p7-agents-skills-lifecycle.tac.yaml
📝 Walkthrough

Walkthrough

Standardizes skill front-matter identifiers across ten existing skill definitions and adds initial metadata for pmoves-cipher-memory.

Changes

Skill metadata normalization

Layer / File(s) Summary
Standardize skill front matter
.claude/skills/*/SKILL.md
Existing skill names use hyphenated identifiers, and pmoves-cipher-memory now declares its name and description metadata.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: normalizing skill names to satisfy the Crush validator.
Description check ✅ Passed The description includes the required Summary and Testing sections with substantive details about the fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/skills-crush-validator-compliance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4c08dde732

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .claude/skills/model-pull/SKILL.md

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.claude/skills/agentgym-run/SKILL.md:
- Line 2: Update the embedded heading in the agentgym-run skill documentation to
use the new agentgym-run identifier instead of agentgym:run, while leaving the
front matter name unchanged.

In @.claude/skills/field-brief/SKILL.md:
- Line 2: Update the embedded heading in the field-brief skill documentation to
display the current field-brief identifier instead of the obsolete
4090:field-brief value, while preserving the surrounding front matter and
document structure.

In @.claude/skills/model-pull/SKILL.md:
- Line 2: Update the embedded heading in the model-pull skill documentation to
use the `model-pull` identifier instead of `model:pull`, keeping it consistent
with the front matter name.

In @.claude/skills/shift-from-bpm/SKILL.md:
- Line 2: Update the heading in the shift-from-bpm skill document to use the new
shift-from-bpm identifier instead of the stale shift:from-bpm text, keeping the
front matter name unchanged.

In @.claude/skills/shift-listen/SKILL.md:
- Line 2: Update the embedded heading in the shift-listen skill documentation to
use the normalized “shift-listen” name instead of “shift:listen”, while keeping
the front matter and surrounding documentation unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9a767334-4803-4849-a2f5-41626b31ca9a

📥 Commits

Reviewing files that changed from the base of the PR and between 12f45b5 and 4c08dde.

📒 Files selected for processing (11)
  • .claude/skills/agentgym-run/SKILL.md
  • .claude/skills/demo-room/SKILL.md
  • .claude/skills/field-brief/SKILL.md
  • .claude/skills/model-pull/SKILL.md
  • .claude/skills/node-4090-probe/SKILL.md
  • .claude/skills/node-4090-sitrep/SKILL.md
  • .claude/skills/node-4090-verify/SKILL.md
  • .claude/skills/persona-bind/SKILL.md
  • .claude/skills/pmoves-cipher-memory/SKILL.md
  • .claude/skills/shift-from-bpm/SKILL.md
  • .claude/skills/shift-listen/SKILL.md

Comment thread .claude/skills/agentgym-run/SKILL.md
Comment thread .claude/skills/field-brief/SKILL.md
Comment thread .claude/skills/model-pull/SKILL.md
Comment thread .claude/skills/shift-from-bpm/SKILL.md
Comment thread .claude/skills/shift-listen/SKILL.md
CodeRabbit (5 Minor) and Codex (1 P2) found colon-separated skill
names still referenced in headings, usage examples, cross-references,
and the p7-agents-skills-lifecycle TAC tree. All 20+ stale references
updated to match the hyphenated names from the frontmatter fix.

💘 Generated with Crush

Assisted-by: Crush:glm-5.2
@POWERFULMOVES
POWERFULMOVES merged commit 6e3079d into main Jul 12, 2026
22 checks passed
@POWERFULMOVES
POWERFULMOVES deleted the fix/skills-crush-validator-compliance branch July 12, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant