fix(skills): align skill names with Crush validator requirements - #2103
Conversation
10 skills used colon-separated names (e.g. "4090:probe", "shift:listen") which Crush's skill validator rejects — names must be alphanumeric with hyphens, matching their directory. The cipher-memory skill had no YAML frontmatter at all. All 11 skills now pass validation (35/35 loaded, 0 red) after Crush restart. 💘 Generated with Crush Assisted-by: Crush:glm-5.2
|
Warning Review limit reached
Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthroughStandardizes skill front-matter identifiers across ten existing skill definitions and adds initial metadata for ChangesSkill metadata normalization
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c08dde732
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/skills/agentgym-run/SKILL.md:
- Line 2: Update the embedded heading in the agentgym-run skill documentation to
use the new agentgym-run identifier instead of agentgym:run, while leaving the
front matter name unchanged.
In @.claude/skills/field-brief/SKILL.md:
- Line 2: Update the embedded heading in the field-brief skill documentation to
display the current field-brief identifier instead of the obsolete
4090:field-brief value, while preserving the surrounding front matter and
document structure.
In @.claude/skills/model-pull/SKILL.md:
- Line 2: Update the embedded heading in the model-pull skill documentation to
use the `model-pull` identifier instead of `model:pull`, keeping it consistent
with the front matter name.
In @.claude/skills/shift-from-bpm/SKILL.md:
- Line 2: Update the heading in the shift-from-bpm skill document to use the new
shift-from-bpm identifier instead of the stale shift:from-bpm text, keeping the
front matter name unchanged.
In @.claude/skills/shift-listen/SKILL.md:
- Line 2: Update the embedded heading in the shift-listen skill documentation to
use the normalized “shift-listen” name instead of “shift:listen”, while keeping
the front matter and surrounding documentation unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9a767334-4803-4849-a2f5-41626b31ca9a
📒 Files selected for processing (11)
.claude/skills/agentgym-run/SKILL.md.claude/skills/demo-room/SKILL.md.claude/skills/field-brief/SKILL.md.claude/skills/model-pull/SKILL.md.claude/skills/node-4090-probe/SKILL.md.claude/skills/node-4090-sitrep/SKILL.md.claude/skills/node-4090-verify/SKILL.md.claude/skills/persona-bind/SKILL.md.claude/skills/pmoves-cipher-memory/SKILL.md.claude/skills/shift-from-bpm/SKILL.md.claude/skills/shift-listen/SKILL.md
CodeRabbit (5 Minor) and Codex (1 P2) found colon-separated skill names still referenced in headings, usage examples, cross-references, and the p7-agents-skills-lifecycle TAC tree. All 20+ stale references updated to match the hyphenated names from the frontmatter fix. 💘 Generated with Crush Assisted-by: Crush:glm-5.2
Summary
name:field used colon separators (4090:probe,shift:listen,model:pull, etc.) — Crush's skill validator requires alphanumeric-with-hyphens matching the directory namepmoves-cipher-memory/SKILL.md(had none, causing parse failure)Changed Files (11)
node-4090-probe4090:probenode-4090-probenode-4090-sitrep4090:sitrepnode-4090-sitrepnode-4090-verify4090:verifynode-4090-verifyfield-brief4090:field-brieffield-briefmodel-pullmodel:pullmodel-pullagentgym-runagentgym:runagentgym-runshift-listenshift:listenshift-listenshift-from-bpmshift:from-bpmshift-from-bpmpersona-bindpersona:bindpersona-binddemo-roomdemo:roomdemo-roompmoves-cipher-memorypmoves-cipher-memory(+ frontmatter)Testing
Crush restarted after fix —
crush_infoconfirms 35/35 skills loaded, 0 validation warnings in log.💘 Generated with Crush
Summary by CodeRabbit
pmoves-cipher-memoryskill.