docs(handoff): Z890 DB-lane live-apply → Knuckles (Z890 reinstall) - #1943
Conversation
|
Warning Review limit reached
Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e6b63b7e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| This iterates `supabase/migrations/*.sql` then `supabase/initdb/*.sql`, idempotent via the | ||
| `public.pmoves_bootstrap_history (kind, filename)` ledger (already-applied rows are skipped — | ||
| safe re-run). It applies, in one pass: | ||
| - the voice schema (v5_16/v5_17 + anon-grant) → **creates + seeds `pmoves_core.voice_profiles`**, |
There was a problem hiding this comment.
Following Action 3 will not populate profiles: I checked the mirrored v5_16 migration (pmoves/supabase/migrations/20260628000000_voice_catalog.sql) and repo-wide SQL/Python references, and there is no INSERT/seed for pmoves_core.voice_profiles, only DDL/grants. In this handoff scenario the bootstrap can create the table but SELECT count(*) remains 0, so persona/profile routing stays blocked unless this document adds the actual seed/register step before the RELEASE instruction.
Useful? React with 👍 / 👎.
| ## Action 3 — run the live apply + verify | ||
|
|
||
| ``` | ||
| make -C pmoves supabase-bootstrap # or supabase-bootstrap-no-start |
There was a problem hiding this comment.
For the alternate supabase-bootstrap-no-start path, I checked pmoves/Makefile:688-715: it runs _psql < "$migration" without -v ON_ERROR_STOP=1 and then records the migration when psql exits successfully; PostgreSQL documents that script errors only produce the dedicated failure status when ON_ERROR_STOP is set. If Knuckles uses this path on the live DB and a nonfatal SQL statement fails, the bootstrap ledger can mark a partially applied migration as applied, so this handoff should either require the fail-fast target or first fix the no-start wrapper.
Useful? React with 👍 / 👎.
1 participant
What
Reassigns the parked Supabase DB-lane live-apply work from Z890 (being reinstalled — Windows) to Knuckles (B850).
Z890 had mirrored the voice migrations into
supabase/migrations/(#1909) but deferred the livesupabase-bootstrap(CHIT/data-tier gate), and two source writes from the #1920 handoff never landed. Verified onmaintoday:supabase/migrations/20250204…channel_monitorstill has 3×jwt_claim_role()(P1 fresh-bootstrap breaker)voice_profilesempty → flute-gateway S1 (feat(voice): S1 — flute-gateway voice_profiles registry (loader + routing + /profiles + /validate) #1922) degrades toDEFAULT_PROVIDERThis live apply is the single gate on 4090's first persona voice.
Handoff actions (in the doc)
20250204…→TO service_role USING(true)make db-apply-migration+ allowlist in sql-policy-lintmake -C pmoves supabase-bootstrap→ creates + seedspmoves_core.voice_profilesSupersedes the Z890-addressed handoffs #1907 / #1920.
🤖 Generated with Claude Code