feat(agents): code-review + verifier subagents (review-infra lane) - #1785
Conversation
|
Warning Review limit reached
More reviews will be available in 13 minutes and 16 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ivilege (#1787) Path filter missed config/yaml/json + .claude/agents|skills, so infra/agent-definition PRs got no automated review (PR #1785 — an agents-only PR — demonstrated the blind spot). Add **.yaml/**.yml/**.json, pmoves/config(s)/**, and .claude/agents|skills/** so behaviour-defining changes are reviewed like code. Scope permissions to least-privilege: the code-review plugin only reads the diff and posts PR comments, so contents:write -> read and drop attestations:write. (claude.yml is unchanged — @claude can apply fix-ups so it keeps contents:write.) If the plugin turns out to need write, revert this hunk. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Fills the review gap surfaced by a review-infra audit: control-agent does governance/merge-sequencing and test-runner runs pytest, but neither does deep line-by-line code-correctness review nor evidence-based claim verification. code-review: correctness/bug/security/type-safety reviewer reusing the pmoves-pair-review 4-class taxonomy; read-only; emits P1/P2/P3 findings + per-class clean signal. verifier: evidence-before-assertions claim checker that maps each PR claim to a concrete command and reports exact output+exit code (or UNVERIFIED-env); surfaces falsified claims loudly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
c64f803 to
08df4ef
Compare
Part of the 4090 review-infra lane (AGNOTE claim in the first commit). Companion to #1763 (which restored
claude-code-review.yml— it had startup_failed for ~7 days on theoven-sh/setup-bunallowlist block).What
Two new
.claude/agents/:code-review— deep code-correctness reviewer (bugs / security / error-handling / type-safety). Read-only; reuses thepmoves-pair-review4-class taxonomy (reasoning gap / semantic-naming drift / contract-correctness / defense-in-depth); emits[P1|P2|P3] <class> — file:linefindings + an explicit per-class clean signal (evidence-of-absence). Model: opus.verifier— evidence-before-assertions claim checker. Maps each PR/commit claim to one concrete command, runs it, reports exact output + exit code (orUNVERIFIED (environment)), and surfaces falsified claims loudly. Model: sonnet.Why (gap analysis)
A review-infra audit found
control-agentdoes governance/merge-sequencing andtest-runnerruns pytest, but no agent does line-by-line correctness review or evidence-based claim verification. These two fill that gap without overlapping the CHIT (chit-compliance-reviewer), governance (control-agent), or thread-resolution (pr-trimmer) agents — each new agent's description states what it is NOT for.Verification
Frontmatter matches the repo convention (name/description/tools/disallowedTools/model/maxTurns/effort),
disallowedToolsblocks Write/Edit so both stay read-only. This PR opening should trigger the now-fixedclaude-code-review.yml— a successful run here doubles as confirmation that #1763 fixed the outage.🤖 Generated with Claude Code