chore(submodules): bump Pmoves-hyperdimensions gitlink to hardened tip - #1681
Conversation
…p (camera-fit + viewer-hardening) Records the fork commit production runs after merging fork #15 (embed camera fit) and #16 (#1667 concern-B surfaceFn guard) into PMOVES.AI-Edition-Hardened. c3c2b39 -> bf3d922. website/hyperdim/ is generated/gitignored and re-syncs from this pin at deploy; this keeps main's recorded pointer in step with the live deploy for reproducibility. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the ChangesSubmodule Reference Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3515294385
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit c3c2b39d3eb875ce7bc2b218a6b042ff35135a28 | |||
| Subproject commit bf3d922103fb7994e713d25d1f97418c02ed3b58 | |||
There was a problem hiding this comment.
Defer camera fit until geometry rebuild
This gitlink pins a submodule change where loadPresetFromFile calls fitCameraToObject() immediately after applyConfig(), but applyConfig() only queues the preset surface rebuild via scheduleGeometryUpdate(). In embed/gallery loads (?ui=none), the fit therefore computes the bounding sphere from the previous/default geometry instead of the freshly loaded preset, so the initial tile can still be framed/clipped incorrectly until a resize happens; run the fit after the queued updateGeometry() has produced the new mesh.
Useful? React with 👍 / 👎.
Bumps the
Pmoves-hyperdimensionssubmodule gitlinkc3c2b39 → bf3d922somainrecords the fork commit production runs.bf3d922(onPMOVES.AI-Edition-Hardened) includes:surfaceFnguard + surface compile-error surfacingThe site's
website/hyperdim/is generated/gitignored and re-syncs from this pin at deploy time, so this is a reproducibility/record bump — production already runsbf3d922(deployed alongside #1678's CSP fix and verified live onpmoves-ai.pages.dev).One-line change; no code.
🤖 Generated with Claude Code
Summary by CodeRabbit