fix(ci): correct Docker Compose image name in gateway-agent tag step - #1649
Conversation
Wire Ollama configuration env vars into the pmoves-yt service so SPARK (and other nodes) can route summary/chapter generation to the correct Ollama endpoint with the right model. Changes: - OLLAMA_URL: points to Ollama API (default: containerized service) - YT_SUMMARY_PROVIDER: summary backend (default: ollama) - YT_SUMMARY_OLLAMA_MODEL: concrete model id (default: gemma2:9b-instruct) SPARK nodes should set OLLAMA_URL=http://host.docker.internal:11434 and YT_SUMMARY_OLLAMA_MODEL to an available local model (e.g. qwen3.5:35b-a3b-q4_K_M). Closes AGNOTE4482 Lane C wiring.
- Lane A: A2A bug fix documented, PR #1645 opened - Lane C: PMOVES.YT summarize/chapters verified on SPARK
Docker Compose v2 names images as projectname-servicename (dash), not projectname/servicename (slash). The tag step was referencing pmoves/gateway-agent but the built image is pmoves-gateway-agent.
|
Warning Review limit reached
More reviews will be available in 12 minutes and 18 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Docker Hardening ValidationHardening Validation ReportValidated: Thu May 28 18:44:57 UTC 2026Services CheckedPMOVES.AI Docker Hardening Validation[INFO] Checking: pmoves/docker-compose.hardened.yml [INFO] Validating: hi-rag-gateway-v2 [INFO] Validating: extract-worker [INFO] Validating: langextract [INFO] Validating: presign [INFO] Validating: render-webhook [INFO] Validating: retrieval-eval [INFO] Validating: pdf-ingest [INFO] Validating: jellyfin-bridge [INFO] Validating: invidious-companion-proxy [INFO] Validating: ffmpeg-whisper [INFO] Validating: media-video [INFO] Validating: media-audio [INFO] Validating: hi-rag-gateway-v2-gpu [INFO] Validating: hi-rag-gateway-gpu [INFO] Validating: deepresearch [INFO] Validating: supaserch [INFO] Validating: publisher-discord [INFO] Validating: mesh-agent [INFO] Validating: nats-echo-req [INFO] Validating: nats-echo-res [INFO] Validating: publisher [INFO] Validating: analysis-echo [INFO] Validating: graph-linker [INFO] Validating: comfy-watcher [INFO] Validating: grayjay-plugin-host [INFO] Validating: agent-zero [INFO] Validating: archon [INFO] Validating: channel-monitor [INFO] Validating: pmoves-yt [INFO] Validating: notebook-sync [INFO] Validating: supabase_service_role_key [INFO] Validating: supabase_jwt_secret ====================================== |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b5ec1926e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - YT_CHANNEL_CHECK_INTERVAL=${YT_CHANNEL_CHECK_INTERVAL:-3600} | ||
| - OLLAMA_URL=${OLLAMA_URL:-http://pmoves-ollama:11434} | ||
| - YT_SUMMARY_PROVIDER=${YT_SUMMARY_PROVIDER:-ollama} | ||
| - YT_SUMMARY_OLLAMA_MODEL=${YT_SUMMARY_OLLAMA_MODEL:-gemma2:9b-instruct} |
There was a problem hiding this comment.
Use a valid default Ollama model tag
When pmoves-yt runs with the new defaults, summary/chapter requests will ask Ollama for gemma2:9b-instruct, but that tag is not one of the published Gemma 2 tags (Ollama lists gemma2:9b and exact quantized instruct tags such as gemma2:9b-instruct-q4_0: https://ollama.com/library/gemma2/tags). On fresh/default deployments this makes the newly enabled Ollama summarizer fail with a model-not-found error unless operators know to override YT_SUMMARY_OLLAMA_MODEL; default this to a valid tag such as gemma2:9b or an exact quantized instruct tag.
Useful? React with 👍 / 👎.
Follow-up to #1648. The tag step was using
pmoves/gateway-agentbut Docker Compose v2 names images aspmoves-gateway-agent(dash, not slash).