feat(yt): expose OLLAMA_URL and YT_SUMMARY_OLLAMA_MODEL to pmoves-yt - #1646
Conversation
|
Warning Review limit reached
More reviews will be available in 31 minutes and 52 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Docker Hardening ValidationHardening Validation ReportValidated: Thu May 28 16:53:17 UTC 2026Services CheckedPMOVES.AI Docker Hardening Validation[INFO] Checking: pmoves/docker-compose.hardened.yml [INFO] Validating: hi-rag-gateway-v2 [INFO] Validating: extract-worker [INFO] Validating: langextract [INFO] Validating: presign [INFO] Validating: render-webhook [INFO] Validating: retrieval-eval [INFO] Validating: pdf-ingest [INFO] Validating: jellyfin-bridge [INFO] Validating: invidious-companion-proxy [INFO] Validating: ffmpeg-whisper [INFO] Validating: media-video [INFO] Validating: media-audio [INFO] Validating: hi-rag-gateway-v2-gpu [INFO] Validating: hi-rag-gateway-gpu [INFO] Validating: deepresearch [INFO] Validating: supaserch [INFO] Validating: publisher-discord [INFO] Validating: mesh-agent [INFO] Validating: nats-echo-req [INFO] Validating: nats-echo-res [INFO] Validating: publisher [INFO] Validating: analysis-echo [INFO] Validating: graph-linker [INFO] Validating: comfy-watcher [INFO] Validating: grayjay-plugin-host [INFO] Validating: agent-zero [INFO] Validating: archon [INFO] Validating: channel-monitor [INFO] Validating: pmoves-yt [INFO] Validating: notebook-sync [INFO] Validating: supabase_service_role_key [INFO] Validating: supabase_jwt_secret ====================================== |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d1f3d6ca2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - OLLAMA_URL=${OLLAMA_URL:-http://pmoves-ollama:11434} | ||
| - YT_SUMMARY_PROVIDER=${YT_SUMMARY_PROVIDER:-ollama} | ||
| - YT_SUMMARY_OLLAMA_MODEL=${YT_SUMMARY_OLLAMA_MODEL:-gemma2:9b-instruct} |
There was a problem hiding this comment.
This only updates the monolithic compose file, but the documented overlay path uses make overlay-up-apps / make overlay-up-full, which load docker-compose.apps.yml via the Makefile overlay targets. That overlay's pmoves-yt environment still stops at YT_CHANNEL_CHECK_INTERVAL, so overlay deployments still start /yt/summarize and /yt/chapters without OLLAMA_URL or YT_SUMMARY_OLLAMA_MODEL and hit the same routing/connection failure this change is meant to fix. Please add the same entries to pmoves/docker-compose.apps.yml or regenerate the split overlays with this change.
Useful? React with 👍 / 👎.
| - YT_WHISPER_MODEL=${YT_WHISPER_MODEL:-small} | ||
| - YT_TRANSCRIPT_DIARIZE=${YT_TRANSCRIPT_DIARIZE:-false} | ||
| - YT_CHANNEL_CHECK_INTERVAL=${YT_CHANNEL_CHECK_INTERVAL:-3600} | ||
| - OLLAMA_URL=${OLLAMA_URL:-http://pmoves-ollama:11434} |
There was a problem hiding this comment.
With the new default OLLAMA_URL=http://pmoves-ollama:11434, a user who follows the existing make up-yt path still gets a broken summary endpoint: that target explicitly starts only bgutil-pot-provider ffmpeg-whisper pmoves-yt, and pmoves-yt only depends on MinIO and NATS, so Compose will not start pmoves-ollama. In that default configuration, /yt/summarize and /yt/chapters resolve a service name that is not running unless the operator separately starts Ollama or overrides the URL; add pmoves-ollama to the relevant startup path/dependency or avoid defaulting to an in-stack service that is not brought up.
Useful? React with 👍 / 👎.
9d1f3d6 to
dea6061
Compare
Wire Ollama configuration env vars into the pmoves-yt service so SPARK (and other nodes) can route summary/chapter generation to the correct Ollama endpoint with the right model. Changes: - OLLAMA_URL: points to Ollama API (default: containerized service) - YT_SUMMARY_PROVIDER: summary backend (default: ollama) - YT_SUMMARY_OLLAMA_MODEL: concrete model id (default: gemma2:9b-instruct) SPARK nodes should set OLLAMA_URL=http://host.docker.internal:11434 and YT_SUMMARY_OLLAMA_MODEL to an available local model (e.g. qwen3.5:35b-a3b-q4_K_M). Closes AGNOTE4482 Lane C wiring.
- Lane A: A2A bug fix documented, PR #1645 opened - Lane C: PMOVES.YT summarize/chapters verified on SPARK
dea6061 to
3a2fd68
Compare
Docker Hardening ValidationHardening Validation ReportValidated: Thu May 28 18:26:39 UTC 2026Services CheckedPMOVES.AI Docker Hardening Validation[INFO] Checking: pmoves/docker-compose.hardened.yml [INFO] Validating: hi-rag-gateway-v2 [INFO] Validating: extract-worker [INFO] Validating: langextract [INFO] Validating: presign [INFO] Validating: render-webhook [INFO] Validating: retrieval-eval [INFO] Validating: pdf-ingest [INFO] Validating: jellyfin-bridge [INFO] Validating: invidious-companion-proxy [INFO] Validating: ffmpeg-whisper [INFO] Validating: media-video [INFO] Validating: media-audio [INFO] Validating: hi-rag-gateway-v2-gpu [INFO] Validating: hi-rag-gateway-gpu [INFO] Validating: deepresearch [INFO] Validating: supaserch [INFO] Validating: publisher-discord [INFO] Validating: mesh-agent [INFO] Validating: nats-echo-req [INFO] Validating: nats-echo-res [INFO] Validating: publisher [INFO] Validating: analysis-echo [INFO] Validating: graph-linker [INFO] Validating: comfy-watcher [INFO] Validating: grayjay-plugin-host [INFO] Validating: agent-zero [INFO] Validating: archon [INFO] Validating: channel-monitor [INFO] Validating: pmoves-yt [INFO] Validating: notebook-sync [INFO] Validating: supabase_service_role_key [INFO] Validating: supabase_jwt_secret ====================================== |
1 participant
Problem
The
/yt/summarizeand/yt/chaptersendpoints exist in PMOVES.YT but the pmoves-yt container could not reach Ollama becauseOLLAMA_URLwas not passed through docker-compose.yml. On SPARK (host Ollama), this caused connection refused errors.Changes
Wire three env vars into the
pmoves-ytservice:OLLAMA_URL— Ollama API endpoint (default: containerized service)YT_SUMMARY_PROVIDER— backend selector (ollamaorhf)YT_SUMMARY_OLLAMA_MODEL— concrete model id for Ollama pathSPARK Configuration
SPARK nodes should set:
OLLAMA_URL=http://host.docker.internal:11434YT_SUMMARY_OLLAMA_MODEL=qwen3.5:35b-a3b-q4_K_M(or another available local model)Verification
test_summary_routing.pyCloses AGNOTE4482 Lane C wiring.
Risk
Low — additive env vars only, no behavior change unless operator sets values.