Skip to content

fix(a2a): remove non-existent InvalidSignatureError catch #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
POWERFULMOVES merged 2 commits into from
May 28, 2026
Merged

fix(a2a): remove non-existent InvalidSignatureError catch #1645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff36c18
docs(agnote4482): claim SPARK-KIMI multi-lane (A2A, NATS, YT, models)
May 28, 2026
dac8d12
fix(a2a): remove non-existent InvalidSignatureError catch block
May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pmoves/docs/AGENTS/AGNOTE4482PHI.t1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,3 +965,14 @@ The pipeline reports success because its validation scope is too narrow. Neither
- `2026-05-27T21:35:00Z` RELEASE `SPARK-KIMI` scope: All three fix branches pushed and PRs opened. Validation: channel-monitor healthy on :8097 (YouTube API active), deepresearch healthy on :8098, monitoring stack healthy (Prometheus, Grafana :3002, Loki :3100). n8n (:5678) and Open Notebook (:8503/:5055) also brought up during same session. agent_signature: `ACK::SPARK-KIMI::SPARK-INFRA-BRINGUP-RELEASE-2026-05-27`.

<!-- GRAPHITI_MARK: SPARK-KIMI::SPARK-INFRA-BRINGUP::2026-05-27 -->

## SPARK-KIMI Multi-Lane Claim (2026-05-27)

- `2026-05-27T21:40:00Z` CLAIM `SPARK-KIMI` scope: Three parallel lanes on SPARK node (ARM64 + NVIDIA GB10, 128GB unified):
1. **Lane A — A2A Runtime Verification** (`infra/a2a-runtime-verification`): Verify A2A router mounts at `/a2a/v1/*`, test `/.well-known/agent-card.json` discovery, auth via `mcp_server_token`, document secure activation path. Closes Known Gap P0.
2. **Lane B — NATS Auth Secondary Batch** (`fix/nats-auth-secondary-batch`): Migrate 21-file secondary batch (vllm-orchestrator, supaserch/app.py, gateway-agent/nats_integration.py, benchmark-runner, agent-zero/python/events/bus.py) from unauthenticated `nats://(nats|localhost):4222` to env-driven `NATS_URL`. Closes Known Gap P0.
3. **Lane C — PMOVES.YT Summarize + Chapters** (`feat/yt-summarize-chapters`): Add `/yt/summarize` and `/yt/chapters` endpoints to `pmoves-yt` service using host Ollama (Gemma/qwen3.5, expanded model selection on SPARK). Bounded NEXT_STEPS deliverable.
4. **Lane D — SPARK Model Orchestration**: Audit host Ollama model roster against SPARK GB10 capacity (128GB unified), pull qwen3 family updates surfaced via channel-monitor ingestion, update `tensorzero.toml` model entries for local-first routing.
- Three-body: delivery=SPARK-KIMI, control=operator approval, memory=this trail. agent_signature: `ACK::SPARK-KIMI::MULTI-LANE-CLAIM-2026-05-27`.
Comment on lines +971 to +976

@coderabbitai coderabbitai Bot May 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix lane count mismatch in the claim summary.

Line 971 says “Three parallel lanes,” but Lines 972-975 define four lanes (A-D). Please align the summary text with the actual list to avoid coordination ambiguity.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pmoves/docs/AGENTS/AGNOTE4482PHI.t1.md` around lines 971 - 976, The claim
header says "Three parallel lanes" but the list defines four lanes (Lane A — A2A
Runtime Verification, Lane B — NATS Auth Secondary Batch, Lane C — PMOVES.YT
Summarize + Chapters, Lane D — SPARK Model Orchestration); update the header in
the timestamped claim line (the line starting with `2026-05-27T21:40:00Z` CLAIM
`SPARK-KIMI` scope:) to reflect the correct count by changing "Three parallel
lanes" to "Four parallel lanes" (or else remove/merge a lane so the count
matches), leaving the rest of the lanes and agent_signature intact.

Comment on lines +975 to +976

@coderabbitai coderabbitai Bot May 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add explicit branch/PR scope for Lane D to keep claim traceable.

Lane D currently has no branch/PR scope while the other lanes do. Please add it (or explicitly mark as docs-only/no-branch) so claim ownership is unambiguous.
As per coding guidelines, “claim the relevant lane with branch/PR scope (CLAIM)”.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pmoves/docs/AGENTS/AGNOTE4482PHI.t1.md` around lines 975 - 976, The Lane D
entry "Lane D — SPARK Model Orchestration" lacks a branch/PR scope; update that
line to include an explicit CLAIM scope (e.g., add "CLAIM=branch-name/PR-<id>"
or "CLAIM=docs-only/no-branch") so ownership is unambiguous; ensure the
agent_signature remains `ACK::SPARK-KIMI::MULTI-LANE-CLAIM-2026-05-27` and, if
relevant, note the branch/PR in the delivery metadata (delivery=SPARK-KIMI) and
any model routing changes referenced (tensorzero.toml) for traceability.


<!-- GRAPHITI_MARK: SPARK-KIMI::MULTI-LANE-CLAIM::2026-05-27 -->
5 changes: 0 additions & 5 deletions pmoves/services/agent-zero/python/features/a2a/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,6 @@ def _require_a2a_auth(authorization: Optional[str], public_mode: bool = False) -
detail="Token expired",
headers={"WWW-Authenticate": "Bearer"},
) from None
except jose_jwt.InvalidSignatureError:
raise HTTPException(
status_code=status.HTTP_403_FORBIDDEN,
detail="Invalid token signature",
) from None
except jose_jwt.JWTError:
raise HTTPException(
status_code=status.HTTP_403_FORBIDDEN,
Expand Down
Loading