Skip to content

fix(publishing): surface approval handoff state #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
POWERFULMOVES merged 1 commit into from
Mar 27, 2026
Merged

fix(publishing): surface approval handoff state #1120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pmoves/n8n/flows/approval_poller.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
},
{
"parameters": {
"functionCode": "const row = item.json || {};\nconst meta = (row.meta && typeof row.meta === 'object') ? row.meta : {};\nconst requestedAt = new Date().toISOString();\nconst publishRequestId = `${row.id}:${requestedAt}`;\nconst payload = {\n studio_board_id: row.id,\n publish_request_id: publishRequestId,\n artifact_uri: row.content_url,\n title: row.title || meta.title || 'Untitled Artifact',\n namespace: row.namespace || undefined,\n description: meta.description || undefined,\n tags: Array.isArray(meta.tags) ? meta.tags : undefined,\n meta: {\n ...meta,\n studio_board_id: row.id,\n publish_request_id: publishRequestId,\n publish_requested_at: requestedAt,\n publish_request_source: 'n8n-approval-poller'\n }\n};\n\nif (!payload.namespace) {\n delete payload.namespace;\n}\nif (!payload.description) {\n delete payload.description;\n}\nif (!payload.tags || payload.tags.length === 0) {\n delete payload.tags;\n}\n\nconst patch = {\n status: 'publishing',\n meta: {\n ...meta,\n studio_board_id: row.id,\n publish_request_id: publishRequestId,\n publish_requested_at: requestedAt,\n publish_request_source: 'n8n-approval-poller'\n }\n};\n\nreturn {\n json: {\n envelope: {\n topic: 'content.publish.approved.v1',\n payload\n },\n rowId: row.id,\n patch\n }\n};"
"functionCode": "const row = item.json || {};\nconst meta = (row.meta && typeof row.meta === 'object') ? row.meta : {};\nconst requestedAt = new Date().toISOString();\nconst publishRequestId = `${row.id}:${requestedAt}`;\nconst publishMeta = {\n ...meta,\n studio_board_id: row.id,\n publish_request_id: publishRequestId,\n publish_requested_at: requestedAt,\n publish_approval_event_sent_at: requestedAt,\n publish_request_source: 'n8n-approval-poller'\n};\nconst payload = {\n studio_board_id: row.id,\n publish_request_id: publishRequestId,\n artifact_uri: row.content_url,\n title: row.title || publishMeta.title || 'Untitled Artifact',\n namespace: row.namespace || undefined,\n description: publishMeta.description || undefined,\n tags: Array.isArray(publishMeta.tags) ? publishMeta.tags : undefined,\n meta: publishMeta\n};\n\nif (!payload.namespace) {\n delete payload.namespace;\n}\nif (!payload.description) {\n delete payload.description;\n}\nif (!payload.tags || payload.tags.length === 0) {\n delete payload.tags;\n}\n\nconst patch = {\n status: 'publishing',\n meta: {\n ...publishMeta,\n publish_failed_at: null,\n publish_failure_reason: null,\n publish_failure_stage: null,\n publish_failure_meta: null\n }\n};\n\nreturn {\n json: {\n envelope: {\n topic: 'content.publish.approved.v1',\n payload\n },\n rowId: row.id,\n patch\n }\n};"
},
"id": "prepare_event",
"name": "Prepare Publish Envelope",
Expand Down
34 changes: 33 additions & 1 deletion pmoves/ui/app/dashboard/studio-board/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,14 @@ interface StudioBoardRowMeta {
rejection_reason?: string | null;
reviewed_at?: string | null;
reviewed_by?: string | null;
publish_started_at?: string | null;
publish_completed_at?: string | null;
publish_event_sent_at?: string | null;
publish_requested_at?: string | null;
publish_approval_event_sent_at?: string | null;
publish_failed_at?: string | null;
publish_failure_reason?: string | null;
publish_failure_stage?: string | null;
tags?: string[];
persona?: string;
workflow?: string;
Expand Down Expand Up @@ -172,6 +176,12 @@ export default function StudioBoardDashboardPage() {
reviewed_by: reviewer || null,
rejection_reason: rejectionReason,
publish_state: action === "approve" ? null : meta.publish_state,
publish_requested_at: action === "approve" ? null : meta.publish_requested_at,
publish_approval_event_sent_at:
action === "approve" ? null : meta.publish_approval_event_sent_at,
publish_started_at: action === "approve" ? null : meta.publish_started_at,
publish_completed_at: action === "approve" ? null : meta.publish_completed_at,
publish_event_sent_at: action === "approve" ? null : meta.publish_event_sent_at,

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep publish_event_sent_at for already-published approvals

approve now always nulls meta.publish_event_sent_at; if an operator clicks Approve on a row that is already published, this update changes it to approved and removes the completion marker that the poller uses for dedupe (status=eq.approved + meta->>publish_event_sent_at=is.null in pmoves/n8n/flows/approval_poller.json). That makes previously published artifacts eligible for a second publish cycle (duplicate Discord/Jellyfin outputs) instead of staying terminal. This field should only be cleared for intentional requeues (e.g., publish_failed) or the Approve action should be blocked for published rows.

Useful? React with 👍 / 👎.

publish_failed_at: action === "approve" ? null : meta.publish_failed_at,
publish_failure_reason: action === "approve" ? null : meta.publish_failure_reason,
publish_failure_stage: action === "approve" ? null : meta.publish_failure_stage,
Expand Down Expand Up @@ -390,6 +400,18 @@ export default function StudioBoardDashboardPage() {
<td className="px-3 py-2 text-brand-ink">{row.namespace || "—"}</td>
<td className="px-3 py-2">
<div className="font-medium capitalize text-brand-ink">{row.status || "unknown"}</div>
{row.status === "publishing" && meta.publish_started_at ? (
<div className="text-xs text-brand-subtle">
publisher started @ {formatDate(meta.publish_started_at)}
</div>
) : null}
{row.status === "publishing" &&
!meta.publish_started_at &&
meta.publish_approval_event_sent_at ? (
<div className="text-xs text-brand-subtle">
approval relayed @ {formatDate(meta.publish_approval_event_sent_at)}
</div>
) : null}
{meta.publish_event_sent_at ? (
<div className="text-xs text-brand-subtle">
published @ {formatDate(meta.publish_event_sent_at)}
Expand All @@ -400,9 +422,19 @@ export default function StudioBoardDashboardPage() {
publish requested @ {formatDate(meta.publish_requested_at)}
</div>
) : null}
{row.status === "publish_failed" && meta.publish_failed_at ? (
<div className="text-xs text-brand-crimson">
failed @ {formatDate(meta.publish_failed_at)}
</div>
) : null}
{meta.publish_failure_reason ? (
<div className="text-xs text-brand-crimson">
publish failed: {meta.publish_failure_reason}
publish failure: {meta.publish_failure_reason}
</div>
) : null}
{meta.publish_failure_stage ? (
<div className="text-xs text-brand-crimson">
failure stage: {meta.publish_failure_stage}
</div>
) : null}
{meta.rejection_reason ? (
Expand Down
Loading