fix(bootstrap): add Qdrant collection to registry with Qwen3 default - #1110
Conversation
QDRANT_COLLECTION defaults to pmoves_chunks_qwen3 (3072d Qwen3-4b) instead of legacy pmoves_chunks (384d MiniLM). Ensures brand-defaults sets the correct collection for the standardized embedding stack. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new Qdrant Vector Database service is added to the bootstrap registry with two environment variables: QDRANT_URL (defaulting to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce615a55cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "key": "QDRANT_COLLECTION", | ||
| "file": "pmoves/env.shared", | ||
| "prompt": "Qdrant collection name for embeddings", | ||
| "default": "pmoves_chunks_qwen3", |
There was a problem hiding this comment.
Align Qdrant default with active embedding pipeline
Setting QDRANT_COLLECTION to pmoves_chunks_qwen3 as a global bootstrap default forces all compose services that use ${QDRANT_COLLECTION:-...} to share that collection, overriding their per-service defaults (for example pmoves/docker-compose.yml for extract-worker and hi-rag-gateway-v2). Those services can still generate non-Qwen vectors by default/fallback (pmoves/libs/providers/embedding.py defaults to gemma embedding models, and pmoves/services/hi-rag-gateway-v2/app.py falls back to all-MiniLM-L6-v2), which leads to dimension mismatch at query/ingest time and can trigger failures or collection recreation in ensure_qdrant_collection (app.py around lines 466-483). This makes a fresh bootstrap susceptible to broken retrieval unless additional model env vars are updated in lockstep.
Useful? React with 👍 / 👎.
Summary
qdrantservice to bootstrap registry withQDRANT_COLLECTIONandQDRANT_URLpmoves_chunks_qwen3(3072d Qwen3-4b embeddings)make brand-defaultssets the correct collection for the standardized embedding stackpmoves_chunks(384d) causing dimension mismatch with TensorZero Qwen3 embeddingsTest plan
make brand-defaultssetsQDRANT_COLLECTION=pmoves_chunks_qwen3in env.sharedGenerated with Claude Code
Summary by CodeRabbit