feat(beats): audio analysis pipeline + DARKXSIDE catalog - #1030
Merged
Merged
Conversation
Add beats analysis tools for the W4 immersive demo content pipeline: - analyze_beats.py: audio fingerprinting (ffmpeg lavfi, ebur128, spectral) - beats_to_cgp.py: beats → CGP geometry conversion - chit_a2ui_bridge.py: CGP → A2UI animation specs bridge - ingest_gdrive_beats.py: Google Drive beats ingestion Include DARKXSIDE SoundCloud catalog (pmoves/data/beats/) with fingerprints, playlists, and tempo-grouped M3U8 files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedToo many files! This PR contains 166 files, which is 16 over the limit of 150. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (12)
📒 Files selected for processing (166)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d195aaacb4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+573
to
+574
| gname = name_group(members) | ||
| m3u = write_playlist(gname, members, output) |
There was a problem hiding this comment.
Because gname is derived only from coarse tempo/timbre/energy buckets, distinct KMeans clusters can collapse to the same label. When that happens write_playlist() rewrites the earlier .m3u8, and downstream selection by name becomes ambiguous; this commit already contains five Allegro_balanced_Bright entries in pmoves/data/beats/playlists/groups_summary.json but only one Allegro_balanced_Bright.m3u8. That drops tracks from the exported catalog and makes later beats_to_cgp.py --group/dump --group calls unable to target the overwritten clusters.
Useful? React with 👍 / 👎.
Comment on lines
+188
to
+192
| "constellations": [{ | ||
| "id": _stable_id(f"c_{group_name}"), | ||
| "label": group_name, | ||
| "anchor": anchor, | ||
| "spectrum": [group_sv["Hz"], group_sv["delta"], 1.0 - abs(group_sv["kappa"])], |
There was a problem hiding this comment.
group_to_cgp() emits the constellation in a top-level constellations array, but the repo’s CGP consumers traverse super_nodes[*].constellations (pmoves/services/gateway/gateway/api/workflow.py:204 and pmoves/services/gateway/gateway/api/viz.py:127). In the packets produced here, super_nodes[0] has no constellations at all, so the gateway cannot collect constellation IDs or render the SVG view for these beats packets even though the top-level array is populated.
Useful? React with 👍 / 👎.
Comment on lines
+93
to
+94
| anchors = cgp_data.get("anchors", []) | ||
| for idx, anchor in enumerate(anchors): |
There was a problem hiding this comment.
This bridge only looks for top-level anchors and spectral_signatures, but the canonical geometry schema and the new beats exporter use super_nodes[*].constellations[*].anchor and points instead (pmoves/contracts/schemas/geometry/cgp.v1.schema.json, pmoves/tools/beats_to_cgp.py). For any CGP produced in this repo, both loops are empty, so elements stays empty and the Remotion render is just a blank scene.
Useful? React with 👍 / 👎.
Owner
Author
🌿 PR Trim — Thread Classification
Summary: All 3 threads reference tooling under active development (Phase 11 beats pipeline). The SKILL.md documents the intended architecture; the Python tools will implement these patterns when built. No follow-up commit needed — issues are tracked as part of the Phase 11 implementation scope. |
POWERFULMOVES
added a commit
that referenced
this pull request
Mar 20, 2026
Addresses actionable review threads from 6 admin-merged PRs: - SKILL.md (cipher-beats): fix ffmeg→ffmpeg typo, add code block language tags, normalize analysed→analyzed spelling (#1031) - SKILL.md (holographic-blocks): add code block language tags, use canonical geometry.cgp.v1 subject name (#1031) - portal.js: preserve gateway URL scheme (http/https→ws/wss), replace fabricated Math.random() stats with "—" placeholder (#1033) - patterns.yaml: restrict CHIT bypass patterns from bare substrings to scoped make-target/file-path regexes (#1035) - container-agent/app.py: include upstream service probes in healthy summary assessment (#1035) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
POWERFULMOVES
added a commit
that referenced
this pull request
Mar 20, 2026
- analyze_beats.py: append cluster ID to group names preventing .m3u8 playlist file collisions when clusters share tempo/timbre/energy bucket - beats_to_cgp.py: nest constellations inside super_nodes per CGP v1.0 spec — gateway consumers traverse super_nodes[*].constellations[*] - chit_a2ui_bridge.py: traverse canonical nested CGP paths instead of reading non-existent top-level anchors/spectral_signatures fields; also maps individual track points to A2UI sub-elements Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
PR #1030 — Code Bug Fixes LandedCommit Fix 1: Playlist name collisions —
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
analyze_beats.py(ffmpeg lavfi fingerprinting),beats_to_cgp.py(beats → CGP geometry),chit_a2ui_bridge.py(CGP → A2UI animation),ingest_gdrive_beats.py(Google Drive ingestion)pmoves/data/beats/) with 80+ tracks, fingerprints, and tempo-grouped playlistsFeeds
W4 (immersive demo content pipeline) — audio → geometry → animation chain for cataclysmstudios.com
Test plan
analyze_beats.pyruns with ffmpeg availablebeats_to_cgp.pyproduces valid CGP packets from fingerprint data🤖 Generated with Claude Code