Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ jobs:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
# PMOVES: the catwalk replace directive in go.mod points at this submodule;
# every job that runs the go toolchain must init it first.
- run: git submodule update --init pmoves-catwalk
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version-file: go.mod
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,5 @@ jobs:
golangci_path: .golangci.yml
golangci_version: v2.13.1
timeout: 10m
# PMOVES: catwalk replace needs the submodule present before golangci
pre-run: git submodule update --init pmoves-catwalk
3 changes: 3 additions & 0 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ jobs:
else
echo "should_run=true" >> $GITHUB_OUTPUT
fi
# NOTE (PMOVES): meta's nightly workflow does not init submodules; with the
# catwalk replace active a nightly build would fail (currently moot — this
# job startup-fails on the missing goreleaser_key secret before any build).
nightly:
needs: check
if: needs.check.outputs.should_run == 'true'
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ concurrency:
group: goreleaser
cancel-in-progress: true

# NOTE (PMOVES): this delegates to charmbracelet/meta's goreleaser workflow,
# which does NOT init submodules — with the catwalk replace active in go.mod a
# release build would fail. Never run to date on this fork (no tags, no
# goreleaser_key secret). If a release is ever cut here, inline the job with
# `git submodule update --init pmoves-catwalk` after checkout.
jobs:
goreleaser:
uses: charmbracelet/meta/.github/workflows/goreleaser.yml@main
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/schema-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ jobs:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
# PMOVES: the catwalk replace in go.mod points at this submodule;
# every job that runs the go toolchain must init it first.
- run: git submodule update --init pmoves-catwalk
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version-file: go.mod
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/security.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ jobs:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
# PMOVES: the catwalk replace in go.mod points at this submodule;
# every job that runs the go toolchain must init it first.
- run: git submodule update --init pmoves-catwalk
Comment on lines +68 to +70

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Initialize the submodule for the CodeQL Go build

Add the initialization to the codeql job as well: in the language: go matrix, its checkout leaves submodules disabled and the subsequent github/codeql-action/autobuild step compiles the project, so ./pmoves-catwalk is absent and the new replacement makes that matrix entry fail. This added step only protects govulncheck; it does not affect the separate CodeQL checkout at lines 30-37.

Useful? React with 👍 / 👎.

- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: stable
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/snapshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ jobs:
with:
fetch-depth: 0
persist-credentials: false
# PMOVES: the catwalk replace in go.mod points at this submodule;
# every job that runs the go toolchain must init it first.
- run: git submodule update --init pmoves-catwalk
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version-file: go.mod
Expand Down
6 changes: 6 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -218,3 +218,9 @@ require (
modernc.org/mathutil v1.7.1 // indirect
modernc.org/memory v1.11.0 // indirect
)

// PMOVES: route catwalk at the pmoves-catwalk fork submodule, which carries
// the TensorZero provider for PMOVES gateway routing. Every workflow that
// runs the go toolchain must init this submodule first (see build.yml):
// with the replace active, go mod tidy fails on a bare checkout.
replace charm.land/catwalk => ./pmoves-catwalk

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep versioned Go installs compatible with the module

Avoid publishing this local replace: when the project is installed through the documented go install github.com/charmbracelet/crush@latest route rather than a recursive Git checkout, the submodule directory is unavailable, and versioned go install rejects modules containing replacement directives that change how the module is interpreted (go help install states this constraint explicitly). Consequently, releases containing this change cannot be installed through the advertised Go installation method; publish the fork as an addressable module dependency or otherwise avoid a filesystem-only replacement in the released go.mod.

Useful? React with 👍 / 👎.

2 changes: 0 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ charm.land/bubbles/v2 v2.2.1 h1:Fq1+qm5hV6GkvzLQDhCBpXXE5tLgvh1PRriCLwSvIQU=
charm.land/bubbles/v2 v2.2.1/go.mod h1:wdMgn+sje1KNXdwFizIWjbf328fIUBxqEmJ/vYPo8yc=
charm.land/bubbletea/v2 v2.0.9 h1:DpJCMWKgzQK8SJv4zbKKFHAI10ymWy/evClPFk0k0f8=
charm.land/bubbletea/v2 v2.0.9/go.mod h1:2SkdgoTXluXJHOUwAoRlRXF/28vklb1rFl6GcgV1/ss=
charm.land/catwalk v0.52.8 h1:Spd18CdJjhuxQ8FB/AoudqDthRfhTWmFdI9E8t2bGQw=
charm.land/catwalk v0.52.8/go.mod h1:T0YPUZkPd60T9bvvHwEqALivY+0FoHmMWvaUGTJalHk=
charm.land/fang/v2 v2.0.1 h1:zQCM8JQJ1JnQX/66B5jlCYBUxL2as5JXQZ2KJ6EL0mY=
charm.land/fang/v2 v2.0.1/go.mod h1:S1GmkpcvK+OB5w9caywUnJcsMew45Ot8FXqoz8ALrII=
charm.land/fantasy v0.41.3 h1:MuzL/7iSF1M9LiB+mHQHFYL9oXyYxI5yWQxOu2PaAX4=
Expand Down
Loading