Skip to content

fix(governance): harden Fordham voting contracts - #64

Merged
POWERFULMOVES merged 2 commits into
PMOVES.AI-Edition-Hardenedfrom
agent/governance-contract-hardening
Jul 18, 2026
Merged

POWERFULMOVES merged 2 commits into
PMOVES.AI-Edition-Hardenedfrom
agent/governance-contract-hardening

Conversation

@POWERFULMOVES

Copy link
Copy Markdown
Owner

Hardens the Mode-A governance model against the unresolved correctness and anti-forgery findings from PMOVES.AI #2154.\n\nChanges:\n- validate quorum/pass bounds and require a real 2-of-N-or-stronger committee\n- require exact, distinct committee membership and reject duplicate proposal/roll ids\n- snapshot the eligibility roll per proposal and enforce close-week/finalization state\n- persist immutable finalized tallies and defensively clone attestations\n- require canonical safe-integer tally preimages and exact approver/signature identity binding\n- expand regression coverage for configuration, lifecycle, and forgery cases\n\nValidation:\n- focused contract suite: 4 suites, 115 tests passed\n- full integrations Jest suite: passed\n- npm run typecheck: passed\n- npm run lint: 0 errors; 48 pre-existing no-explicit-any warnings outside this patch\n- git diff --check: passed\n\nParent follow-up: POWERFULMOVES/PMOVES.AI#2154

@coderabbitai

coderabbitai Bot commented Jul 18, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@POWERFULMOVES, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 953ef6ac-a620-42ad-b042-92ddb1fec07d

📥 Commits

Reviewing files that changed from the base of the PR and between 0b978a1 and 234a65c.

📒 Files selected for processing (7)
  • integrations/contracts/__tests__/equalweight-governor-model.test.ts
  • integrations/contracts/__tests__/member-registry-model.test.ts
  • integrations/contracts/__tests__/mode-a-tally.test.ts
  • integrations/contracts/__tests__/tally-signer-ed25519.test.ts
  • integrations/contracts/equalweight-governor-model.ts
  • integrations/contracts/member-registry-model.ts
  • integrations/contracts/tally-signer-ed25519.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/governance-contract-hardening

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 506de765cf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread integrations/contracts/equalweight-governor-model.ts
@POWERFULMOVES
POWERFULMOVES merged commit d17ea07 into PMOVES.AI-Edition-Hardened Jul 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants