Skip to content

Commit

Permalink
hashes for refs should be an opt-in feature (nim-lang#18098)
Browse files Browse the repository at this point in the history
  • Loading branch information
narimiran authored and PMunch committed Mar 28, 2022
1 parent dd5bbc8 commit d66be9e
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 5 deletions.
17 changes: 13 additions & 4 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,9 @@
- On POSIX systems, we now ignore `SIGPIPE` signals, use `-d:nimLegacySigpipeHandler`
for previous behavior.

- `hashes.hash` now supports `object` and `ref` (can be overloaded in user code).
For a transition period, use `-d:nimLegacyNoHashRef` to avoid defining `hash(ref)`.
- `hashes.hash` can now support `object` and `ref` (can be overloaded in user code),
if `-d:nimEnableHashRef` is used.

- `hashes.hash(proc|ptr|ref|pointer)` now calls `hash(int)` and honors `-d:nimIntHash1`,
`hashes.hash(closure)` has also been improved.

Expand Down Expand Up @@ -82,7 +83,9 @@
other defines.



## Standard library additions and changes

- Added support for parenthesized expressions in `strformat`

- Fixed buffer overflow bugs in `net`
Expand All @@ -99,7 +102,6 @@
the OpenSSL DLLs (e.g. libssl-1_1-x64.dll, libcrypto-1_1-x64.dll) you
now also need to ship `cacert.pem` with your `.exe` file.


- Make `{.requiresInit.}` pragma to work for `distinct` types.

- Added a macros `enumLen` for returning the number of items in an enum to the
Expand Down Expand Up @@ -324,6 +326,8 @@

- Fixed premature garbage collection in asyncdispatch, when a stack trace override is in place.



## Language changes

- `nimscript` now handles `except Exception as e`.
Expand Down Expand Up @@ -368,6 +372,8 @@

- `typeof(voidStmt)` now works and returns `void`.



## Compiler changes

- Added `--declaredlocs` to show symbol declaration location in messages.
Expand All @@ -394,7 +400,8 @@
- TLS: OSX now uses native TLS (`--tlsEmulation:off`), TLS now works with importcpp non-POD types,
such types must use `.cppNonPod` and `--tlsEmulation:off`should be used.

- Now array literals(JS backend) uses JS typed arrays when the corresponding js typed array exists, for example `[byte(1), 2, 3]` generates `new Uint8Array([1, 2, 3])`.
- Now array literals(JS backend) uses JS typed arrays when the corresponding js typed array exists,
for example `[byte(1), 2, 3]` generates `new Uint8Array([1, 2, 3])`.

- docgen: rst files can now use single backticks instead of double backticks and correctly render
in both rst2html (as before) as well as common tools rendering rst directly (e.g. github), by
Expand Down Expand Up @@ -426,6 +433,8 @@
the official Nim style guide. To be enabled, this has to be combined either
with `--styleCheck:error` or `--styleCheck:hint`.



## Tool changes

- The rst parser now supports markdown table syntax.
Expand Down
2 changes: 1 addition & 1 deletion lib/pure/hashes.nim
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ proc hash*[T](x: ptr[T]): Hash {.inline.} =
assert cast[pointer](a[0].addr).hash == a[0].addr.hash
hash(cast[pointer](x))

when not defined(nimLegacyNoHashRef):
when defined(nimEnableHashRef):
proc hash*[T](x: ref[T]): Hash {.inline.} =
## Efficient `hash` overload.
runnableExamples:
Expand Down
1 change: 1 addition & 0 deletions tests/collections/ttables.nim
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ And we get here
'''
joinable: false
targets: "c cpp js"
matrix: "-d:nimEnableHashRef"
"""

# xxx wrap in a template to test in VM, see https://github.com/timotheecour/Nim/issues/534#issuecomment-769565033
Expand Down
1 change: 1 addition & 0 deletions tests/stdlib/thashes.nim
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
discard """
targets: "c cpp js"
matrix: "-d:nimEnableHashRef"
"""

import std/hashes
Expand Down

0 comments on commit d66be9e

Please sign in to comment.