Skip to content

[RPC] Expand getstakingstatus output #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
random-zebra merged 7 commits into from
Mar 18, 2020
Merged

[RPC] Expand getstakingstatus output #1368

random-zebra merged 7 commits into from
Mar 18, 2020

Conversation

@random-zebra
Copy link

@random-zebra random-zebra commented Mar 2, 2020

Add the number of staked/available coins during last attempt to CStakerStatus.

Remove the following attributes from getstakingstatus output

  • "tiptime"
  • "hashLastStakeAttempt"
  • "heightLastStakeAttempt"
  • "timeLastStakeAttempt"

Add the following attributes to getstakingstatus output:

  • "lastattempt_age" (numeric, seconds since last stake attempt)
  • "lastattempt_depth" (numeric, depth of the block on top of which the last stake attempt was made)
  • "lastattempt_hash" (hex string, hash of the block on top of which the last stake attempt was made)
  • "lastattempt_coins" (numeric, number of stakeable coins available during last stake attempt)
  • "lastattempt_tries" (numeric, number of stakeable coins checked during last stake attempt)
  • "stakeablecoins" (numeric, number of stakeable UTXOs)
  • "stakingbalance" (numeric, PIV value of the stakeable coins, minus reserve balance, if any)
  • "stakesplitthreshold" (numeric, value of the current threshold for stake split)
  • "coldstaking_enabled" ((boolean, whether cold-staking is enabled/disabled in pivx.conf)

@random-zebra random-zebra added this to the 4.1.0 milestone Mar 2, 2020
@random-zebra random-zebra self-assigned this Mar 2, 2020
@akshaynexus
Copy link

akshaynexus commented Mar 2, 2020

does stakingbalance include the coldstaking balance?

@akshaynexus
Copy link

akshaynexus commented Mar 2, 2020

nvm looks like it does

@random-zebra
Copy link
Author

random-zebra commented Mar 2, 2020

nvm looks like it does

Yes, if -coldstaking is enabled (which is the default)

@random-zebra random-zebra mentioned this pull request Mar 3, 2020
Merged
Fuzzbawls
Fuzzbawls reviewed Mar 4, 2020
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. couple initial comments.

also note that this will conflict slightly with #1373, so one of the PRs will need changes depending on merge order

@random-zebra random-zebra force-pushed the 2020_getstakingstatus branch from 725f37c to cb31cc0 Compare March 4, 2020 09:35
@random-zebra
Copy link
Author

random-zebra commented Mar 4, 2020

Fixed mnsync check to be more in line with the miner code, and updated release notes as per @Fuzzbawls review.

I suggest to review/merge #1373 first, as it's easier. Will rebase this one afterwards.

@random-zebra random-zebra force-pushed the 2020_getstakingstatus branch from 3857538 to 1375c51 Compare March 11, 2020 09:00
@random-zebra
Copy link
Author

random-zebra commented Mar 11, 2020

Rebased

@random-zebra
[RPC] getstakingstatus: refactor lastAttempt attributes
fa7df1d 
remove tiptime, hashLastStakeAttempt, heightLastStakeAttempt,
timeLastStakeAttempt

replace with more manageable
- lastattempt_age
- lastattempt_depth
- lastattempt_hash
@random-zebra
[PoS][RPC] Staker Status: Add number of stakeable utxos hashed/available
c9008da
@random-zebra
[RPC] getstakingstatus: stakeablecoins and stakingbalance
d2985dc 
- change "stakeablecoins": from boolean value to int (number of
stakeable utxos)
- add "stakingbalance": total (double) PIV value of stakeable coins
@random-zebra
[RPC] getstakingstatus: add stakesplitthreshold and coldstaking_enabled
ce6069c
@random-zebra
[Doc] Document changes to getstakingstatus output
993e06e
@random-zebra
[RPC] Fix mnsync check in getstakingstatus
52c36d4
@random-zebra
[Trivial][Cleanup] Complete CStakerStatus::SetNull()
bb3967f
@random-zebra random-zebra force-pushed the 2020_getstakingstatus branch from 1375c51 to bb3967f Compare March 18, 2020 00:24
@random-zebra
Copy link
Author

random-zebra commented Mar 18, 2020

Rebased.

Fuzzbawls
Fuzzbawls approved these changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bb3967f

@random-zebra random-zebra merged commit d610d01 into PIVX-Project:master Mar 18, 2020
akshaynexus pushed a commit to ZENZO-Ecosystem/ZENZO-Core that referenced this pull request Mar 22, 2020
@random-zebra @akshaynexus
Merge PIVX-Project#1368: [RPC] Expand getstakingstatus output
5f9a895 
bb3967f [Trivial][Cleanup] Complete CStakerStatus::SetNull() (random-zebra)
52c36d4 [RPC] Fix mnsync check in getstakingstatus (random-zebra)
993e06e [Doc] Document changes to getstakingstatus output (random-zebra)
ce6069c [RPC] getstakingstatus: add stakesplitthreshold and coldstaking_enabled (random-zebra)
d2985dc [RPC] getstakingstatus: stakeablecoins and stakingbalance (random-zebra)
c9008da [PoS][RPC] Staker Status: Add number of stakeable utxos hashed/available (random-zebra)
fa7df1d [RPC] getstakingstatus: refactor lastAttempt attributes (random-zebra)

Pull request description:

  Add the number of staked/available coins during last attempt to `CStakerStatus`.

  Remove the following attributes from `getstakingstatus` output
   - "tiptime"
   - "hashLastStakeAttempt"
   - "heightLastStakeAttempt"
   - "timeLastStakeAttempt"

  Add the following attributes to `getstakingstatus` output:
    - "lastattempt_age" (numeric, seconds since last stake attempt)
    - "lastattempt_depth" (numeric, depth of the block on top of which the last stake attempt was made)
    - "lastattempt_hash" (hex string, hash of the block on top of which the last stake attempt was made)
    - "lastattempt_coins" (numeric, number of stakeable coins available during last stake attempt)
    - "lastattempt_tries" (numeric, number of stakeable coins checked during last stake attempt)
    - "stakeablecoins" (numeric, number of stakeable UTXOs)
    - "stakingbalance" (numeric, PIV value of the stakeable coins, minus reserve balance, if any)
    - "stakesplitthreshold" (numeric, value of the current threshold for stake split)
    - "coldstaking_enabled" ((boolean, whether cold-staking is enabled/disabled in pivx.conf)

ACKs for top commit:
  Fuzzbawls:
    ACK bb3967f

Tree-SHA512: 3d90cb08043448611498dc90486af5ab8b712851f29a74d1c1cd6372f19b08fba84f6d8e29776e0028ed83209362ea9707121804865d3db2eb96a8082eab10f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

@furszy furszy Awaiting requested review from furszy

Assignees

@random-zebra random-zebra

Labels

RPC Wallet

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@random-zebra @akshaynexus @Fuzzbawls