This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move CI from Travis to GitHub #60
Move CI from Travis to GitHub #60
Changes from all commits
accb39d
6b544cf
2364e4e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initial solution was iterating over each PHP Version and each PHPUnit version, if they are compatible - run the tests.
now, we hardcoded the valid combinations, hoping we will never forget to add a valid variation.I think it's error-prone , but we also don't have so many changes in this repo, so not blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand the script correctly, it wasn't “if they are compatible”, but “if
composer require && composer update
does not fail”, which is also error-prone. I don't have any good idea how to do this check reliably.This file was deleted.
This file was deleted.