Skip to content

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Aug 24, 2025

Fix #2912, another oldie (3+ years). Removal of rows or columns which include part of the print area is not recalculating the print area correctly. This PR will correct that problem.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

Fix PHPOffice#2912, another oldie (3+ years). Removal of rows or columns which include part of the print area is not recalculating the print area correctly. This PR will correct that problem, but only if the print area consists of a single range. I think that is by far the most common use case. If there is a demonstrated need to handle multiple ranges, I will respond to a new issue.
@oleibman
Copy link
Collaborator Author

I am getting quite fed up with Scrutinizer.

@oleibman oleibman enabled auto-merge August 26, 2025 16:13
@oleibman oleibman added this pull request to the merge queue Aug 26, 2025
Merged via the queue into PHPOffice:master with commit b99dc60 Aug 26, 2025
13 checks passed
@oleibman oleibman deleted the issue2912 branch August 26, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

unexpected behavior after Worksheet::removeRow().

1 participant