Shared/Date::isDateTime Handle Cells Which Calculate as Arrays #4562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #4557, the user complains, with some justification, about the way Excel handles certain calculations. We are not able to help with that problem. However, the user also notes a problem in Shared/Date when
isDateTime
has to evaluate a cell whose calculated value is an array. This is solved by flattening the calculated result to a single value.It became obvious while working on this change that the code to set
instanceArrayReturnType
was kind of awkward. Simpler methodsreturnArrayAsArray
andreturnArrayAsValue
are added toSpreadsheet
. Even these started out a bit awkward becauseSpreadsheet::calculationEngine
was defined as nullable, which really isn't true. It is allocated by the constructor, and never freed except in the destructor. It is no longer nullable.This is:
Checklist: