Skip to content

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Jul 22, 2025

When Conditional and Table Formatting were added to Html Writer, properties, getters, and setters were added to Base Writer. They should have been added to Html Writer instead, and this PR moves them from one to the other. It is technically a breaking change, but, since there is no reason to use them with any writer other than Html, I don't anticipate anyone seeing any adverse effects.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

When Conditional and Table Formatting were added to Html Reader, properties, getters, and setters were added to BaseReader. They should have been added to Html Reader instead, and this PR moves them from one to the other. It is technically a breaking change, but, since there is no reason to use them with any writer other than Html, I don't anticipate anyone seeing any adverse effects.
@oleibman oleibman added this pull request to the merge queue Aug 3, 2025
Merged via the queue into PHPOffice:master with commit 7e89ad9 Aug 3, 2025
14 checks passed
@oleibman oleibman deleted the base2html branch August 3, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant