Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ods Writer Eliminate Padding at End of Row #4264

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Dec 6, 2024

Ods Writer currently will write something like <table:table-cell table:number-columns-repeated="1023" /> at the end of each row. This is not necessary. In eliminating that, I have made the code a bit more efficient and (hopefully) more readable.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

Ods Writer currently will write something like `<table:table-cell table:number-columns-repeated="1023" />` at the end of each row. This is not necessary. In eliminating that, I have made the code a bit more efficient and (hopefully) more readable.
@oleibman oleibman added this pull request to the merge queue Dec 15, 2024
Merged via the queue into PHPOffice:master with commit b03e10b Dec 15, 2024
13 of 14 checks passed
@oleibman oleibman deleted the odsrepeat branch December 15, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant