Skip to content

Conversation

@oleibman
Copy link
Collaborator

Fix #476. Another in the "better late than never" series, closed as stale in June 2018. Xlsx Writer expects cells containing RichText to have DataType TYPE_INLINE; but the spreadsheet associated with the issue has the cell defined as TYPE_STRING. Change Writer to handle RichText TYPE_STRING appropriately.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

oleibman added 3 commits July 11, 2024 20:05
Fix PHPOffice#476. Another in the "better late than never" series, closed as stale in June 2018. Xlsx Writer expects cells containing RichText to have DataType `TYPE_INLINE`; but the spreadsheet associated with the issue has the cell defined as `TYPE_STRING`. Change Writer to handle RichText TYPE_STRING appropriately.
@oleibman oleibman enabled auto-merge July 18, 2024 00:42
@oleibman oleibman added this pull request to the merge queue Jul 18, 2024
Merged via the queue into PHPOffice:master with commit fcf03b9 Jul 18, 2024
@oleibman oleibman deleted the issue476 branch July 18, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

splitted RichElements

1 participant