Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phpstan and ArrayEnabled #3891

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Phpstan and ArrayEnabled #3891

merged 1 commit into from
Feb 4, 2024

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Feb 4, 2024

Phpstan baseline had been reduced to almost nothing, but recently had a big bump in size. Almost all of the increase was due to trait ArrayEnabled, which is easily recoded to avoid the problems.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • code quality

Checklist:

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

Phpstan baseline had been reduced to almost nothing, but recently had a big bump in size. Almost all of the increase was due to trait ArrayEnabled, which is easily recoded to avoid the problems.
@oleibman oleibman added this pull request to the merge queue Feb 4, 2024
Merged via the queue into PHPOffice:master with commit a444d1c Feb 4, 2024
14 checks passed
@oleibman oleibman deleted the stanarray branch February 4, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant