-
Notifications
You must be signed in to change notification settings - Fork 3.6k
PHPOffice/PHPExcel GH-558 Check if Styles exist in Excel2003XML file #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPOffice/PHPExcel GH-558 Check if Styles exist in Excel2003XML file #331
Conversation
…XML file before iterating I have encountered an Excel2003XML file which does not contain styles at all. Due to this the reader throws a warning when trying to iterate over the styles array. > Warning: Invalid argument supplied for foreach() in /vendor/phpoffice/phpexcel/Classes/PHPExcel/Reader/Excel2003XML.php on line 411
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding another nested level, please extract everything into a private method readStyles()
which return early if there is no style present.
And add a unit test for that case.
@PowerKiKi See the Issue and PR from the other project from two years ago. I can't even find the file in question at this point. I broke out the block of code as requested, but that's it. |
- Support for PHP 7.2 - Support cell comments in HTML writer and reader - [#308](#308) - Option to stop at a conditional styling, if it matches (only XLSX format) - [#292](#292) - Support for line width for data series when rendering Xlsx - [#329](#329) - Better auto-detection of CSV separators - [#305](#305) - Support for shape style ending with `;` - [#304](#304) - Freeze Panes takes wrong coordinates for XLSX - [#322](#322) - `COLUMNS` and `ROWS` functions crashed in some cases - [#336](#336) - Support XML file without styles - [#331](#331) - Cell coordinates which are already a range cause an exception [#319](#319)
Closes PHPOffice#331 Closes PHPOffice/PHPExcel#559 Fixes PHPOffice/PHPExcel#558
- Support for PHP 7.2 - Support cell comments in HTML writer and reader - [PHPOffice#308](PHPOffice#308) - Option to stop at a conditional styling, if it matches (only XLSX format) - [PHPOffice#292](PHPOffice#292) - Support for line width for data series when rendering Xlsx - [PHPOffice#329](PHPOffice#329) - Better auto-detection of CSV separators - [PHPOffice#305](PHPOffice#305) - Support for shape style ending with `;` - [PHPOffice#304](PHPOffice#304) - Freeze Panes takes wrong coordinates for XLSX - [PHPOffice#322](PHPOffice#322) - `COLUMNS` and `ROWS` functions crashed in some cases - [PHPOffice#336](PHPOffice#336) - Support XML file without styles - [PHPOffice#331](PHPOffice#331) - Cell coordinates which are already a range cause an exception [PHPOffice#319](PHPOffice#319)
Closes PHPOffice#331 Closes PHPOffice/PHPExcel#559 Fixes PHPOffice/PHPExcel#558
- Support for PHP 7.2 - Support cell comments in HTML writer and reader - [PHPOffice#308](PHPOffice#308) - Option to stop at a conditional styling, if it matches (only XLSX format) - [PHPOffice#292](PHPOffice#292) - Support for line width for data series when rendering Xlsx - [PHPOffice#329](PHPOffice#329) - Better auto-detection of CSV separators - [PHPOffice#305](PHPOffice#305) - Support for shape style ending with `;` - [PHPOffice#304](PHPOffice#304) - Freeze Panes takes wrong coordinates for XLSX - [PHPOffice#322](PHPOffice#322) - `COLUMNS` and `ROWS` functions crashed in some cases - [PHPOffice#336](PHPOffice#336) - Support XML file without styles - [PHPOffice#331](PHPOffice#331) - Cell coordinates which are already a range cause an exception [PHPOffice#319](PHPOffice#319)
I have encountered an Excel2003XML file which does not contain styles at all. Due to this the reader throws a warning when trying to iterate over the styles array.
This is:
Checklist:
Why this change is needed?
See PHPOffice/PHPExcel#558 and PHPOffice/PHPExcel#559