Skip to content

PHPOffice#1318 Enable images in FirstHeader/FirstFooter #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

PHPOffice#1318 Enable images in FirstHeader/FirstFooter #1397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c6cef6
PHPOffice#1318 Enable images in FirstHeader/FirstFooter
ljcag Feb 27, 2020
39dcfea
Merge branch 'master' into master
ljcag Mar 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org).
- Fix active cell when freeze pane is used [#1323](https://github.com/PHPOffice/PhpSpreadsheet/pull/1323)
- Fix XLSX file loading with autofilter containing '$' [#1326](https://github.com/PHPOffice/PhpSpreadsheet/pull/1326)
- PHPDoc - Use `@return $this` for fluent methods [#1362](https://github.com/PHPOffice/PhpSpreadsheet/pull/1362)
- Fix FirstHeader/FirstFooter get lost during writing[#1318](https://github.com/PHPOffice/PhpSpreadsheet/pull/1334)

## [1.10.1] - 2019-12-02

Expand Down
24 changes: 24 additions & 0 deletions src/PhpSpreadsheet/Worksheet/HeaderFooter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@ class HeaderFooter
const IMAGE_FOOTER_LEFT = 'LF';
const IMAGE_FOOTER_CENTER = 'CF';
const IMAGE_FOOTER_RIGHT = 'RF';
const IMAGE_HEADER_LEFT_FIRST = 'LHFIRST';
const IMAGE_HEADER_CENTER_FIRST = 'CHFIRST';
const IMAGE_HEADER_RIGHT_FIRST = 'RHFIRST';
const IMAGE_FOOTER_LEFT_FIRST = 'LFFIRST';
const IMAGE_FOOTER_CENTER_FIRST = 'CFFIRST';
const IMAGE_FOOTER_RIGHT_FIRST = 'RFFIRST';

/**
* OddHeader.
Expand Down Expand Up @@ -469,6 +475,24 @@ public function getImages()
if (isset($this->headerFooterImages[self::IMAGE_FOOTER_RIGHT])) {
$images[self::IMAGE_FOOTER_RIGHT] = $this->headerFooterImages[self::IMAGE_FOOTER_RIGHT];
}
if (isset($this->headerFooterImages[self::IMAGE_HEADER_LEFT_FIRST])) {
$images[self::IMAGE_HEADER_LEFT_FIRST] = $this->headerFooterImages[self::IMAGE_HEADER_LEFT_FIRST];
}
if (isset($this->headerFooterImages[self::IMAGE_HEADER_CENTER_FIRST])) {
$images[self::IMAGE_HEADER_CENTER_FIRST] = $this->headerFooterImages[self::IMAGE_HEADER_CENTER_FIRST];
}
if (isset($this->headerFooterImages[self::IMAGE_HEADER_RIGHT_FIRST])) {
$images[self::IMAGE_HEADER_RIGHT_FIRST] = $this->headerFooterImages[self::IMAGE_HEADER_RIGHT_FIRST];
}
if (isset($this->headerFooterImages[self::IMAGE_FOOTER_LEFT_FIRST])) {
$images[self::IMAGE_FOOTER_LEFT_FIRST] = $this->headerFooterImages[self::IMAGE_FOOTER_LEFT_FIRST];
}
if (isset($this->headerFooterImages[self::IMAGE_FOOTER_CENTER_FIRST])) {
$images[self::IMAGE_FOOTER_CENTER_FIRST] = $this->headerFooterImages[self::IMAGE_FOOTER_CENTER_FIRST];
}
if (isset($this->headerFooterImages[self::IMAGE_FOOTER_RIGHT_FIRST])) {
$images[self::IMAGE_FOOTER_RIGHT_FIRST] = $this->headerFooterImages[self::IMAGE_FOOTER_RIGHT_FIRST];
}
$this->headerFooterImages = $images;

return $this->headerFooterImages;
Expand Down