Hidden columns are not respected in XML format #3566
Description
This is:
- [ ?] a bug report
- [ X] a feature request
- [ X] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)
What is the expected behavior?
If an XML-File is imported columns and Rows with ss:Hidden="1" should be hidden.
What is the current behavior?
Those columns are visible (because no code path exists to process the Hidden attribute). I am unsure whether this qualifies as a bug or as a missing feature.
What are the steps to reproduce?
Use the attached file (github refuses to upload xml, so I declared it as plain text).
What features do you think are causing the issue
- [ X] Reader
Does an issue affect all spreadsheet file formats? If not, which formats are affected?
Only XML is affected.
Which versions of PhpSpreadsheet and PHP are affected?
All versions are affected.
The patch to fix this is only 8 lines; I created a fork, but as I have no experience with the whole tool chain (not github, not composer, not unit testing) I refrain from converting it into a pull request.
test.txt