[Feature] Can set min and max values for axes.#2751
Open
jfoucher wants to merge 1 commit intoPHPOffice:masterfrom
Open
[Feature] Can set min and max values for axes.#2751jfoucher wants to merge 1 commit intoPHPOffice:masterfrom
jfoucher wants to merge 1 commit intoPHPOffice:masterfrom
Conversation
Member
|
@jfoucher Could you rebase the PR against the |
Author
|
Should be good to go. Squashed my commits as well. Let me know if something's wrong |
Progi1984
reviewed
Jun 5, 2025
Comment on lines
+594
to
+597
| public function setMinY($minY): void | ||
| { | ||
| $this->minY = $minY; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| public function setMinY($minY): void | |
| { | |
| $this->minY = $minY; | |
| } | |
| public function setMinY($minY): self | |
| { | |
| $this->minY = $minY; | |
| return $this; | |
| } |
@jfoucher Can you return $this for each setter, please ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows for setting min and max values for axes in Word2007 writer, by passing 4 more style options.
Fixes #1756 and #2333
Checklist: