-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shapes and fix for sample broken charts #435
Conversation
Arrow pointer is now added as a shape.
Arrow Pointer as a shape
Triangle as a shape is added
Rectangle as a shape is added
@mhasanshahid What a good job. Could you look at the log of Travis for fixing it before merge (PHPCS & PHPUnit) |
@Progi1984 Yes I will fix it as early as possible. |
@mhasanshahid Why do you remove the Doughnut Chart ? |
Because I dont have it in my local cloned version. I am under a testing phase, will update it. |
@mhasanshahid Hi Could you merge develop branch of PhpPresentation in your branch, please ? Thank you |
@mhasanshahid The "AutoShape" or "Geometric shape" have been added in v1.0.0 (#545). You can check the documentation : https://phpoffice.github.io/PHPPresentation/usage/shapes/autoshape.html (And fixes have been done in Is it ok for you ? |
Shapes like arrow pointer, rectangle, triangle, and round rectangle has been added, In samples were given charts that are seems to be broken with this master branch, Changes have been made to fix all the given sample charts.