Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shapes and fix for sample broken charts #435

Closed
wants to merge 28 commits into from

Conversation

mhasanshahid
Copy link
Contributor

Shapes like arrow pointer, rectangle, triangle, and round rectangle has been added, In samples were given charts that are seems to be broken with this master branch, Changes have been made to fix all the given sample charts.

@Progi1984 Progi1984 self-assigned this Jan 2, 2018
@Progi1984 Progi1984 added this to the 0.10.0 milestone Jan 2, 2018
@Progi1984
Copy link
Member

@mhasanshahid What a good job. Could you look at the log of Travis for fixing it before merge (PHPCS & PHPUnit)
https://travis-ci.org/PHPOffice/PHPPresentation/jobs/324072125

@mhasanshahid
Copy link
Contributor Author

@Progi1984 Yes I will fix it as early as possible.

@Progi1984
Copy link
Member

@mhasanshahid Why do you remove the Doughnut Chart ?

@mhasanshahid
Copy link
Contributor Author

Because I dont have it in my local cloned version. I am under a testing phase, will update it.

@jeffsrepoaccount jeffsrepoaccount mentioned this pull request Apr 2, 2018
10 tasks
@Progi1984
Copy link
Member

@mhasanshahid Hi Could you merge develop branch of PhpPresentation in your branch, please ? Thank you

@Progi1984 Progi1984 modified the milestones: 1.0.0, 1.1.0 Sep 9, 2021
@Progi1984 Progi1984 removed this from the 1.1.0 milestone Nov 24, 2023
@Progi1984 Progi1984 added this to the 1.1.0 milestone Dec 7, 2023
@Progi1984
Copy link
Member

@mhasanshahid The "AutoShape" or "Geometric shape" have been added in v1.0.0 (#545).

You can check the documentation : https://phpoffice.github.io/PHPPresentation/usage/shapes/autoshape.html
Or the sample file : https://github.com/PHPOffice/PHPPresentation/blob/develop/samples/Sample_21_AutoShape.php

(And fixes have been done in develop branch about broken charts).

Is it ok for you ?

@Progi1984 Progi1984 closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants