Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed PowerPoint2007 writer attributes to protected #20

Merged
merged 1 commit into from
Apr 27, 2014

Conversation

delphiki
Copy link
Contributor

Right now the attributes are private and we can't extend the PowerPoint2007 writer.

@ivanlanin
Copy link
Contributor

There are public methods to get/set those properties. Do we need to extend this class?

@delphiki
Copy link
Contributor Author

There's a method to specify a custom writer, but no ability to actually define one based on another one.
Plus, not all attributes have a getter and setter. For example _drawingHashTable has no setter.

ivanlanin added a commit that referenced this pull request Apr 27, 2014
Changed PowerPoint2007 writer attributes to protected
@ivanlanin ivanlanin merged commit 50fd978 into PHPOffice:master Apr 27, 2014
@Progi1984 Progi1984 added this to the 0.2.0 milestone Apr 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants