Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bar charts are not honouring the setLabelPosition #268

Closed
pgee70 opened this issue Sep 15, 2016 · 6 comments
Closed

bar charts are not honouring the setLabelPosition #268

pgee70 opened this issue Sep 15, 2016 · 6 comments

Comments

@pgee70
Copy link
Contributor

pgee70 commented Sep 15, 2016

Hi, this one is easy!
the PhpOffice\PhpPresentation\Writer\PowerPoint2007\PptCharts.php::writeTypeBar does not honour series:setLabelPosition.

in line 982 adding:

$this->writeElementWithValAttribute($objWriter, 'c:dLblPos', $series->getLabelPosition());

seems to fix the issue (i just looked at the code for writeTypePie to see this.

@Progi1984
Copy link
Member

@pgee70 Hi, Could you give me a screenshot with the bug ? Thanks.

@pgee70
Copy link
Contributor Author

pgee70 commented Sep 16, 2016

Thanks for responding.
It is not something taking a screenshot of can help. The code isn't implemented so the feature doesn't work.
The column label position just goes to the default position - I wanted it to go in the end of the label and it wouldn't work.

When that line is added the label position behaves as expected.

@Progi1984
Copy link
Member

@pgee70 I just modified your fix. Could you test the PR #289 ?

@Progi1984
Copy link
Member

@pgee70 Some feedback, please.

1 similar comment
@Progi1984
Copy link
Member

@pgee70 Some feedback, please.

Progi1984 added a commit to Progi1984/PHPPresentation that referenced this issue Jan 15, 2017
Progi1984 added a commit that referenced this issue Jan 15, 2017
#268 : Fixed the label position in bar chart
@Progi1984
Copy link
Member

@pgee70 Fixed in develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants