Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md missing requirements #251

Closed
danielbair opened this issue Aug 18, 2016 · 3 comments
Closed

README.md missing requirements #251

danielbair opened this issue Aug 18, 2016 · 3 comments
Assignees
@Progi1984
Labels
Type - Documentation
Milestone
0.7.0

Comments

@danielbair
Copy link
Contributor

danielbair commented Aug 18, 2016 •
edited by Progi1984
Loading

The README.md does not mention the PHPOffice/Common as a requirement for PHPPresentation.
Thus if one is downloading PHPPresentation source and attempting to use the samples it will throw errors about PHPOffice/Common/... file not found.
@danielbair
Copy link
Contributor Author

I have created a pull request here... #254

@Progi1984 Progi1984 added this to the 0.7.0 milestone Aug 24, 2016
@Progi1984
Copy link
Member

Fixed in the commit dbc34df.

@Progi1984 Progi1984 self-assigned this Aug 24, 2016
Progi1984 added a commit to Progi1984/PHPPresentation that referenced this issue Sep 8, 2016
@Progi1984
PHPOffice#251 : Documentation for manual install
0f4e6cd
Progi1984 added a commit that referenced this issue Sep 8, 2016
@Progi1984
Merge pull request #259 from Progi1984/issue251
07b3bcc 
#251 : Documentation for manual install
@Progi1984
Copy link
Member

And documentation added : http://phppresentation.readthedocs.io/en/develop/installing.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Progi1984 Progi1984

Labels
Type - Documentation
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@danielbair @Progi1984