Merge pull request #777 from Progi1984/pr572

Raised max value for identifier rand call
PHPOffice · Dec 7, 2023 · ce54114 · ce54114
2 parents fa6fc54 + a958884
commit ce54114
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/docs/changes/1.1.0.md b/docs/changes/1.1.0.md
@@ -12,6 +12,9 @@
 - Added support for PHP 8.2 & 8.3 - [@Progi1984](https://github.com/Progi1984) in [#769](https://github.com/PHPOffice/PHPPresentation/pull/769)
 - PowerPoint 2007 Writer : Added support to Font for Axis tick label & chinese font support - [@zhengwhizz](https://github.com/zhengwhizz) in [#774](https://github.com/PHPOffice/PHPPresentation/pull/774)
 
+## Improvements
+- Slide : Raised max value for identifier rand call - [@Scheissy](https://github.com/Scheissy) in [#777](https://github.com/PHPOffice/PHPPresentation/pull/777)
+
 ## Bugfixes
 
 - Fixed CI - [@Progi1984](https://github.com/Progi1984) in [#766](https://github.com/PHPOffice/PHPPresentation/pull/766)

diff --git a/src/PhpPresentation/Slide.php b/src/PhpPresentation/Slide.php
@@ -77,7 +77,7 @@ public function __construct(?PhpPresentation $pParent = null)
         // Shape collection
         $this->shapeCollection = new ArrayObject();
         // Set identifier
-        $this->identifier = md5(mt_rand(0, 9999) . time());
+        $this->identifier = md5(mt_rand(0, mt_getrandmax()) . time());
         // Set Slide Layout
         if ($this->parent instanceof PhpPresentation) {
             $arrayMasterSlides = $this->parent->getAllMasterSlides();