This repository has been archived by the owner on Jan 2, 2019. It is now read-only.
Fix wrong logic in VLOOKUP #453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: - If lookup value was numeric, the return value also had to be numeric. - If the lookup value wasn't numeric, the return value also couldn't be numeric. This doesn't make sense. What is returned does not and should not depend in any way on the type of what is being looked for. The [documentation](http://office.microsoft.com/en-us/excel-help/vlookup-HP005209335.aspx) also doesn't mention anything about this. The behaviour of `VLOOKUP` is now also matching the behaviour of `HLOOKUP`.
|
Hadn't seen #423, which is the exact same fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
This doesn't make sense. What is returned does not and should not depend in any way on the type of what is being looked for. The documentation also doesn't mention anything about this.
The behaviour of
VLOOKUPis now also matching the behaviour ofHLOOKUP.See also #385.