DX: update phpstan/phpstan-strict-rules (#7924)

PHP-CS-Fixer · Apr 7, 2024 · 87c75fa · 87c75fa
1 parent c7f60ee
commit 87c75fa
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 15 deletions.
diff --git a/dev-tools/composer.json b/dev-tools/composer.json
@@ -9,7 +9,7 @@
         "phpstan/extension-installer": "^1.3.1",
         "phpstan/phpstan": "^1.10.62",
         "phpstan/phpstan-phpunit": "^1.3.16",
-        "phpstan/phpstan-strict-rules": "^1.5.2"
+        "phpstan/phpstan-strict-rules": "^1.5.3"
     },
     "config": {
         "allow-plugins": {

diff --git a/dev-tools/composer.lock b/dev-tools/composer.lock
diff --git a/src/Documentation/FixerDocumentGenerator.php b/src/Documentation/FixerDocumentGenerator.php
@@ -125,13 +125,16 @@ public function generateFixerDocumentation(FixerInterface $fixer): string
             }
 
             $warningsHeaderLine = str_repeat('-', \strlen($warningsHeader));
-            $doc .= "\n\n".implode("\n", array_filter([
-                $warningsHeader,
-                $warningsHeaderLine,
-                $deprecationDescription,
-                $experimentalDescription,
-                $riskyDescription,
-            ]));
+            $doc .= "\n\n".implode("\n", array_filter(
+                [
+                    $warningsHeader,
+                    $warningsHeaderLine,
+                    $deprecationDescription,
+                    $experimentalDescription,
+                    $riskyDescription,
+                ],
+                static fn (string $text): bool => '' !== $text
+            ));
         }
 
         if ($fixer instanceof ConfigurableFixerInterface) {

diff --git a/src/RuleSet/RuleSet.php b/src/RuleSet/RuleSet.php
@@ -108,7 +108,10 @@ private function resolveSet(array $rules): void
         }
 
         // filter out all resolvedRules that are off
-        $resolvedRules = array_filter($resolvedRules);
+        $resolvedRules = array_filter(
+            $resolvedRules,
+            static fn ($value): bool => false !== $value
+        );
 
         $this->rules = $resolvedRules;
     }